* [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
@ 2020-01-09 22:14 Evelyn Wang
2020-01-09 22:25 ` Chaganty, Rangasai V
2020-01-10 0:25 ` Yao, Jiewen
0 siblings, 2 replies; 3+ messages in thread
From: Evelyn Wang @ 2020-01-09 22:14 UTC (permalink / raw)
To: devel; +Cc: Jenny Huang, More Shih, Ray Ni, Rangasai V Chaganty, Jiewen Yao
The function has NO comment immediately preceding it.
Need to remove the space between the function and the comment
Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: More Shih <more.shih@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
In V1:
Add a issue description
---
Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
index ebfe904053..86c519f48d 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
@@ -13,7 +13,6 @@
Get the global VT-d protected memory alignment.
@return The maximum protected memory alignment. Ex: 0x100000
**/
-
UINTN
EFIAPI
GetGlobalVtdPmrAlignment (
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
2020-01-09 22:14 [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error Evelyn Wang
@ 2020-01-09 22:25 ` Chaganty, Rangasai V
2020-01-10 0:25 ` Yao, Jiewen
1 sibling, 0 replies; 3+ messages in thread
From: Chaganty, Rangasai V @ 2020-01-09 22:25 UTC (permalink / raw)
To: Wang, Iwen Evelyn, devel@edk2.groups.io
Cc: Huang, Jenny, Shih, More, Ni, Ray, Yao, Jiewen
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Wang, Iwen Evelyn <iwen.evelyn.wang@intel.com>
Sent: Thursday, January 09, 2020 2:15 PM
To: devel@edk2.groups.io
Cc: Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
The function has NO comment immediately preceding it.
Need to remove the space between the function and the comment
Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: More Shih <more.shih@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
In V1:
Add a issue description
---
Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
index ebfe904053..86c519f48d 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmen
+++ tLib.h
@@ -13,7 +13,6 @@
Get the global VT-d protected memory alignment.
@return The maximum protected memory alignment. Ex: 0x100000 **/
-
UINTN
EFIAPI
GetGlobalVtdPmrAlignment (
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
2020-01-09 22:14 [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error Evelyn Wang
2020-01-09 22:25 ` Chaganty, Rangasai V
@ 2020-01-10 0:25 ` Yao, Jiewen
1 sibling, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2020-01-10 0:25 UTC (permalink / raw)
To: Wang, Iwen Evelyn, devel@edk2.groups.io
Cc: Huang, Jenny, Shih, More, Ni, Ray, Chaganty, Rangasai V
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Wang, Iwen Evelyn <iwen.evelyn.wang@intel.com>
> Sent: Friday, January 10, 2020 6:15 AM
> To: devel@edk2.groups.io
> Cc: Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
>
> The function has NO comment immediately preceding it.
> Need to remove the space between the function and the comment
>
> Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
> Cc: Jenny Huang <jenny.huang@intel.com>
> Cc: More Shih <more.shih@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> ---
> In V1:
> Add a issue description
> ---
> Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> index ebfe904053..86c519f48d 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> @@ -13,7 +13,6 @@
> Get the global VT-d protected memory alignment.
> @return The maximum protected memory alignment. Ex: 0x100000
> **/
> -
> UINTN
> EFIAPI
> GetGlobalVtdPmrAlignment (
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 0:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-09 22:14 [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error Evelyn Wang
2020-01-09 22:25 ` Chaganty, Rangasai V
2020-01-10 0:25 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox