Re: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2.

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
> 
> Change the SecurityPkg to match the ECC check rule
> 
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> index 1fe1955cab..9a5f987e68 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> @@ -772,7 +772,7 @@ Tcg2GetEventLog (
>    return EFI_SUCCESS;
>  }
> 
> -/*
> +/**
>    Return if this is a Tcg800155PlatformIdEvent.
> 
>    @param[in]      NewEventHdr         Pointer to a
> TCG_PCR_EVENT_HDR/TCG_PCR_EVENT_EX data structure.
> @@ -783,7 +783,7 @@ Tcg2GetEventLog (
>    @retval TRUE   This is a Tcg800155PlatformIdEvent.
>    @retval FALSE  This is NOT a Tcg800155PlatformIdEvent.
> 
> -*/
> +**/
>  BOOLEAN
>  Is800155Event (
>    IN      VOID                      *NewEventHdr,
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 7e94a8e1ed..4852d86906 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -460,7 +460,7 @@ MeasureCRTMVersion (
>             );
>  }
> 
> -/*
> +/**
>    Get the FvName from the FV header.
> 
>    Causion: The FV is untrusted input.
> @@ -470,7 +470,7 @@ MeasureCRTMVersion (
> 
>    @return FvName pointer
>    @retval NULL   FvName is NOT found
> -*/
> +**/
>  VOID *
>  GetFvName (
>    IN EFI_PHYSICAL_ADDRESS           FvBase,
> --
> 2.17.1
> 
> 
>