From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.4564.1581589392536698905 for ; Thu, 13 Feb 2020 02:23:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 02:23:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,436,1574150400"; d="scan'208";a="228101787" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 13 Feb 2020 02:23:11 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Feb 2020 02:23:11 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Feb 2020 02:23:10 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.126]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.46]) with mapi id 14.03.0439.000; Thu, 13 Feb 2020 18:23:09 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2. Thread-Topic: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2. Thread-Index: AQHV4khp5InlzXmJaU+RhCTUdGQl6KgY6oow Date: Thu, 13 Feb 2020 10:23:08 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F92CDF0@shsmsx102.ccr.corp.intel.com> References: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> <4c586ce34f95b14d8c62de2eaafc1905705246d9.1581494371.git.newexplorerj@gmail.com> In-Reply-To: <4c586ce34f95b14d8c62de2eaafc1905705246d9.1581494371.git.newexplorerj@gmail.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of GuoMinJ > Sent: Thursday, February 13, 2020 4:34 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in= EDK2. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2515 >=20 > Change the SecurityPkg to match the ECC check rule >=20 > Signed-off-by: GuoMinJ > --- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > index 1fe1955cab..9a5f987e68 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > @@ -772,7 +772,7 @@ Tcg2GetEventLog ( > return EFI_SUCCESS; > } >=20 > -/* > +/** > Return if this is a Tcg800155PlatformIdEvent. >=20 > @param[in] NewEventHdr Pointer to a > TCG_PCR_EVENT_HDR/TCG_PCR_EVENT_EX data structure. > @@ -783,7 +783,7 @@ Tcg2GetEventLog ( > @retval TRUE This is a Tcg800155PlatformIdEvent. > @retval FALSE This is NOT a Tcg800155PlatformIdEvent. >=20 > -*/ > +**/ > BOOLEAN > Is800155Event ( > IN VOID *NewEventHdr, > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > index 7e94a8e1ed..4852d86906 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > @@ -460,7 +460,7 @@ MeasureCRTMVersion ( > ); > } >=20 > -/* > +/** > Get the FvName from the FV header. >=20 > Causion: The FV is untrusted input. > @@ -470,7 +470,7 @@ MeasureCRTMVersion ( >=20 > @return FvName pointer > @retval NULL FvName is NOT found > -*/ > +**/ > VOID * > GetFvName ( > IN EFI_PHYSICAL_ADDRESS FvBase, > -- > 2.17.1 >=20 >=20 >=20