Re: [edk2-devel] [PATCH v2 0/3] Ovmf: enable TPM 1.2

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hi Lureau
I don’t think we should expose the TPM Interface type via TpmCommandLib.

That is the TPM device implementation. The TPM device might use TIS/FIFO/CRB, but there might be also other type such as I2C, or fTPM implementation type.

To distinguish TPM2.0 or TPM1.2, the standard way is to send startup command.

Thank you
Yao Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> marcandre.lureau@redhat.com
> Sent: Thursday, February 13, 2020 9:12 PM
> To: edk2-devel@lists.01.org; devel@edk2.groups.io
> Cc: stefanb@linux.ibm.com; lersek@redhat.com; simon.hardy@itdev.co.uk;
> Marc-André Lureau <marcandre.lureau@redhat.com>
> Subject: [edk2-devel] [PATCH v2 0/3] Ovmf: enable TPM 1.2
> 
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> The following patches add basic TPM 1.2 support for Ovmf/QEMU.
> 
> I tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0
> passthrough, and emulated CRB/TPM 2.0.
> (fwiw, I haven't tried to enable TPM_CONFIG_ENABLE)
> 
> Marc-André Lureau (3):
>   Ovmf: rename TPM2 config prefix to TPM
>   SecurityPkg: export Tpm12GetPtpInterfaceType()
>   Ovmf: enable TPM 1.2 support
> 
>  OvmfPkg/OvmfPkgIa32.dsc                       | 39 +++++++++++++------
>  OvmfPkg/OvmfPkgIa32.fdf                       | 10 +++--
>  OvmfPkg/OvmfPkgIa32X64.dsc                    | 39 +++++++++++++------
>  OvmfPkg/OvmfPkgIa32X64.fdf                    | 10 +++--
>  OvmfPkg/OvmfPkgX64.dsc                        | 39 +++++++++++++------
>  OvmfPkg/OvmfPkgX64.fdf                        | 10 +++--
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf      |  3 ++
>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c       | 17 +++++++-
>  SecurityPkg/Include/Library/Tpm12DeviceLib.h  | 13 +++++++
>  .../Library/Tpm12DeviceLibDTpm/Tpm12Tis.c     | 17 ++++----
>  10 files changed, 141 insertions(+), 56 deletions(-)
> 
> --
> 2.25.0.rc2.1.g09a9a1a997
> 
> 
>