From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ni, Ray" <ray.ni@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
Date: Wed, 18 Mar 2020 08:25:03 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F9890CB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C49EFDA@SHSMSX104.ccr.corp.intel.com>
Reviewed-by: Jiewen Yao@intel.com
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Wednesday, March 18, 2020 4:10 PM
> To: Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH]
> IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
>
> > -----Original Message-----
> > From: Jiang, Guomin <guomin.jiang@intel.com>
> > Sent: Wednesday, March 18, 2020 4:08 PM
> > To: devel@edk2.groups.io
> > Cc: Jiang, Guomin <guomin.jiang@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>
> > Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe:
> Replace ASSERT_EFI_ERROR
> >
> > From: Guomin Jiang <guomin.jiang@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589
> >
> > According to code logic, it just judge the condition rather than the
> > status, it should use the ASSERT rather than ASSERT_EFI_ERROR.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> > ---
> > .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> >
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> > index 29b6916f61..aa2bf14fa8 100644
> > ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> > +++
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> > @@ -69,7 +69,7 @@ RecordPciDeviceInList(
> > ASSERT_EFI_ERROR(Status);
> >
> >
> >
> > NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
> >
> > - ASSERT_EFI_ERROR(NewPciDevice != NULL);
> >
> > + ASSERT(NewPciDevice != NULL);
> >
> >
> >
> > NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE;
> >
> > NewPciDevice->PciSegment = PciSegment;
> >
> > --
> > 2.25.1.windows.1
>
>
>
prev parent reply other threads:[~2020-03-18 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 8:08 [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Jiang, Guomin
2020-03-18 8:09 ` Ni, Ray
2020-03-18 8:25 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F9890CB@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox