* [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
@ 2020-03-18 8:08 Jiang, Guomin
2020-03-18 8:09 ` Ni, Ray
0 siblings, 1 reply; 3+ messages in thread
From: Jiang, Guomin @ 2020-03-18 8:08 UTC (permalink / raw)
To: devel; +Cc: Guomin Jiang, Ray Ni, Rangasai V Chaganty
From: Guomin Jiang <guomin.jiang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589
According to code logic, it just judge the condition rather than the
status, it should use the ASSERT rather than ASSERT_EFI_ERROR.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
---
.../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
index 29b6916f61..aa2bf14fa8 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
@@ -69,7 +69,7 @@ RecordPciDeviceInList(
ASSERT_EFI_ERROR(Status);
NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
- ASSERT_EFI_ERROR(NewPciDevice != NULL);
+ ASSERT(NewPciDevice != NULL);
NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE;
NewPciDevice->PciSegment = PciSegment;
--
2.25.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
2020-03-18 8:08 [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Jiang, Guomin
@ 2020-03-18 8:09 ` Ni, Ray
2020-03-18 8:25 ` [edk2-devel] " Yao, Jiewen
0 siblings, 1 reply; 3+ messages in thread
From: Ni, Ray @ 2020-03-18 8:09 UTC (permalink / raw)
To: Jiang, Guomin, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang@intel.com>
> Sent: Wednesday, March 18, 2020 4:08 PM
> To: devel@edk2.groups.io
> Cc: Jiang, Guomin <guomin.jiang@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
>
> From: Guomin Jiang <guomin.jiang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589
>
> According to code logic, it just judge the condition rather than the
> status, it should use the ASSERT rather than ASSERT_EFI_ERROR.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
> .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> index 29b6916f61..aa2bf14fa8 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> @@ -69,7 +69,7 @@ RecordPciDeviceInList(
> ASSERT_EFI_ERROR(Status);
>
>
>
> NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
>
> - ASSERT_EFI_ERROR(NewPciDevice != NULL);
>
> + ASSERT(NewPciDevice != NULL);
>
>
>
> NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE;
>
> NewPciDevice->PciSegment = PciSegment;
>
> --
> 2.25.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
2020-03-18 8:09 ` Ni, Ray
@ 2020-03-18 8:25 ` Yao, Jiewen
0 siblings, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2020-03-18 8:25 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, Jiang, Guomin; +Cc: Chaganty, Rangasai V
Reviewed-by: Jiewen Yao@intel.com
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Wednesday, March 18, 2020 4:10 PM
> To: Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH]
> IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
>
> > -----Original Message-----
> > From: Jiang, Guomin <guomin.jiang@intel.com>
> > Sent: Wednesday, March 18, 2020 4:08 PM
> > To: devel@edk2.groups.io
> > Cc: Jiang, Guomin <guomin.jiang@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>
> > Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe:
> Replace ASSERT_EFI_ERROR
> >
> > From: Guomin Jiang <guomin.jiang@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589
> >
> > According to code logic, it just judge the condition rather than the
> > status, it should use the ASSERT rather than ASSERT_EFI_ERROR.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> > ---
> > .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> >
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> > index 29b6916f61..aa2bf14fa8 100644
> > ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> > +++
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I
> ntelPciDeviceSecurityDxe.c
> > @@ -69,7 +69,7 @@ RecordPciDeviceInList(
> > ASSERT_EFI_ERROR(Status);
> >
> >
> >
> > NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
> >
> > - ASSERT_EFI_ERROR(NewPciDevice != NULL);
> >
> > + ASSERT(NewPciDevice != NULL);
> >
> >
> >
> > NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE;
> >
> > NewPciDevice->PciSegment = PciSegment;
> >
> > --
> > 2.25.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-18 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 8:08 [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Jiang, Guomin
2020-03-18 8:09 ` Ni, Ray
2020-03-18 8:25 ` [edk2-devel] " Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox