From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.10481.1584519908297011317 for ; Wed, 18 Mar 2020 01:25:08 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) IronPort-SDR: YFCTSk6rWH5U3tDzV2dhAZprw2ngTfPvqsIFefvouHSX2/p+A4B3VLNvhHgKKlKqdirkbqWx6A ETvkWkV8tRjQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 01:25:08 -0700 IronPort-SDR: nRLKlWbrnsR5yKKfDwed0psXzhwateQwmWwUy+03iFxwHlY5wi+IrkBABGFLoQ3otLWRB7CH8a yJFerjf+cbCg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="238538391" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 18 Mar 2020 01:25:07 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 01:25:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 01:25:07 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.50]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0439.000; Wed, 18 Mar 2020 16:25:04 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Ni, Ray" , "Jiang, Guomin" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Topic: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Index: AQHV/PxqW6BfNGc9KkuZ0u0ACS/KYKhN/xiAgAAES+A= Date: Wed, 18 Mar 2020 08:25:03 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F9890CB@shsmsx102.ccr.corp.intel.com> References: <20200318080824.1160-1-guomin.jiang@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C49EFDA@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C49EFDA@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao@intel.com > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, March 18, 2020 4:10 PM > To: Jiang, Guomin ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: Re: [edk2-devel] [edk2-platform][PATCH] > IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Jiang, Guomin > > Sent: Wednesday, March 18, 2020 4:08 PM > > To: devel@edk2.groups.io > > Cc: Jiang, Guomin ; Ni, Ray = ; > Chaganty, Rangasai V > > > > Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurity= Dxe: > Replace ASSERT_EFI_ERROR > > > > From: Guomin Jiang > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 > > > > According to code logic, it just judge the condition rather than the > > status, it should use the ASSERT rather than ASSERT_EFI_ERROR. > > > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Signed-off-by: Guomin Jiang > > --- > > .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 += - > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecur= ityDxe/I > ntelPciDeviceSecurityDxe.c > > > b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecur= ityDxe/I > ntelPciDeviceSecurityDxe.c > > index 29b6916f61..aa2bf14fa8 100644 > > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecur= ityDxe/I > ntelPciDeviceSecurityDxe.c > > +++ > b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecur= ityDxe/I > ntelPciDeviceSecurityDxe.c > > @@ -69,7 +69,7 @@ RecordPciDeviceInList( > > ASSERT_EFI_ERROR(Status); > > > > > > > > NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); > > > > - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); > > > > + ASSERT(NewPciDevice !=3D NULL); > > > > > > > > NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; > > > > NewPciDevice->PciSegment =3D PciSegment; > > > > -- > > 2.25.1.windows.1 >=20 >=20 >=20