Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

["Yao, Jiewen" <jiewen.yao@intel.com>]

Some more comment:

3) Do you consider to enable RNG instruction as well?

4) I saw you added some code for AVX instruction, such as YMM register.
Have you validated that code, to make sure it can work correctly in current environment?




> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Thursday, March 26, 2020 9:15 AM
> To: devel@edk2.groups.io; Zurcher, Christopher J
> <christopher.j.zurcher@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>;
> Eugene Cohen <eugene@hp.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native
> instruction support for IA32 and X64
> 
> HI Christopher
> Thanks for the contribution. I think it is good enhancement.
> 
> Do you have any data show what performance improvement we can get?
> Did the system boot faster with the this? Which feature ?
> UEFI Secure Boot? TCG Measured Boot? HTTPS boot?
> 
> 
> Comment for the code:
> 1) I am not sure if we need separate OpensslLibIa32 and OpensslLibX64.
> Can we just define single INF, such as OpensslLibHw.inf ?
> 
> 2) Do we also need add a new version for OpensslLibCrypto.inf ?
> 
> 
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zurcher,
> > Christopher J
> > Sent: Tuesday, March 17, 2020 6:27 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>;
> > Eugene Cohen <eugene@hp.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Subject: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native
> instruction
> > support for IA32 and X64
> >
> 
> 
>