From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.4741.1585277458022085320 for ; Thu, 26 Mar 2020 19:50:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) IronPort-SDR: XR2NM31IDvKOJqu36rAnHiOZ8QHtERMfmTrSa13paXpisY735b/Lx+xRAUHt4MaA6SFrBCvBMZ j9T37NQipohw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 19:50:57 -0700 IronPort-SDR: rV3+Vxy3jhe7l2bGJcz4GlCtYqjjWoEZQj9KZO1qASygQSGPo5bCpfXh8CtryeLwOQCV5Zb9gE a9OTyqMNNXGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,310,1580803200"; d="scan'208";a="247755563" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 26 Mar 2020 19:50:57 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Mar 2020 19:50:56 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Mar 2020 19:50:56 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.50]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Fri, 27 Mar 2020 10:50:54 +0800 From: "Yao, Jiewen" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , Maciej Rabeda , "Wu, Jiaxin" , "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function Thread-Topic: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function Thread-Index: AQHWA9r3vfbc0WLdPUSI70pQ90E/bahbrwWw//+GRwCAAIfP0A== Date: Fri, 27 Mar 2020 02:50:54 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F9A03F7@shsmsx102.ccr.corp.intel.com> References: <20200327015629.2588-1-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F9A006D@shsmsx102.ccr.corp.intel.com> <2e5b18079d6549f9bb814eb3f713ffed@intel.com> In-Reply-To: <2e5b18079d6549f9bb814eb3f713ffed@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The SHA1 is called explicitly in SecurityPkg. Are you sure we don't need up= date security pkg? > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, March 27, 2020 10:44 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan > Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate fu= nction >=20 > Jiewen, > Thanks for the reminder. But TPM didn't have the inc file as NetWorkPkg = to set > the pcd for all platform. The change for TPM1.2 should be at platform si= de. > I would change the edk2 platform code as well once the solution is decid= ed. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Friday, March 27, 2020 10:01 AM > > To: devel@edk2.groups.io; Gao, Zhichao > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; Maciej Rabeda ; > > Wu, Jiaxin ; Fu, Siyuan > > Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate > > function > > > > Good feature. > > > > I believe TPM1.2 still uses SHA1. It should be added as well. > > > > > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Gao, > > > Zhichao > > > Sent: Friday, March 27, 2020 9:56 AM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > ; Maciej Rabeda ; > > > Wu, Jiaxin ; Fu, Siyuan > > > Subject: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate > > > function > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1682 > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > > > MD4, AR4, Tdes, Aes Ecb mode, MD5 and SHA1 is not secure any longer. > > > They are all deprecated. Edk2 would not support them any longer. > > > So remove them. > > > But uefi spec want to keep MD5 and SHA1 for backwards compatibility. > > > So add two pcds to control the MD5 and SHA1 enablement. Set the pcds > > > default value to false to indicate they are deprecated. > > > > > > NetWorkPkg's iSCSI driver would consume the MD5 function, so change > > > the md5 pcd to TURE when iSCSI is enabled. > > > > > > Cc: Jian J Wang > > > Cc: Xiaoyu Lu > > > Cc: Maciej Rabeda > > > Cc: Jiaxin Wu > > > Cc: Siyuan Fu > > > Signed-off-by: Zhichao Gao > > > > > > Zhichao Gao (8): > > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > > > CryptoPkg/dec: Add pcds to avoid building the deprecated function > > > NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI > > > Crypto/BaseCryptLib: Using pcd to control MD5 enablement > > > CryptoPkg/BaseCryptLib: Use Pcd to control the SHA1 enablement > > > > > > CryptoPkg/CryptoPkg.dec | 11 + > > > CryptoPkg/CryptoPkg.uni | 11 + > > > CryptoPkg/Driver/Crypto.c | 634 +--------------= --- > > > CryptoPkg/Include/Library/BaseCryptLib.h | 548 --------------- > > > .../Library/BaseCryptLib/BaseCryptLib.inf | 9 +- > > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 ---- > > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 -- > > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 ------ > > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 ---- > > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ---------- > > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 ----- > > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ------ > > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 ---- > > > .../Library/BaseCryptLib/Hash/CryptMd5.c | 5 +- > > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 3 + > > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 3 + > > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 3 + > > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 3 + > > > .../Library/BaseCryptLib/PeiCryptLib.inf | 13 +- > > > .../BaseCryptLib/Pk/CryptPkcs5Pbkdf2.c | 3 + > > > .../Library/BaseCryptLib/Pk/CryptRsaBasic.c | 5 + > > > .../Library/BaseCryptLib/Pk/CryptRsaExt.c | 5 + > > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 13 +- > > > .../Library/BaseCryptLib/SmmCryptLib.inf | 13 +- > > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 3 - > > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 54 +- > > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 ---- > > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 ----- > > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 ---- > > > .../BaseCryptLibNull/Hash/CryptMd5Null.c | 3 + > > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 3 + > > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 4 +- > > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 604 +--------------= -- > > > .../Library/BaseHashApiLib/BaseHashApiLib.c | 12 + > > > .../Library/BaseHashApiLib/BaseHashApiLib.inf | 1 + > > > CryptoPkg/Private/Protocol/Crypto.h | 583 +--------------= - > > > NetworkPkg/NetworkPcds.dsc.inc | 5 +- > > > 37 files changed, 145 insertions(+), 4221 deletions(-) delete mode > > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.= c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > > > > > > -- > > > 2.21.0.windows.1 > > > > > > > > >=20