From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.5954.1585285256672974516 for ; Thu, 26 Mar 2020 22:00:56 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) IronPort-SDR: n2QwN8SrJwoOK4MC/+gGIiR0K6KR5tgSNwOYH/VICFex8/7IIyl70keWgr+f22J0aBp2r9OQZc 2wZumSTAUw/w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 22:00:56 -0700 IronPort-SDR: 6fE1MuEYVyxb+Rm4LQEIHceCoZYRNdBeayQoNdcatQjN5PTlZaS3xvKf3wffMCPPecASwji54S 2D42Xq9uVw3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,311,1580803200"; d="scan'208";a="240870403" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 26 Mar 2020 22:00:56 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Mar 2020 22:00:55 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.50]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.232]) with mapi id 14.03.0439.000; Fri, 27 Mar 2020 13:00:53 +0800 From: "Yao, Jiewen" To: Ard Biesheuvel , "devel@edk2.groups.io" CC: Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Ni, Ray" , Bret Barkelew Subject: Re: [PATCH 0/4] remove generation of EFI properties table Thread-Topic: [PATCH 0/4] remove generation of EFI properties table Thread-Index: AQHWA1jJSkEfRmuqr0SIHxzC6gtC9ahb4l6w Date: Fri, 27 Mar 2020 05:00:52 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F9A0997@shsmsx102.ccr.corp.intel.com> References: <20200326102443.748-1-ard.biesheuvel@linaro.org> In-Reply-To: <20200326102443.748-1-ard.biesheuvel@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao I cannot remember if there is windows OS still using the properties table. Maybe Microsoft people can comment. If no, I agree we can remove the old code. > -----Original Message----- > From: Ard Biesheuvel > Sent: Thursday, March 26, 2020 6:25 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Leif Lindholm ; Kinney, Michael D > ; Ni, Ray ; Yao, Jiewen > ; Bret Barkelew > Subject: [PATCH 0/4] remove generation of EFI properties table >=20 > The EFI properties table is broken by design, deprecated, and seems to be > causing confusion as it is unclear to some how it differs from the memory > attributes table (which supersedes it). So let's get rid of the code that > generates it entirely, along with the GUID definitions, PCDs etc. >=20 > Due to how the two implementations are intertwined, patch #2 makes the > minimal changes required to stop producing the table (and to allow patch > #3 to remove the associated definitions from MdePkg). Patch #4 is optiona= l > and merges the code together. >=20 > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ray Ni > Cc: Jiewen Yao > Cc: Bret Barkelew >=20 > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2633 >=20 > Ard Biesheuvel (4): > OvmfPkg: remove handling of properties table > MdeModulePkg: disable properties table generation but retain the code > MdePkg: remove PropertiesTable GUID > MdeModulePkg/DxeCore: merge properties table routines into MAT > handling >=20 > MdeModulePkg/Core/Dxe/DxeMain.h | 9 - > MdeModulePkg/Core/Dxe/DxeMain.inf | 3 - > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 1 - > .../Core/Dxe/Misc/MemoryAttributesTable.c | 1226 ++++++++++++++- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 1 - > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1373 ----------------- > MdeModulePkg/MdeModulePkg.dec | 24 - > MdeModulePkg/MdeModulePkg.uni | 21 - > MdePkg/Include/Guid/PropertiesTable.h | 31 - > MdePkg/MdePkg.dec | 3 - > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/OvmfXen.dsc | 1 - > OvmfPkg/PlatformPei/Platform.c | 1 - > OvmfPkg/PlatformPei/PlatformPei.inf | 1 - > 16 files changed, 1222 insertions(+), 1476 deletions(-) > delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c > delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h >=20 > -- > 2.17.1