From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.3039.1587634281901098956 for ; Thu, 23 Apr 2020 02:31:21 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 3tr87FohjNXvPcVnd8+w1aXsI53ZYLNSRk4DeiOl+cp9gutS726QBuaGdBkk/WnzYFVFet+ez8 wDSNiLT73IDw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 02:31:21 -0700 IronPort-SDR: 1xhn2KPFZKhXep/lyvbK/xYimvbTuQAZDV4e8lMPBhfA+PJjfr5qakfdO6u4wLguhRQ88vKaow G9mJAWXBwlSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,306,1583222400"; d="scan'208";a="457442763" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 23 Apr 2020 02:31:21 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 02:31:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.138]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.22]) with mapi id 14.03.0439.000; Thu, 23 Apr 2020 17:31:15 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Fu, Siyuan" , "Kinney, Michael D" , Laszlo Ersek , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions Thread-Topic: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWGUu5p41i+WCZ90uhoKy+Bp1mUaiGcQfw Date: Thu, 23 Apr 2020 09:31:14 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F9FCB22@shsmsx102.ccr.corp.intel.com> References: <20200423084627.3384-1-zhichao.gao@intel.com> In-Reply-To: <20200423084627.3384-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello I think there are lots of feedback in v1 patch review. Would you please give a summary on how they are addressed in this v2 ? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Thursday, April 23, 2020 4:46 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Fu, Siyuan ; Kinney, Michael D > ; Yao, Jiewen ; Laszlo > Ersek > Subject: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated > functions >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 >=20 > Retire below deprecated functions: > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 >=20 > Update the Crypto Driver's version to indicate the binary change. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Siyuan Fu > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: Laszlo Ersek > Signed-off-by: Zhichao Gao >=20 > Zhichao Gao (7): > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > CryptoPkg/Crypto.h: Update the version of Crypto Driver >=20 > CryptoPkg/CryptoPkg.dsc | 46 +- > CryptoPkg/Driver/Crypto.c | 62 +-- > CryptoPkg/Include/Library/BaseCryptLib.h | 481 ------------------ > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 ----- > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 -- > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 -------- > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 ----- > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------------- > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 ------ > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 -------- > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 ------ > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 -------- > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 ----- > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 -------- > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 ----- > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 -- > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 ----- > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 ------ > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 ------ > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 ----- > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 ----- > .../Library/Include/openssl/opensslconf.h | 9 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > 31 files changed, 75 insertions(+), 3486 deletions(-) > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.= c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.= c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > delete mode 100644 CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null= .c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20