From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.6370.1587822525103291732 for ; Sat, 25 Apr 2020 06:48:45 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) IronPort-SDR: GYUsPk4o/6sadHwmklSUErhBT+aerS7gc2j4+SzofMcn4zWCoDk4/mXpLadPY5NOPejqeNRNcX DusVfyiuYpEg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2020 06:48:43 -0700 IronPort-SDR: GV6fvYJZt8OhAmsd1mzpow7MSn17BNaWogh6/2yCbhdaylcnp0g/RhY7SNSXMlxxp+y9hj1WAS 0KtgyPlrhC9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,316,1583222400"; d="scan'208";a="274937929" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 25 Apr 2020 06:48:25 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 06:48:24 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 06:48:24 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.138]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.22]) with mapi id 14.03.0439.000; Sat, 25 Apr 2020 21:48:21 +0800 From: "Yao, Jiewen" To: "Fu, Siyuan" , "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Kinney, Michael D" , Laszlo Ersek Subject: Re: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Topic: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Index: AQHWGUvNkkWO5ZUtwUWHSCjH4WJuQ6iJE6OAgADKDIA= Date: Sat, 25 Apr 2020 13:48:20 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503FA0B443@shsmsx102.ccr.corp.intel.com> References: <20200423084627.3384-1-zhichao.gao@intel.com> <20200423084627.3384-8-zhichao.gao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Why not remove the deprecated functions ? Thank you Yao Jiewen > -----Original Message----- > From: Fu, Siyuan > Sent: Saturday, April 25, 2020 5:45 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Kinney, Michael D ; Yao, Jiewen > ; Laszlo Ersek > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Cry= pto > Driver >=20 > Hi, Zhichao >=20 > This patch set doesn't add or remove any field in EDK II Crypto Protocol,= but just > change some API implementation to return false or unsupport, right? If so= I > don't think the Crypto Version need to be increased. >=20 > Best Regards > Siyuan >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B23=1B$BF|=1B(B 16:46 > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; Fu, Siyuan ; Kinney, Micha= el > > D ; Yao, Jiewen ; > > Laszlo Ersek > > Subject: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypt= o > > Driver > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > Update the Crypto Version to 7: > > 1. Retire below deprecated functions: > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Siyuan Fu > > Cc: Michael D Kinney > > Cc: Jiewen Yao > > Cc: Laszlo Ersek > > Signed-off-by: Zhichao Gao > > --- > > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/CryptoPkg/Private/Protocol/Crypto.h > > b/CryptoPkg/Private/Protocol/Crypto.h > > index 40c387e002..667ca1ef07 100644 > > --- a/CryptoPkg/Private/Protocol/Crypto.h > > +++ b/CryptoPkg/Private/Protocol/Crypto.h > > @@ -20,7 +20,7 @@ > > /// the EDK II Crypto Protocol is extended, this version define must b= e > > /// increased. > > /// > > -#define EDKII_CRYPTO_VERSION 6 > > +#define EDKII_CRYPTO_VERSION 7 > > > > /// > > /// EDK II Crypto Protocol forward declaration > > -- > > 2.21.0.windows.1