From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.7231.1587883689717843338 for ; Sat, 25 Apr 2020 23:48:09 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) IronPort-SDR: cjW6rYfyfFiJ9yUde4dMZLk+m4DRdPitYtU8sqPdY1h9Of/psL+W+8VHl4BDM46p26MZUmpe/I /SEbv7Qdp7Fw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2020 23:48:08 -0700 IronPort-SDR: Z+g7P1ZJNjhkQdfE5wtBJPKPEtS5uwPEDvrVYpRtXalc14BC3RcSaVc/YPdi4Z7JLZCa+xxxJt CB45N09x5Nbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,319,1583222400"; d="scan'208";a="302030635" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 25 Apr 2020 23:48:08 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 23:48:07 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 23:48:07 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.138]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.225]) with mapi id 14.03.0439.000; Sun, 26 Apr 2020 14:48:04 +0800 From: "Yao, Jiewen" To: "Gao, Zhichao" , "Fu, Siyuan" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Kinney, Michael D" , Laszlo Ersek Subject: Re: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Topic: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Index: AQHWGUvNkkWO5ZUtwUWHSCjH4WJuQ6iJE6OAgADKDICAAJWTgIAAhx1g Date: Sun, 26 Apr 2020 06:48:04 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503FA0CEFC@shsmsx102.ccr.corp.intel.com> References: <20200423084627.3384-1-zhichao.gao@intel.com> <20200423084627.3384-8-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503FA0B443@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable You can change the protocol GUID and remote the function from the protocol = - this is an internal protocol. It should not be called by anyone. > -----Original Message----- > From: Gao, Zhichao > Sent: Sunday, April 26, 2020 2:43 PM > To: Yao, Jiewen ; Fu, Siyuan ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Kinney, Michael D ; Laszlo Ersek > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Cry= pto > Driver >=20 > Jiewen, >=20 > Do you mean remove the definition of the deprecated function and keep the > NULL value in the protocol structure? > I am not sure if that is a good idea. Because that would give the protoco= l a > chance to call a NULL pointer. >=20 > Siyuan, >=20 > The binary would be totally different. Does that make sence? >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Saturday, April 25, 2020 9:48 PM > > To: Fu, Siyuan ; Gao, Zhichao ; > > devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > ; > > Kinney, Michael D ; Laszlo Ersek > > > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of C= rypto > > Driver > > > > Why not remove the deprecated functions ? > > > > Thank you > > Yao Jiewen > > > > > -----Original Message----- > > > From: Fu, Siyuan > > > Sent: Saturday, April 25, 2020 5:45 PM > > > To: Gao, Zhichao ; devel@edk2.groups.io > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > ; Kinney, Michael D > > > ; Yao, Jiewen ; > > > Laszlo Ersek > > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > > Crypto Driver > > > > > > Hi, Zhichao > > > > > > This patch set doesn't add or remove any field in EDK II Crypto > > > Protocol, but just change some API implementation to return false or > > > unsupport, right? If so I don't think the Crypto Version need to be i= ncreased. > > > > > > Best Regards > > > Siyuan > > > > > > > -----Original Message----- > > > > From: Gao, Zhichao > > > > Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B23=1B$BF|=1B(B 16:46 > > > > To: devel@edk2.groups.io > > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > > ; Fu, Siyuan ; Kinney, > > > > Michael D ; Yao, Jiewen > > > > ; Laszlo Ersek > > > > Subject: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > > > Crypto Driver > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > > > > > Update the Crypto Version to 7: > > > > 1. Retire below deprecated functions: > > > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > > > > > > > Cc: Jian J Wang > > > > Cc: Xiaoyu Lu > > > > Cc: Siyuan Fu > > > > Cc: Michael D Kinney > > > > Cc: Jiewen Yao > > > > Cc: Laszlo Ersek > > > > Signed-off-by: Zhichao Gao > > > > --- > > > > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/CryptoPkg/Private/Protocol/Crypto.h > > > > b/CryptoPkg/Private/Protocol/Crypto.h > > > > index 40c387e002..667ca1ef07 100644 > > > > --- a/CryptoPkg/Private/Protocol/Crypto.h > > > > +++ b/CryptoPkg/Private/Protocol/Crypto.h > > > > @@ -20,7 +20,7 @@ > > > > /// the EDK II Crypto Protocol is extended, this version define > > > > must be /// increased. > > > > /// > > > > -#define EDKII_CRYPTO_VERSION 6 > > > > +#define EDKII_CRYPTO_VERSION 7 > > > > > > > > /// > > > > /// EDK II Crypto Protocol forward declaration > > > > -- > > > > 2.21.0.windows.1 > > >=20