From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D57F5AC10A4 for ; Tue, 31 Oct 2023 15:22:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tzZYo+jwJe3cy/FTv9kzZK1ukwXOcDe0bPjIOz4H/i8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698765745; v=1; b=I5eTYtHSUmfJjGbXSdNCAVhxzwpHIfIOmiF0AG7PnERFGQpCPCPUaBXX7y+90jTX6UajcXFC xWySvVWKlRjT80A9NKYM7JnTMrVYovcunBxQApsrIhzBLDX8aHB6cEUFhV8q2Ly8qefZq86bnpz gD4wyLfCIpKyOfg3/z1xqf/A= X-Received: by 127.0.0.2 with SMTP id 6ELIYY7687511xr9mqfJdNkK; Tue, 31 Oct 2023 08:22:25 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.1534.1698765744909354408 for ; Tue, 31 Oct 2023 08:22:25 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-BWPmYGtJPVKNGemnRAx91g-1; Tue, 31 Oct 2023 11:22:20 -0400 X-MC-Unique: BWPmYGtJPVKNGemnRAx91g-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F278824022; Tue, 31 Oct 2023 15:22:20 +0000 (UTC) X-Received: from [10.39.195.34] (unknown [10.39.195.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95DA640C6EBB; Tue, 31 Oct 2023 15:22:19 +0000 (UTC) Message-ID: <74a4b602-0336-af2a-69d6-b1869e1c53f6@redhat.com> Date: Tue, 31 Oct 2023 16:22:18 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check From: "Laszlo Ersek" To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Sean Brogan , Michael D Kinney References: <20231031014120.917-1-mikuback@linux.microsoft.com> <1bba4f0f-823e-d6ce-7139-34a79012d733@redhat.com> In-Reply-To: <1bba4f0f-823e-d6ce-7139-34a79012d733@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WLoExMNrsiKgGICWlf0cqvqXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I5eTYtHS; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/31/23 14:44, Laszlo Ersek wrote: > On 10/31/23 02:41, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Adds a GitHub workflow that uses the actions/stale GitHub action to >> automatically leave notifications on and close PRs that have had no >> activity for a long time. >> >> Note: Modifications to a PR reset the staleness counter. This >> includes pushing to the PR, adding a label to the PR, >> commenting on the PR, etc. >> >> If a PR has been marked "stale", simply leaving a comment will >> reset the counter. >> >> Configuration choices: >> >> 1. Do not attempt to close edk2 GitHub issues. >> 2. Mark edk2 PRs as stale if no activity in the last 60 days. Close >> PRs marked stale if no further activity in 7 days. >> 3. Do not exempt PRs with a "push" label. >> 4. Run the check once daily. Allow manual runs from those that have >> permission to run GitHub workflows. >> 5. Add the label "stale" to the PR when it enters the stale state. >> >> Rationale: >> >> 1. We do not use issues often enough. The limited usage of GitHub >> issues in Tianocore org GitHub projects are in another repo not >> impacted by this workflow and expected to track long term tasks. >> 2. This is the default value. In non-edk2 projects, I've seen these >> times work fairly well to identify PRs that have fallen stale. >> 3. Adding a "push" label resets the stale timer. If a PR has had a >> "push" label for 60+ days and has not been fixed for submission, >> then it is has very likely been abandoned. >> 4. This is sufficient to update PRs on the day granularity the >> configuration settings are applied against. >> 5. The label makes it easy to filter stale PRs in the PR list and >> write automation around PRs that are stale. It's also an obvious >> visual identifier that a PR needs attention in the PR list. >> >> Cc: Sean Brogan >> Cc: Michael Kubacki >> Cc: Michael D Kinney >> Cc: Laszlo Ersek >> Signed-off-by: Michael Kubacki >> --- >> >> Notes: >> I tested this workflow on my edk2 fork: >> =20 >> https://github.com/makubacki/edk2/actions/runs/6700887619 >> =20 >> Here's an example of a PR it did not mark stale there: >> =20 >> https://github.com/makubacki/edk2/pull/136 >> =20 >> Here's an example of a PR it did mark stale there: >> =20 >> https://github.com/makubacki/edk2/pull/4 >> >> .github/workflows/stale.yml | 44 ++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml >> new file mode 100644 >> index 000000000000..b9160b548ab3 >> --- /dev/null >> +++ b/.github/workflows/stale.yml >> @@ -0,0 +1,44 @@ >> +# This workflow warns and then closes issues and PRs that have had no a= ctivity >> +# for a specified amount of time. >> +# >> +# For more information, see: >> +# https://github.com/actions/stale >> +# >> +# Copyright (c) Microsoft Corporation. >> +# SPDX-License-Identifier: BSD-2-Clause-Patent >> +# >> + >> +name: Stale Check >> + >> +on: >> + schedule: >> + # At 23:35 on every day-of-week from Sunday through Saturday >> + # https://crontab.guru/#35_23_*_*_0-6 >> + - cron: '35 23 * * 0-6' >> + workflow_dispatch: >> + >> +jobs: >> + stale: >> + name: Stale >> + runs-on: ubuntu-latest >> + permissions: >> + issues: write >> + pull-requests: write >> + >> + steps: >> + - name: Check for Stale Items >> + uses: actions/stale@v8 >> + with: >> + days-before-issue-close: -1 >> + days-before-issue-stale: -1 >> + days-before-pr-stale: 60 >> + days-before-pr-close: 7 >> + stale-pr-message: > >> + This PR has been automatically marked as stale because it has= not had >> + activity in 60 days. It will be closed if no further activity= occurs within >> + 7 days. Thank you for your contributions. >> + close-pr-message: > >> + This pull request has been automatically been closed because = it did not have any >> + activity in 60 days and no follow up within 7 days after bein= g marked stale. >> + Thank you for your contributions. >> + stale-pr-label: stale >=20 > Queued via . Merged as commit 36812d6c3e0c4402ea90e20566ac80de634d210b. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110422): https://edk2.groups.io/g/devel/message/110422 Mute This Topic: https://groups.io/mt/102289677/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-