From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C1A277805F4 for ; Tue, 12 Mar 2024 16:38:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WQDGfQURe1G9oBVMFrnbQHprSw7SxMbioleFkWp8kpQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710261502; v=1; b=vy69IDQpwLRo76/2eUPQ+ZfalPl+j7XwCAf2GSdV2I+oFErSY87j5TELJGeKo8et8o8bORFw 6p7H5r7pQQMIuiQwZwSvJ8XHDmtkltqeCjpuoerJqovU+33qtRt193tdyVWQF1yy2ohkjNlY2ls Z/qyWeW6eRplvm0dRtin3xLaC2LlaP+7tgd2AjG0SPpqe5zrpNbv3EBXMTk5d6SQgiA7N3muXaf OzZrZU6SnUc5Pl1SVNb8bahyoVGC0jCjMfsi22JByDkpUaOdGEZ7O/JmwTH8IkBVwyfFiH+6fmz tzLB9YYR0SuAHjUkRAzwGJpZdx+pCnFQnIZC22ScT72XA== X-Received: by 127.0.0.2 with SMTP id c97UYY7687511xm4wBVleJxk; Tue, 12 Mar 2024 09:38:22 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.1197.1710261501442948461 for ; Tue, 12 Mar 2024 09:38:21 -0700 X-Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42CCGHFt010570; Tue, 12 Mar 2024 16:38:16 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wtjwus5hb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 16:38:16 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42CGcFGf019554 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 16:38:15 GMT X-Received: from [10.110.22.181] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 12 Mar 2024 09:38:14 -0700 Message-ID: <74a4fb99-5d29-44ac-93bd-caea7367d08e@quicinc.com> Date: Tue, 12 Mar 2024 09:38:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed To: Ard Biesheuvel , CC: , , Ard Biesheuvel References: <20240312151716.2154180-1-ardb+git@google.com> From: "Leif Lindholm" In-Reply-To: <20240312151716.2154180-1-ardb+git@google.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: Ic7RhtE9xU2pjIKjVbmYT8iHHKHq3kz_ X-Proofpoint-ORIG-GUID: Ic7RhtE9xU2pjIKjVbmYT8iHHKHq3kz_ Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 09:38:21 -0700 Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1nDH3YQAbiQ5betXuh7738SYx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vy69IDQp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-03-12 08:17, Ard Biesheuvel wrote: > From: Ard Biesheuvel >=20 > NonCoherentIoMmuSetAttribute() does nothing except return > EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI > bus driver will fail a PCI I/O Map() operation if the SetAttributes > fails. >=20 > So return EFI_SUCCESS instead. It's unclear to me why this change is safe (looking forward). Does NonCoherentIoMmuDxe also imply no IoMmu actually exists? / Leif > Signed-off-by: Ard Biesheuvel > --- > This fixes a regression on Raspberry Pi4, which no longer boots. >=20 > EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.= c b/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c > index 4e7a5698c162..f02a76a62ea8 100644 > --- a/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c > +++ b/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c > @@ -70,7 +70,7 @@ NonCoherentIoMmuSetAttribute ( > IN UINT64 IoMmuAccess > ) > { > - return EFI_UNSUPPORTED; > + return EFI_SUCCESS; > } > =20 > /** -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116691): https://edk2.groups.io/g/devel/message/116691 Mute This Topic: https://groups.io/mt/104886877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-