From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=zzLtyVYv; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.66, mailfrom: pete@akeo.ie) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Fri, 19 Jul 2019 08:40:52 -0700 Received: by mail-wm1-f66.google.com with SMTP id v19so29470138wmj.5 for ; Fri, 19 Jul 2019 08:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k79ilPltccCNSAML/4kxqbqNdD1KBr733KfSZpLGr2w=; b=zzLtyVYv8JnepAAlfPzGX4DHz9IDkQuCrVmigdNoSoZJYkFVAOfQfpeIatHHuHCr7I 17TbBNIKL7niH0FgEpfSvyi3vZsIDsAewAPfqVEaezO1UH0DAjPgc07+9VltYa44O8+B mkKGkgqJzy1kaZRdcv1xqPpSZbUtU3fI7ihR7LGO1f9ZnCl2NLk2TSlCeeT9Kkp66s0q q/PW+pxvgRxP94YnI5o4m35DjRSvgcOnIelXYdi12aPQ7swRL3sMY99XDE+/OME4zj2k OwEeYBJNxN0DI6EEM2NR6HOkG1pVyZDAxfAWRdqeh6t/Ua2LVFufvUBijo5FhsQwwIgc lvww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k79ilPltccCNSAML/4kxqbqNdD1KBr733KfSZpLGr2w=; b=BNB/aDrUg6F2eMXRuR69sHtB3Gg0fHognORAlRp21EJMY2Zm+M8jrfFMsqIupHSSlX NGuJBsXw2x3dgxf3fAlkd4UVDWXixnamoN9/WgzmEC+3a2GB3FGnZRulMcP3M6qHYYc1 oyMzx41a2nCMNbxIVtRAoxxrJUNDIVwg8PUel6yBbCCbcTknJBc4je5MTFMjjt2J0Me7 yJ/MIPLf8OuzLMt9j1Dgz8sQvfP+/yfJCdOlIM9kM5I4f0fza7qRmkHoyjfpsa9shWY0 4/M+R4DwlYJd+bjukpdgAG+0BG7oAlFnU2t9LWZFW9drXenOlNl+wzQZr+4LOhjX3tNw XOCA== X-Gm-Message-State: APjAAAVtdIAP1tK3/64xqqsdUC1NnpzdUngKHsK/GsQkYVbV41yubrI4 cbHzmjE7KiITteB70H/NdsA= X-Google-Smtp-Source: APXvYqztzX9tY5FgQVlqFLQ6+s3YJwmi7ounN+MK5AkD9qaTFNOggf0tTuCnGAjQaAAw1QpIX8Jusg== X-Received: by 2002:a05:600c:23cd:: with SMTP id p13mr44947070wmb.86.1563550850894; Fri, 19 Jul 2019 08:40:50 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.61.230]) by smtp.googlemail.com with ESMTPSA id v124sm31283031wmf.23.2019.07.19.08.40.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 08:40:50 -0700 (PDT) Subject: Re: [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe To: Leif Lindholm Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org References: <20190717114645.7776-1-pete@akeo.ie> <20190719115323.GU2712@bivouac.eciton.net> From: "Pete Batard" Message-ID: <74b1a6fa-d0d0-93e0-4d70-1604d665fc6d@akeo.ie> Date: Fri, 19 Jul 2019 16:40:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190719115323.GU2712@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Leif, On 2019.07.19 12:53, Leif Lindholm wrote: > Hi Pete, > > On Wed, Jul 17, 2019 at 12:46:42PM +0100, Pete Batard wrote: >> Networking applications (e.g. iPXE) might experience failures when submitting >> a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out >> when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal >> error. >> >> With these patches, iPXE is able to successfully download a 128MB test file >> via HTTP. > > The patches look good, and I don't mind you upstreaming Michael's > code, *but* I don't want patches submitted with anyone other than the > contributor's Signed-off-by:. (It's the equivalent of saying "Yeah, > Michael says he's OK with https://developercertificate.org/, and of no > actual use.) I see. It does make sense, now that you explain it. > (If patches are modified after contribution, but before being pushed, > then then additional contributions can be reflected with additional > Signed-off-bys. Make sense?) > > The From: tag ensures he still retains authorship. > Are you OK with me dropping Michael's Signed-off-by before pushing? That's fine with me. I reviewed these patches and can therefore vouch for them. Regards, /Pete PS: Thanks for pushing the previous series. > > Best Regards, > > Leif > >> Michael Brown (3): >> Platform/RPi3: Use Wait4Bit return value consistently >> Platform/RPi3: Gracefully disable USB channel after a timeout >> Platform/RPi3: Reduce debug noise when using a USB network device >> >> Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 44 +++++++++++--------- >> 1 file changed, 25 insertions(+), 19 deletions(-) >> >> -- >> 2.21.0.windows.1 >>