From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.67; helo=mail-wr1-f67.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0E12B21193784 for ; Wed, 28 Nov 2018 07:13:17 -0800 (PST) Received: by mail-wr1-f67.google.com with SMTP id v6so26661670wrr.12 for ; Wed, 28 Nov 2018 07:13:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y8DLU/Fh0ER834X1wZAEujtEA8pej8vJYVN9YfU9Z3o=; b=iv3TEahx6JBIGpNRo3iiLXL5E6UwkklG2WOTAjFk54pYL77IwnzqlhjRdE5ebfQPyt r3TZirmHv27QqxLuW5/Uo9UTm4mVzYZCoJj961ZPbtw+CKZIG48WviDJpZP7zLCLK1hz kgCtzdjK2II6iix8xVL4hFMPzhoia8IQqOtTyzEt19sPAFqqTRpYfvVBgSrchjSaGOUJ 9yZdsflYfG2U9JufdN/0niA292QR3GS/pJhmqmrChWKppZgPnqDM530M0SHx86WCcE8U AvqqVwxdxgxse/1nuwHFnQIJELgOcpGSPKSG9j020LMc1sv4Sn5WNnH5ph2f5zJt8SY8 gcow== X-Gm-Message-State: AA+aEWZyEWA7AiEz2YqwRFQHvhwhpcEL/8+MsirTP866e6SquU4nyNwY /G239qNiY2cM1gc6qdE4qnJspLmzFzi3hw== X-Google-Smtp-Source: AFSGD/V2xHF11vEue2ngh9gg8TR+2ZKkAn1miDDHc1CIwBg8FpDYUs+S+wzRkjaEpbFJWvYJz+Lkyw== X-Received: by 2002:adf:8421:: with SMTP id 30mr32428132wrf.153.1543417996277; Wed, 28 Nov 2018 07:13:16 -0800 (PST) Received: from ?IPv6:2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9? ([2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9]) by smtp.gmail.com with ESMTPSA id h16sm9461780wrb.62.2018.11.28.07.13.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 07:13:15 -0800 (PST) To: Liming Gao , edk2-devel@lists.01.org References: <20181128140318.19436-1-liming.gao@intel.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <74ecbe76-0ceb-51da-d00f-4bcf711191c0@redhat.com> Date: Wed, 28 Nov 2018 16:13:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181128140318.19436-1-liming.gao@intel.com> Subject: Re: [Patch v2] Maintainers.txt: Add the rule to hand over the package maintain role X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 15:13:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi, On 28/11/18 15:03, Liming Gao wrote: > In V2, change his to the, and add new maintainers follow up. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > --- > Maintainers.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 91a4657adc..e102114c34 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -6,7 +6,10 @@ EDK II. > > In general, you should not privately email the maintainer. You should > email the edk2-devel list, and Cc the package maintainers and > -reviewers. > +reviewers. If the package maintainer wants to hand over the role to I'd move this to another paragraph, the first one is directed to contributors, the second one would be to maintainers. > +other people, the package maintainer should send the patch to update > +Maintainers.txt with new maintainer, and the new maintainer should > +follow up with an Acked-by or a Reviewed-by. I noticed an extra space at the end of the lines you added, which resulted in the following errors when applying: Applying: Maintainers.txt: Add the rule to hand over the package maintain role .git/rebase-apply/patch:14: trailing whitespace. reviewers. If the package maintainer wants to hand over the role to .git/rebase-apply/patch:15: trailing whitespace. other people, the package maintainer should send the patch to update .git/rebase-apply/patch:16: trailing whitespace. Maintainers.txt with new maintainer, and the new maintainer should error: patch failed: Maintainers.txt:6 error: Maintainers.txt: patch does not apply Thanks for adding the maintainership handover clarification, I appreciate :) With space fixed (same or another paragraphs): Reviewed-by: Philippe Mathieu-Daudé > > Descriptions of section entries: > >