public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ruiyu Ni <ruiyu.ni@intel.com>, edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal
Date: Wed, 29 Nov 2017 14:53:01 +0100	[thread overview]
Message-ID: <751c492a-26bc-49a5-deb7-80ef44a94953@redhat.com> (raw)
In-Reply-To: <20171129101500.288384-3-ruiyu.ni@intel.com>

Ray,

On 11/29/17 11:14, Ruiyu Ni wrote:
> The TFTP command was converted from a NULL class library
> instance to a dynamic shell command in commit 0961002352e9.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc           | 11 +++++++----
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc |  3 ++-
>  ArmVirtPkg/ArmVirtXen.fdf            |  3 ++-
>  3 files changed, 11 insertions(+), 6 deletions(-)

Can you please incorporate points (2) and (3) as well, from my v3 review?

  https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html

(If you keep posting new versions faster than I can review them, it's
likely that I'll never catch up.)

Thanks,
Laszlo


  reply	other threads:[~2017-11-29 13:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 10:14 [PATCH v4 0/3] Fix build failure due to tftp/dp library removal Ruiyu Ni
2017-11-29 10:14 ` [PATCH v4 1/3] EmulatorPkg: Fix build failure due to Tftp " Ruiyu Ni
2017-11-29 10:14 ` [PATCH v4 2/3] ArmVirtPkg: " Ruiyu Ni
2017-11-29 13:53   ` Laszlo Ersek [this message]
2017-11-30 12:22     ` Laszlo Ersek
2017-11-30 13:16       ` Ard Biesheuvel
2017-12-01  1:48         ` Ni, Ruiyu
2017-12-01 10:12           ` Laszlo Ersek
2017-11-29 10:15 ` [PATCH v4 3/3] BeagleBoardPkg: " Ruiyu Ni
2017-11-29 11:30   ` Leif Lindholm
2017-11-30 12:22     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=751c492a-26bc-49a5-deb7-80ef44a94953@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox