From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.16314.1591952850953656345
 for <devel@edk2.groups.io>;
 Fri, 12 Jun 2020 02:07:31 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BC211FB;
	Fri, 12 Jun 2020 02:07:30 -0700 (PDT)
Received: from [192.168.1.69] (unknown [10.37.8.184])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F8883F73C;
	Fri, 12 Jun 2020 02:07:29 -0700 (PDT)
Subject: Re: [edk2-non-osi][PATCH v2 1/1] Drivers/Realtek: Add Realtek USB UNDI driver
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Leif Lindholm <leif@nuviainc.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20200612043428.26706-1-Samer.El-Haj-Mahmoud@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <751ca8b8-88f2-a0de-c294-27bac8c96c7e@arm.com>
Date: Fri, 12 Jun 2020 11:07:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200612043428.26706-1-Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/12/20 6:34 AM, Samer El-Haj-Mahmoud wrote:
> Realtek USB UNDI Driver version 2.029. This is the Aarch64 binary,
> with the equivalent IA32 and X64 binaries available at:
> https://www.realtek.com/en/directly-download?
> downloadid=86d7f2c67ffec9df507b070bcd930a78
> 
> The original signed Aarch64 binary provided by Realtek is at:
> https://github.com/samerhaj/uefi_drivers/blob/master/UsbNetworking/
> Realtek/zip/binary/RtkUsbUndiDxe.2.029.2020.04.14_signed_ARM.zip
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
>   Drivers/Realtek/Bus/Usb/UsbNetworking/Aarch64/RtkUsbUndiDxe.inf |  26 ++++++++++++++++++++
>   Drivers/Realtek/Bus/Usb/UsbNetworking/Aarch64/RtkUsbUndiDxe.efi | Bin 0 -> 89136 bytes
>   Drivers/Realtek/License.txt                                     |  25 +++++++++++++++++++
>   3 files changed, 51 insertions(+)
> 

Thanks Samer

I applied this after making some tweaks:

- bump INF version to 1.27
- rename Aarch64 to AArch64
- move INF one level up and use [Binaries.AARCH64] as the section delimiter

Pushed as dc4afd066ca5..f80239734677