From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.935.1619630123717631238 for ; Wed, 28 Apr 2021 10:15:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MFhW230n; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619630122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJqo59bJv4xQ6I7I3AawcRvfPS8AcHm5HzDwa8XqCAA=; b=MFhW230nPaqPBD5CTZ6qMAVEwmw2BKHPZKjC/NMsDhS4f2PMJ2jq8hJ5+DRxuIh/UYOXBl X5e2mbQBaz63C9dpsER+KXp8R1t7l6NNVk3vYjDNbDQif2AOjDIo9BNDUE9s3eDyC/rQAA yivWjY5kZ74XOaxZU+KoPjIyxk3sdPo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-aN80EEVOP0m-9Qo1sF9VQw-1; Wed, 28 Apr 2021 13:15:19 -0400 X-MC-Unique: aN80EEVOP0m-9Qo1sF9VQw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37978802B56; Wed, 28 Apr 2021 17:15:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-188.ams2.redhat.com [10.36.114.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81E7961093; Wed, 28 Apr 2021 17:15:09 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Define a new PPI GUID to signal TPM MMIO accessability From: "Laszlo Ersek" To: devel@edk2.groups.io, thomas.lendacky@amd.com Cc: Joerg Roedel , Borislav Petkov , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Berger References: <9624a78abe08398f03b4602cf93f9acaa440be11.1619540470.git.thomas.lendacky@amd.com> Message-ID: <75348819-8642-911b-5559-93508422ea86@redhat.com> Date: Wed, 28 Apr 2021 19:15:08 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04/28/21 19:12, Laszlo Ersek wrote: > On 04/27/21 18:21, Lendacky, Thomas wrote: >> From: Tom Lendacky >> >> Define a new PPI GUID that is to be used as a signal of when it is safe >> to access the TPM MMIO range. This is needed so that, when SEV is active, >> the MMIO range can be mapped unencrypted before it is accessed. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Brijesh Singh >> Cc: Erdem Aktas >> Cc: James Bottomley >> Cc: Jiewen Yao >> Cc: Min Xu >> Cc: Marc-Andr?? Lureau (1) Marc-André's name is garbled here, but I can fix it up. Thanks Laszlo >> Cc: Stefan Berger >> Signed-off-by: Tom Lendacky >> --- >> OvmfPkg/OvmfPkg.dec | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec >> index 9629707020ba..6ae733f6e39f 100644 >> --- a/OvmfPkg/OvmfPkg.dec >> +++ b/OvmfPkg/OvmfPkg.dec >> @@ -128,6 +128,10 @@ [Ppis] >> # has been discovered and recorded >> gOvmfTpmDiscoveredPpiGuid = {0xb9a61ad0, 0x2802, 0x41f3, {0xb5, 0x13, 0x96, 0x51, 0xce, 0x6b, 0xd5, 0x75}} >> >> + # This PPI signals that accessing the MMIO range of the TPM is possible in >> + # the PEI phase, regardless of memory encryption >> + gOvmfTpmMmioAccessiblePpiGuid = {0x35c84ff2, 0x7bfe, 0x453d, {0x84, 0x5f, 0x68, 0x3a, 0x49, 0x2c, 0xf7, 0xb7}} >> + >> [Protocols] >> gVirtioDeviceProtocolGuid = {0xfa920010, 0x6785, 0x4941, {0xb6, 0xec, 0x49, 0x8c, 0x57, 0x9f, 0x16, 0x0a}} >> gXenBusProtocolGuid = {0x3d3ca290, 0xb9a5, 0x11e3, {0xb7, 0x5d, 0xb8, 0xac, 0x6f, 0x7d, 0x65, 0xe6}} >> > > Reviewed-by: Laszlo Ersek >