From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.87]) by mx.groups.io with SMTP id smtpd.web12.6558.1632481089063730693 for ; Fri, 24 Sep 2021 03:58:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Ti/XFJ3D; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.87, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMEBOqwQMjiSwcOi7q3Vu/N+KklWqPcIIhE0AXmOEstBP4S5NN7rRT2ZL6erM4m7k7Poz5JH62nYlp31KMzUYJdQuPkEzno7vyT4dsMf/tS8/jF6BVO207Bs12r80JKdAzPlVrwPcosJfkJ86pHR7pKKLhyHteGvH1po0p2NjtgHh95S+wlayH0S706EQ6LdoXdKhw83ODjLvqeyCttR2xFGkRH+ApPtJdrug10wVEcs5ZWoAv2cr9c6LVOknmXRqiAlPWDG/XcGFPHCR+wO9M4eEI2BjfPQmEc6Dvb2Qd+RTtk35WMOpACX2XwT2SUYkzAsbtnfbtDDNFsMr+YG9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V2QsBXI1N288v/e0g6EpfsUemmHiRoC3TqVPjpNTuDA=; b=P6e1a9uKbdV/oN1gpVXqh62qtUIBmi6pWMvx6hiIrh5Lq749CY7I4NjZB7797AH84H1XkWhvsIrH5yoGQP7IlI/6hVZfMX7FED0TAkWtRa1YgGoKbkPmBsfNb3DhtLv9ugIfhOlMdioHHr0Ii/i0OkWBLIRxVxsKava3v+O6i0IeZpOpuJQRp761JfOwxK6VyJUbeJRvMLTIEIkfCnVFd91+CcpBUx7T0rEpvo/Uuq9CNwu2UrH+Zll1gUAuvOm3okv5ECxqaRmReiKFCaWrH639KhjQZ90mm1rgyvprh6oQYYDs4YVuZOdXNgXwc8fdsckpvxGwQ8x6PAc7v+lZCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2QsBXI1N288v/e0g6EpfsUemmHiRoC3TqVPjpNTuDA=; b=Ti/XFJ3DRu7M0VFBSFviWy7xsPrUmH96cr6w4OWo9KzTQrODsMV7CvVmBkU1hUwfCoUwu+uK2cTuYoKUQxv7cS/eErsGXWnkjg+sxFvylRSAXgpiZqDO7M/7ebPTUtcTlGqcB8V7DbVSX8aSvGyVroz/gPlJiosVUuwGR9JDQc4= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2768.namprd12.prod.outlook.com (2603:10b6:805:72::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Fri, 24 Sep 2021 10:58:05 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4523.022; Fri, 24 Sep 2021 10:58:05 +0000 Subject: Re: [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector To: Min Xu , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , Gerd Hoffmann , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky References: <12721dade1f2f9905cc34271d9abec24650442ff.1632214561.git.min.m.xu@intel.com> From: "Brijesh Singh" Message-ID: <753f43a1-98e2-2477-4708-6e118221207e@amd.com> Date: Fri, 24 Sep 2021 05:58:03 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <12721dade1f2f9905cc34271d9abec24650442ff.1632214561.git.min.m.xu@intel.com> X-ClientProxiedBy: SA9PR03CA0002.namprd03.prod.outlook.com (2603:10b6:806:20::7) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SA9PR03CA0002.namprd03.prod.outlook.com (2603:10b6:806:20::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Fri, 24 Sep 2021 10:58:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dfd3a21f-e541-4be0-85ab-08d97f4a2fb2 X-MS-TrafficTypeDiagnostic: SN6PR12MB2768: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8qzn+gtJ4MTFsPWF5NeZc1Tx8w6kdsGpD3+NLXrOx+x8iBiSFwQ+Z3FB3SGOt2jVpMbSDXmIVWnv8bE/ERBLIjPYG9uXdtJvoBu/6XAVlTo0C8QNZ+i9wHsqZ/hRCAKq6iPI3fu0oLGL125sqOQ63umg8yvWZfAo+nrZ6eLrM7PrJ22wuV/33K+m7rNTmDLdwgZZzRS/zxlKDKYYkjySeip9Gg9Wy3J8gSnTxSdQ0/bFdjhjaKo/l5EHnbmbiHIYGmMqaNc3HaSr+1+JaVDp4UdeVvBkSoLdtMRbyxwiMCfxgE2QhaWw21CgXxtPMqQknXA1Qf7g3Un/02jq9BUB66J6nrLfuWfM4ySh+9I4xYmaHuVRFcQOYnxriw1OTn2rP8xyRH/uT+d3zBkTHWuga4BW4by7Cjq4lghoXV5808UhXVO0j12md0QHNkqdcjxbo6cYw4HtpUGIQgQgujEP6lPmuZopnRWeaTNZMlv5Orw6IpLtYpYoqV8YOYaHmaasLhtuNzMGHOa3tFlLvevR0Jucv6sTMkRTxvWKhD3lK2amoVpv3LyjGqVBVswaTfGvMzWGtZMUOPAOAcyGvamM0qk+QPdBztEZ5ZwZIS0WmUzaNnwWZtyLcmZD484hj1gcEdXztpDeZDM0oyypqvxUvqZ3KpwrU0NxYA7B7Qw4qL/RBcp5YpIaGf88Q/A4JKELCpdjtvuPMmJLAWt7YmKmca3HKs99IaQpRh7HLirn6JPZSC6UYyHWNbB5fMBLFcUUn50rjZe+xm0nXTjQJwktOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6512007)(86362001)(31696002)(6486002)(2616005)(508600001)(956004)(38100700002)(8936002)(38350700002)(2906002)(5660300002)(83380400001)(4326008)(26005)(66946007)(36756003)(66556008)(66476007)(6506007)(186003)(52116002)(4744005)(316002)(31686004)(44832011)(53546011)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajB4dHd6OGZDaGd5VkZZTmdtSlFZNUkzYjhQeVJMV1llbEp0SEtPRzYzWW02?= =?utf-8?B?MURNKzRwVW16R2FFeDFqNlAxRmJHWThCa1JMS0FBRGVPRmczRlkxTVR0a0Nh?= =?utf-8?B?L2FnNUpSejJZeTA2dFBobjBiRytERWVGVko1SWZtaWlONyt1Kzlja2cyU3lF?= =?utf-8?B?c1BxVkR5Vy95RmJFdmJWTmVUTWt5Wi9PRG8vdVhITjlsNDB4YmdkZUc2ellq?= =?utf-8?B?bml5SFo2eHZqcld2UEcwZWt3cy80cWE3cUNTRlpSaUJrUHFNT2tVdXZCcFVJ?= =?utf-8?B?d1R5cnlURGZKUmVjMnBnYXJ5SzVjSFUwTU5pMVdnZFZMdU0vZFh5Sm9yRXV3?= =?utf-8?B?Rk9zcng1ZEFBZGNMMVc3czRSRlhLTE9qaEtKaU1YNmd6c3NTWnFYM0M5N1Z4?= =?utf-8?B?bE5pd3ZQSEZsbk93NTFpQ2FTTXkzYmIxV0wxVTMxU0lOS3FmL0VHWjBqczg3?= =?utf-8?B?RXJ0ZS9zOWtadWkySDZnRzlFSHRqd2N4WE1HWlRYSVdtOUxUUFVtWkRBS0h3?= =?utf-8?B?VFVwYVN5UmhqQ1I4UmFINnZYMFJ3dExmWXgreEtwR3JSVHRtSmxJclRnUW9Z?= =?utf-8?B?Y0hNS20wbDg0cTRtUERsWU0rRVdqSThvdzJ0NjJPNVVuSXRGbEVLa0VXbE04?= =?utf-8?B?N1YvTk5PWDU4Nm1MNHB1bEdQcFJtR1d5MFhkVlV2WS91VVBRbEhzbUpFdVJW?= =?utf-8?B?MCtoNFVqaEEyRFpTRkdrNkpHZDRvQkExMUVkNjlRVHRxczRQejA0TFdjeFFL?= =?utf-8?B?Wm9EZHhqeUNhM25kTFRTK1hkQ1ZMeFZDTDVqT09YaXpzcGYzSXJ1Q25OUS9t?= =?utf-8?B?TU5UN0tXMDN3RG9EVTJVaXVVbk5Dd0l5Q2tSbDVuYTVKOW5XYXUxamw1QmVj?= =?utf-8?B?SHNlN1ZNZnBnYWNadkZBVzBpWUsrYWJMQmNKLzRuQzBLeTR1bExTcXF5cXov?= =?utf-8?B?MzJTV0FudlQyZTZVcE9VT1JFSml5YlVlbG5DVUxUaDRMY3Nzc1JYa1FkNXNX?= =?utf-8?B?WmRDczhPU1VwT0ZHZENtT3AybzRGbG55UHhXRVJZYzNxcTN6cnBsOE5HWVhS?= =?utf-8?B?MW1GMWg4Vi9SakRkdTFJajVXRUxsTkIwbThoakRKbFp3bnB0UmZuSlM2dGRH?= =?utf-8?B?SDN0UkNWcUpVYmUxaXc4c3dUSXpQNkdKNVZlV3lGSzZkQ3p4NVlsN3VxaHpj?= =?utf-8?B?KzVlLzNxdTA0REUwU0IwTVZHUmRtM08vRkRtZENmckFiVE1icVBKbmVCRFUy?= =?utf-8?B?VUVUWUI1bXlyZTQvWEgrZmRSZjFjOXZweWFJMVpRRjJpWmtjclQxN1J1eDR4?= =?utf-8?B?ZTlMUU9OZ2M4ZkVaVktrUHkxSnR2aHYrZzFBZERISGR0dUh0SVJ0M2psSUgx?= =?utf-8?B?bVRXSVNPemRRMzVlajg3V04vOExRVnlIRHNPYktNSzl5MGRvOWVTcnBDdks2?= =?utf-8?B?ZllRelpMY00yZUlxaGxXQTZBdkpya0tUREJ5UVhJaVd4VEN4UVBjbTJwcUlm?= =?utf-8?B?dHVMWk9lN3M4OC9Bd0d2WklEL2wySFpGMkVmeDFHbkxtY0d4cCttQmYrYnY4?= =?utf-8?B?aHZCQ2R2bjFVbXdScVFKZWFmWWt0eDFBYlFqZU9KSVhhUXprUFc2QWJZZ2M5?= =?utf-8?B?cGFCUlNrTWlZNGxUV0hIKy8vUVlxcG1VZGVNQlhmbWpISms4ZTRhcVBqZEpQ?= =?utf-8?B?U1RVUE50bTlxZzUzWGZCaHh2ZjJkdktGRGJveWtoemp5WXZGakF1MXhPRGRm?= =?utf-8?Q?/rhdOcV6ats8kPJjxpb1xppleA99l5Qyk0+x1NW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfd3a21f-e541-4be0-85ab-08d97f4a2fb2 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2021 10:58:05.5421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zkIWu9CwnDbkYmZI9tuFF9MqX6dG9P9Gpp+kDwVypqdqBOQEAq93XVHqTYBgUsM075LhgCqDjzM9X2EQIQmcxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2768 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Min, On 9/21/21 4:05 AM, Min Xu wrote: > ; > ; Modified: EAX, EBX, ECX, EDX > ; > SetCr3ForPageTables64: > - > - ; Clear the WorkArea header. The SEV probe routines will populate the > - ; work area when detected. > - mov byte[WORK_AREA_GUEST_TYPE], 0 Why you are removing the above block ? The workarea hdr must be initialized to zero, its not safe to assume that the guest memory is zero'ed in the non-encrypted case. thanks