From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.68; helo=mail-wr1-f68.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FB8621195BCA for ; Mon, 21 Jan 2019 14:47:03 -0800 (PST) Received: by mail-wr1-f68.google.com with SMTP id p4so25225668wrt.7 for ; Mon, 21 Jan 2019 14:47:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ld8kj9JcIUISMzgRg7fYXUXTMcdKFdOZSFiPXRXK9LQ=; b=eScv9QvXKIyw6d7RY3ctBtZ5EfwU2BP3Yq/2iMFImH1O9NxQcHiUQ+TsHcWYaINtPL Sbhj/i4J3py8a4S0lpoW3fgu7IV3rdcZODJH2eA0Lm8+vvPuncUnrrua41ISsOKWwwxv RkojwzXzwbbCKXCv8fLpwfqK1FBEdjI40//xofT/gVeEdqiBCjJ4TD63BhI19S7fmihn SzXE8qRX+AmI5SCVRubsfWdAiZ+uE7FOwFSJmR3LOpIEyXIxvphY9/kFfIhyFJIAS5CI jmyFAR62fI364oQz4Hr8t4knUgDucvMuNz8249q4e5UMptBYvRPxZxAna3S01Ppd543P TEzg== X-Gm-Message-State: AJcUukckTY5/8Oa5eeJL1q3ulC80GfXcltUI2xZucETCc3yK1rJsqW23 i2n4HRyuFgSE3LjG0Mer16yPodsoRKM= X-Google-Smtp-Source: ALg8bN4UtJHVz2g2H8n0pTDiEmvKPg+Whyd5cPvcyJrGAShELWdFTGGRmv/CTD+ZP3WqGW3yKelywg== X-Received: by 2002:adf:d146:: with SMTP id b6mr30140056wri.156.1548110821679; Mon, 21 Jan 2019 14:47:01 -0800 (PST) Received: from [192.168.1.33] (110.red-83-51-161.dynamicip.rima-tde.net. [83.51.161.110]) by smtp.gmail.com with ESMTPSA id c12sm84854823wrs.82.2019.01.21.14.47.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 14:47:00 -0800 (PST) To: Laszlo Ersek , "Gao, Liming" , Ard Biesheuvel Cc: "Wu, Hao A" , "Ye, Ting" , "Fu, Siyuan" , "Wu, Jiaxin" , "edk2-devel@lists.01.org" References: <20190118051612.9600-1-Jiaxin.wu@intel.com> <895558F6EA4E3B41AC93A00D163B727416EC67B5@SHSMSX107.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B4596@SHSMSX152.ccr.corp.intel.com> <70bb0ff8-09fe-42c9-0152-ffed039033bd@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3BF550@SHSMSX104.ccr.corp.intel.com> <0b4e9578-9831-cc59-1dad-e53d44492fa0@redhat.com> <682a23fe-6e66-0f78-d5e3-37b375f2eeda@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <7540b77b-f530-3755-ee69-6bf2aaec6625@redhat.com> Date: Mon, 21 Jan 2019 23:47:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <682a23fe-6e66-0f78-d5e3-37b375f2eeda@redhat.com> Subject: Re: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 22:47:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 1/21/19 10:21 PM, Laszlo Ersek wrote: > Hi Phil, > > On 01/21/19 14:26, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 1/21/19 1:53 PM, Gao, Liming wrote: >>> Thanks Ard and Laszlo. For the minor change in single patch, the patch may be sent separately with the clear subject. Or, the patch set can be sent again. >> >> Since it is hard to follow technical discussion when top-posted (see >> https://www.caliburn.nl/topposting.html) without scrolling and sometime >> loosing context, can we gently suggest bottom-posting in edk2-devel >> etiquette? (No offence, this is a humble suggestion from a not very >> active reviewer to a highly active contributor, but this might ease the >> on-list review workflow). > > top vs. bottom posting have been mentioned multiple times on edk2-devel; > it's just a fact that most corporate email environments don't support > bottom posting at all. > > I'm unhappy about it (obviously), but it's an uphill battle. Sometimes > the poster would actually *like* to bottom post, but the tooling (which > may not be their own choice) gets in their way. > > I suggest always scrolling to the bottom, or at least until you see a > signature. Oh, I was not aware of that, it makes now sense (there is a common pattern in companies/location with top-posts). Sorry for the noise, at least I tried ;) Regards, Phil. > > Thanks, > Laszlo >