public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Oram, Isaac W" <isaac.w.oram@intel.com>
To: devel@edk2.groups.io
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Chasel Chiu <chasel.chiu@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout
Date: Tue,  7 Jun 2022 16:45:29 -0700	[thread overview]
Message-ID: <75465408b8a1cf0d269a2b1d2ea7707b6731893e.1654645346.git.isaac.w.oram@intel.com> (raw)
In-Reply-To: <cover.1654645346.git.isaac.w.oram@intel.com>

V2:
Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2

V1: 
Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure
definitions such that compilers generate same binary layouts.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h            | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
index 0e10d0b8f0..11057a3ace 100644
--- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
+++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
@@ -1351,7 +1351,9 @@ typedef struct {
   **/
   UINT32     DmiAspm           :  1;
   UINT32     PwrOptEnable      :  1;    ///< <b>0: Disable</b>; 1: Enable DMI Power Optimizer on PCH side.
-  BOOLEAN    DmiStopAndScreamEnable : 1;
+  UINT32     Rsvdbits1         : 30;
+  UINT8      DmiStopAndScreamEnable : 1;
+  UINT8      Rsvdbits2              : 7;
   UINT32     DmiLinkDownHangBypass  : 1;
   UINT32     Rsvdbits               : 29;
   UINT32     Rsvd0[6];                  ///< Reserved bytes
@@ -1447,6 +1449,7 @@ typedef struct {
   TRACE_HUB_CONFIG            TraceHub;
   UINT32                      AetEnableMode      :  2;
   UINT32                      PchTraceHubHide    :  1;
+  UINT32                      Rsvdbits           : 29;
 } PCH_TRACE_HUB_CONFIG;
 
 
-- 
2.36.1.windows.1


       reply	other threads:[~2022-06-07 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1654645346.git.isaac.w.oram@intel.com>
2022-06-07 23:45 ` Oram, Isaac W [this message]
2022-06-08 21:53   ` [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Nate DeSimone
2022-06-09 20:54     ` Oram, Isaac W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75465408b8a1cf0d269a2b1d2ea7707b6731893e.1654645346.git.isaac.w.oram@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox