* [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout [not found] <cover.1654645346.git.isaac.w.oram@intel.com> @ 2022-06-07 23:45 ` Oram, Isaac W 2022-06-08 21:53 ` Nate DeSimone 0 siblings, 1 reply; 3+ messages in thread From: Oram, Isaac W @ 2022-06-07 23:45 UTC (permalink / raw) To: devel; +Cc: Nate DeSimone, Chasel Chiu V2: Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2 V1: Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definitions such that compilers generate same binary layouts. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h index 0e10d0b8f0..11057a3ace 100644 --- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h @@ -1351,7 +1351,9 @@ typedef struct { **/ UINT32 DmiAspm : 1; UINT32 PwrOptEnable : 1; ///< <b>0: Disable</b>; 1: Enable DMI Power Optimizer on PCH side. - BOOLEAN DmiStopAndScreamEnable : 1; + UINT32 Rsvdbits1 : 30; + UINT8 DmiStopAndScreamEnable : 1; + UINT8 Rsvdbits2 : 7; UINT32 DmiLinkDownHangBypass : 1; UINT32 Rsvdbits : 29; UINT32 Rsvd0[6]; ///< Reserved bytes @@ -1447,6 +1449,7 @@ typedef struct { TRACE_HUB_CONFIG TraceHub; UINT32 AetEnableMode : 2; UINT32 PchTraceHubHide : 1; + UINT32 Rsvdbits : 29; } PCH_TRACE_HUB_CONFIG; -- 2.36.1.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout 2022-06-07 23:45 ` [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Oram, Isaac W @ 2022-06-08 21:53 ` Nate DeSimone 2022-06-09 20:54 ` Oram, Isaac W 0 siblings, 1 reply; 3+ messages in thread From: Nate DeSimone @ 2022-06-08 21:53 UTC (permalink / raw) To: Oram, Isaac W, devel@edk2.groups.io; +Cc: Chiu, Chasel Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.oram@intel.com> Sent: Tuesday, June 7, 2022 4:49 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout V2: Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2 V1: Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definitions such that compilers generate same binary layouts. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h index 0e10d0b8f0..11057a3ace 100644 --- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPol +++ icyCommon.h @@ -1351,7 +1351,9 @@ typedef struct { **/ UINT32 DmiAspm : 1; UINT32 PwrOptEnable : 1; ///< <b>0: Disable</b>; 1: Enable DMI Power Optimizer on PCH side. - BOOLEAN DmiStopAndScreamEnable : 1; + UINT32 Rsvdbits1 : 30; + UINT8 DmiStopAndScreamEnable : 1; + UINT8 Rsvdbits2 : 7; UINT32 DmiLinkDownHangBypass : 1; UINT32 Rsvdbits : 29; UINT32 Rsvd0[6]; ///< Reserved bytes @@ -1447,6 +1449,7 @@ typedef struct { TRACE_HUB_CONFIG TraceHub; UINT32 AetEnableMode : 2; UINT32 PchTraceHubHide : 1; + UINT32 Rsvdbits : 29; } PCH_TRACE_HUB_CONFIG; -- 2.36.1.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout 2022-06-08 21:53 ` Nate DeSimone @ 2022-06-09 20:54 ` Oram, Isaac W 0 siblings, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-06-09 20:54 UTC (permalink / raw) To: Desimone, Nathaniel L, devel@edk2.groups.io; +Cc: Chiu, Chasel Pushed as c546cc01f1..2a236ae742 -----Original Message----- From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> Sent: Wednesday, June 8, 2022 2:53 PM To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com> Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.oram@intel.com> Sent: Tuesday, June 7, 2022 4:49 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout V2: Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2 V1: Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definitions such that compilers generate same binary layouts. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h index 0e10d0b8f0..11057a3ace 100644 --- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPol +++ icyCommon.h @@ -1351,7 +1351,9 @@ typedef struct { **/ UINT32 DmiAspm : 1; UINT32 PwrOptEnable : 1; ///< <b>0: Disable</b>; 1: Enable DMI Power Optimizer on PCH side. - BOOLEAN DmiStopAndScreamEnable : 1; + UINT32 Rsvdbits1 : 30; + UINT8 DmiStopAndScreamEnable : 1; + UINT8 Rsvdbits2 : 7; UINT32 DmiLinkDownHangBypass : 1; UINT32 Rsvdbits : 29; UINT32 Rsvd0[6]; ///< Reserved bytes @@ -1447,6 +1449,7 @@ typedef struct { TRACE_HUB_CONFIG TraceHub; UINT32 AetEnableMode : 2; UINT32 PchTraceHubHide : 1; + UINT32 Rsvdbits : 29; } PCH_TRACE_HUB_CONFIG; -- 2.36.1.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-09 20:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1654645346.git.isaac.w.oram@intel.com>
2022-06-07 23:45 ` [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Oram, Isaac W
2022-06-08 21:53 ` Nate DeSimone
2022-06-09 20:54 ` Oram, Isaac W
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox