From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 30 Jul 2019 02:13:15 -0700
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id E446999C48;
	Tue, 30 Jul 2019 09:13:14 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 864AA60BE5;
	Tue, 30 Jul 2019 09:13:13 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v4 02/35] OvmfPkg: Create platform OvmfXen
To: devel@edk2.groups.io, anthony.perard@citrix.com
Cc: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190729153944.24239-1-anthony.perard@citrix.com>
 <20190729153944.24239-3-anthony.perard@citrix.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7562c32f-0af8-d177-ac3e-1ddd8d063726@redhat.com>
Date: Tue, 30 Jul 2019 11:13:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190729153944.24239-3-anthony.perard@citrix.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 30 Jul 2019 09:13:15 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/29/19 17:39, Anthony PERARD wrote:
> OvmfXen is a copy of OvmfX64, removing VirtIO and some SMM.
> 
> This new platform will be changed to make it works on two types of Xen
> guest: HVM and PVH.
> 
> Compare to OvmfX64, this patch:
> 
> - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITION
> - removed: VirtioLib class resolution
> - removed: all UEFI_DRIVER modules for virtio devices
> - removed: DXE_SMM_DRIVER and SMM_CORE lib class resolutions
> - removed: DXE_SMM_DRIVER and SMM_CORE FDF rules
> - removed: Everything related to SMM_REQUIRE==true
> - removed: Everything related to SECURE_BOOT_ENABLE==true
> - removed: Everything related to TPM2_ENABLE==true
> - changed: PcdPciDisableBusEnumeration dynamic default flipped to TRUE
> - changed: default FD_SIZE_IN_KB to 2M.
> - reverted d272449d9e1e, "OvmfPkg: raise DXEFV size to 11 MB"
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v4:
>     - rebased
>     - Update Maintainers.txt
>     
>     v3:
>     - rebased, SPDX + 8259/8254 changes
> 
>  OvmfPkg/OvmfXen.dsc | 729 ++++++++++++++++++++++++++++++++++++++++++++
>  OvmfPkg/OvmfXen.fdf | 439 ++++++++++++++++++++++++++
>  Maintainers.txt     |   1 +
>  3 files changed, 1169 insertions(+)
>  create mode 100644 OvmfPkg/OvmfXen.dsc
>  create mode 100644 OvmfPkg/OvmfXen.fdf

[...]

> diff --git a/Maintainers.txt b/Maintainers.txt
> index 0298010809..98f6d828eb 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -372,6 +372,7 @@ F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>  F: OvmfPkg/Library/XenConsoleSerialPortLib/
>  F: OvmfPkg/Library/XenHypercallLib/
>  F: OvmfPkg/Library/XenIoMmioLib/
> +F: OvmfPkg/OvmfXen.*
>  F: OvmfPkg/PlatformPei/MemDetect.c
>  F: OvmfPkg/PlatformPei/Platform.*
>  F: OvmfPkg/PlatformPei/Xen.*
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>