From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.86564.1674248043725997168
 for <devel@edk2.groups.io>;
 Fri, 20 Jan 2023 12:54:03 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=RaXYN2ea;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id EA5A220E0A28;
	Fri, 20 Jan 2023 12:54:02 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EA5A220E0A28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1674248043;
	bh=k8VozoLhlc0/mqKVuejhzOsM/TOSgK9tgHG6Zsfs+5c=;
	h=Date:Subject:From:To:Reply-To:References:In-Reply-To:From;
	b=RaXYN2eafOFCArj8+lcRx4CRFgc0KktFPijNPn9/uEgmHKoaBrTenVI+Sg417wWoR
	 DVbotPF48SA/jmpxxx+NULWsIggxrrMFnck3b1QcYPfXnsdWTl21dYSBXz1JH0eaXY
	 5ITlNTwvd8EWSCm3fPzWewvE6tmFVTVGOD2wbaqk=
Message-ID: <75649289-c3cb-d020-2592-391315ccd9f6@linux.microsoft.com>
Date: Fri, 20 Jan 2023 15:54:01 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: Oliver Steffen <osteffen@redhat.com>, devel@edk2.groups.io
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <173C1FA3C96CC3CD.14781@groups.io>
In-Reply-To: <173C1FA3C96CC3CD.14781@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oliver,

Please let me know if you would like to be added to the maintainer list 
for this directory. I'm happy to update the patch and sent that in a v2.

Thanks,
Michael

On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Tianocore maintains container images in the tianocore/containers repo
> and stores container images within the GitHub container registry.
> 
> https://github.com/tianocore/containers
> 
> This change adds a devcontainer.json file to the edk2 repo. This
> file's metadata and settings to configurate a development container
> for a given well-defined tool and runtime stack.
> 
> More information about the devcontainer.json file is available here:
> https://containers.dev/implementors/json_reference/
> 
> This file is recognized by popular tools such as GitHub Codespaces
> and VS Code. In VS Code in particular, it makes it much easier for
> a user to be aware a dev container exists (via UI notifications)
> and to load the container.
> 
> A minimal number of VS Code extensions are specified that are useful
> for edk2 development or to assist in complying with CI checks in
> place in edk2.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Chris Fernald <chris.fernald@outlook.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>   Maintainers.txt                 |  5 +++++
>   2 files changed, 21 insertions(+)
> 
> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
> new file mode 100644
> index 000000000000..592bb8cf6626
> --- /dev/null
> +++ b/.devcontainer/devcontainer.json
> @@ -0,0 +1,16 @@
> +{
> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> +  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
> +  "customizations": {
> +    "vscode": {
> +      "extensions": [
> +        "DavidAnson.vscode-markdownlint",
> +        "ms-azuretools.vscode-docker",
> +        "ms-vscode-remote.remote-containers",
> +        "ms-vscode.cpptools",
> +        "walonli.edk2-vscode",
> +        "zachflower.uncrustify"
> +      ]
> +    }
> +  }
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 68f603b48398..4aa7973d5156 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
>   
> +.devcontainer/
> +F: .devcontainer/
> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> +
>   .github/
>   F: .github/
>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]