Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

Hi Oliver,

Please let me know if you would like to be added to the maintainer list 
for this directory. I'm happy to update the patch and sent that in a v2.

Thanks,
Michael

On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Tianocore maintains container images in the tianocore/containers repo
> and stores container images within the GitHub container registry.
> 
> https://github.com/tianocore/containers
> 
> This change adds a devcontainer.json file to the edk2 repo. This
> file's metadata and settings to configurate a development container
> for a given well-defined tool and runtime stack.
> 
> More information about the devcontainer.json file is available here:
> https://containers.dev/implementors/json_reference/
> 
> This file is recognized by popular tools such as GitHub Codespaces
> and VS Code. In VS Code in particular, it makes it much easier for
> a user to be aware a dev container exists (via UI notifications)
> and to load the container.
> 
> A minimal number of VS Code extensions are specified that are useful
> for edk2 development or to assist in complying with CI checks in
> place in edk2.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Chris Fernald <chris.fernald@outlook.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>   Maintainers.txt                 |  5 +++++
>   2 files changed, 21 insertions(+)
> 
> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
> new file mode 100644
> index 000000000000..592bb8cf6626
> --- /dev/null
> +++ b/.devcontainer/devcontainer.json
> @@ -0,0 +1,16 @@
> +{
> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> +  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
> +  "customizations": {
> +    "vscode": {
> +      "extensions": [
> +        "DavidAnson.vscode-markdownlint",
> +        "ms-azuretools.vscode-docker",
> +        "ms-vscode-remote.remote-containers",
> +        "ms-vscode.cpptools",
> +        "walonli.edk2-vscode",
> +        "zachflower.uncrustify"
> +      ]
> +    }
> +  }
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 68f603b48398..4aa7973d5156 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
>   
> +.devcontainer/
> +F: .devcontainer/
> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> +
>   .github/
>   F: .github/
>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Oliver Steffen]

[-- Attachment #1: Type: text/plain, Size: 3447 bytes --]

Hi Michael,
Thanks for thinking of me.
But I must admit I do not use devcontainers or vscode,
and I am not sure how much help I can be here.

It looks like a nice feature though, and I might try it out sometime.

Thanks,
 Oliver

On Fri, Jan 20, 2023 at 9:54 PM Michael Kubacki <
mikuback@linux.microsoft.com> wrote:

> Hi Oliver,
>
> Please let me know if you would like to be added to the maintainer list
> for this directory. I'm happy to update the patch and sent that in a v2.
>
> Thanks,
> Michael
>
> On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Tianocore maintains container images in the tianocore/containers repo
> > and stores container images within the GitHub container registry.
> >
> > https://github.com/tianocore/containers
> >
> > This change adds a devcontainer.json file to the edk2 repo. This
> > file's metadata and settings to configurate a development container
> > for a given well-defined tool and runtime stack.
> >
> > More information about the devcontainer.json file is available here:
> > https://containers.dev/implementors/json_reference/
> >
> > This file is recognized by popular tools such as GitHub Codespaces
> > and VS Code. In VS Code in particular, it makes it much easier for
> > a user to be aware a dev container exists (via UI notifications)
> > and to load the container.
> >
> > A minimal number of VS Code extensions are specified that are useful
> > for edk2 development or to assist in complying with CI checks in
> > place in edk2.
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Chris Fernald <chris.fernald@outlook.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Oliver Steffen <osteffen@redhat.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   .devcontainer/devcontainer.json | 16 ++++++++++++++++
> >   Maintainers.txt                 |  5 +++++
> >   2 files changed, 21 insertions(+)
> >
> > diff --git a/.devcontainer/devcontainer.json
> b/.devcontainer/devcontainer.json
> > new file mode 100644
> > index 000000000000..592bb8cf6626
> > --- /dev/null
> > +++ b/.devcontainer/devcontainer.json
> > @@ -0,0 +1,16 @@
> > +{
> > +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> > +  "postCreateCommand": "git config --global --add safe.directory * &&
> pip install --upgrade -r pip-requirements.txt",
> > +  "customizations": {
> > +    "vscode": {
> > +      "extensions": [
> > +        "DavidAnson.vscode-markdownlint",
> > +        "ms-azuretools.vscode-docker",
> > +        "ms-vscode-remote.remote-containers",
> > +        "ms-vscode.cpptools",
> > +        "walonli.edk2-vscode",
> > +        "zachflower.uncrustify"
> > +      ]
> > +    }
> > +  }
> > +}
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 68f603b48398..4aa7973d5156 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com>
> [makubacki]
> >   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> >   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> >
> > +.devcontainer/
> > +F: .devcontainer/
> > +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> > +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> > +
> >   .github/
> >   F: .github/
> >   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
>
>

[-- Attachment #2: Type: text/html, Size: 6198 bytes --]

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

I've seen interest on the patch but no R-b yet. I believe those in the 
TO line might be the best to provide that since this is a new directory.

If anyone is interested in being a maintainer/reviewer, let me know and 
I'll update the file.

Thanks,
Michael

On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Tianocore maintains container images in the tianocore/containers repo
> and stores container images within the GitHub container registry.
> 
> https://github.com/tianocore/containers
> 
> This change adds a devcontainer.json file to the edk2 repo. This
> file's metadata and settings to configurate a development container
> for a given well-defined tool and runtime stack.
> 
> More information about the devcontainer.json file is available here:
> https://containers.dev/implementors/json_reference/
> 
> This file is recognized by popular tools such as GitHub Codespaces
> and VS Code. In VS Code in particular, it makes it much easier for
> a user to be aware a dev container exists (via UI notifications)
> and to load the container.
> 
> A minimal number of VS Code extensions are specified that are useful
> for edk2 development or to assist in complying with CI checks in
> place in edk2.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Chris Fernald <chris.fernald@outlook.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>   Maintainers.txt                 |  5 +++++
>   2 files changed, 21 insertions(+)
> 
> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
> new file mode 100644
> index 000000000000..592bb8cf6626
> --- /dev/null
> +++ b/.devcontainer/devcontainer.json
> @@ -0,0 +1,16 @@
> +{
> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> +  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
> +  "customizations": {
> +    "vscode": {
> +      "extensions": [
> +        "DavidAnson.vscode-markdownlint",
> +        "ms-azuretools.vscode-docker",
> +        "ms-vscode-remote.remote-containers",
> +        "ms-vscode.cpptools",
> +        "walonli.edk2-vscode",
> +        "zachflower.uncrustify"
> +      ]
> +    }
> +  }
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 68f603b48398..4aa7973d5156 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
>   
> +.devcontainer/
> +F: .devcontainer/
> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> +
>   .github/
>   F: .github/
>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

With the soft freeze starting soon, I wanted to bring attention to this 
patch again. It has not received feedback in 2+ weeks on the list.

It is simple and intended to help users more easily use Tianocore 
containers.

Can you please review and include this in the stable tag?

Thanks,
Michael

On 1/26/2023 9:44 AM, Michael Kubacki wrote:
> I've seen interest on the patch but no R-b yet. I believe those in the 
> TO line might be the best to provide that since this is a new directory.
> 
> If anyone is interested in being a maintainer/reviewer, let me know and 
> I'll update the file.
> 
> Thanks,
> Michael
> 
> On 1/20/2023 3:51 PM, Michael Kubacki wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Tianocore maintains container images in the tianocore/containers repo
>> and stores container images within the GitHub container registry.
>>
>> https://github.com/tianocore/containers
>>
>> This change adds a devcontainer.json file to the edk2 repo. This
>> file's metadata and settings to configurate a development container
>> for a given well-defined tool and runtime stack.
>>
>> More information about the devcontainer.json file is available here:
>> https://containers.dev/implementors/json_reference/
>>
>> This file is recognized by popular tools such as GitHub Codespaces
>> and VS Code. In VS Code in particular, it makes it much easier for
>> a user to be aware a dev container exists (via UI notifications)
>> and to load the container.
>>
>> A minimal number of VS Code extensions are specified that are useful
>> for edk2 development or to assist in complying with CI checks in
>> place in edk2.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Chris Fernald <chris.fernald@outlook.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Oliver Steffen <osteffen@redhat.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>>   Maintainers.txt                 |  5 +++++
>>   2 files changed, 21 insertions(+)
>>
>> diff --git a/.devcontainer/devcontainer.json 
>> b/.devcontainer/devcontainer.json
>> new file mode 100644
>> index 000000000000..592bb8cf6626
>> --- /dev/null
>> +++ b/.devcontainer/devcontainer.json
>> @@ -0,0 +1,16 @@
>> +{
>> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
>> +  "postCreateCommand": "git config --global --add safe.directory * && 
>> pip install --upgrade -r pip-requirements.txt",
>> +  "customizations": {
>> +    "vscode": {
>> +      "extensions": [
>> +        "DavidAnson.vscode-markdownlint",
>> +        "ms-azuretools.vscode-docker",
>> +        "ms-vscode-remote.remote-containers",
>> +        "ms-vscode.cpptools",
>> +        "walonli.edk2-vscode",
>> +        "zachflower.uncrustify"
>> +      ]
>> +    }
>> +  }
>> +}
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 68f603b48398..4aa7973d5156 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> 
>> [makubacki]
>>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
>>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
>> +.devcontainer/
>> +F: .devcontainer/
>> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
>> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
>> +
>>   .github/
>>   F: .github/
>>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
> 
> 
> 
> 

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael D Kinney]

Acked-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Sunday, February 5, 2023 10:34 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Andrew Fish
> <afish@apple.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Chris Fernald <chris.fernald@outlook.com>; Oliver Steffen <osteffen@redhat.com>; Sean Brogan <spbrogan@outlook.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file
> 
> With the soft freeze starting soon, I wanted to bring attention to this
> patch again. It has not received feedback in 2+ weeks on the list.
> 
> It is simple and intended to help users more easily use Tianocore
> containers.
> 
> Can you please review and include this in the stable tag?
> 
> Thanks,
> Michael
> 
> On 1/26/2023 9:44 AM, Michael Kubacki wrote:
> > I've seen interest on the patch but no R-b yet. I believe those in the
> > TO line might be the best to provide that since this is a new directory.
> >
> > If anyone is interested in being a maintainer/reviewer, let me know and
> > I'll update the file.
> >
> > Thanks,
> > Michael
> >
> > On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> Tianocore maintains container images in the tianocore/containers repo
> >> and stores container images within the GitHub container registry.
> >>
> >> https://github.com/tianocore/containers
> >>
> >> This change adds a devcontainer.json file to the edk2 repo. This
> >> file's metadata and settings to configurate a development container
> >> for a given well-defined tool and runtime stack.
> >>
> >> More information about the devcontainer.json file is available here:
> >> https://containers.dev/implementors/json_reference/
> >>
> >> This file is recognized by popular tools such as GitHub Codespaces
> >> and VS Code. In VS Code in particular, it makes it much easier for
> >> a user to be aware a dev container exists (via UI notifications)
> >> and to load the container.
> >>
> >> A minimal number of VS Code extensions are specified that are useful
> >> for edk2 development or to assist in complying with CI checks in
> >> place in edk2.
> >>
> >> Cc: Andrew Fish <afish@apple.com>
> >> Cc: Chris Fernald <chris.fernald@outlook.com>
> >> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Cc: Oliver Steffen <osteffen@redhat.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >> ---
> >>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
> >>   Maintainers.txt                 |  5 +++++
> >>   2 files changed, 21 insertions(+)
> >>
> >> diff --git a/.devcontainer/devcontainer.json
> >> b/.devcontainer/devcontainer.json
> >> new file mode 100644
> >> index 000000000000..592bb8cf6626
> >> --- /dev/null
> >> +++ b/.devcontainer/devcontainer.json
> >> @@ -0,0 +1,16 @@
> >> +{
> >> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> >> +  "postCreateCommand": "git config --global --add safe.directory * &&
> >> pip install --upgrade -r pip-requirements.txt",
> >> +  "customizations": {
> >> +    "vscode": {
> >> +      "extensions": [
> >> +        "DavidAnson.vscode-markdownlint",
> >> +        "ms-azuretools.vscode-docker",
> >> +        "ms-vscode-remote.remote-containers",
> >> +        "ms-vscode.cpptools",
> >> +        "walonli.edk2-vscode",
> >> +        "zachflower.uncrustify"
> >> +      ]
> >> +    }
> >> +  }
> >> +}
> >> diff --git a/Maintainers.txt b/Maintainers.txt
> >> index 68f603b48398..4aa7973d5156 100644
> >> --- a/Maintainers.txt
> >> +++ b/Maintainers.txt
> >> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com>
> >> [makubacki]
> >>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> >>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> >> +.devcontainer/
> >> +F: .devcontainer/
> >> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> >> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> >> +
> >>   .github/
> >>   F: .github/
> >>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
> >
> >
> > 
> >

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

Hi Liming,

I put the patch with received review tags in the following PR:

https://github.com/tianocore/edk2/pull/4015

Thanks,
Michael

On 2/5/2023 1:34 PM, Michael Kubacki wrote:
> With the soft freeze starting soon, I wanted to bring attention to this 
> patch again. It has not received feedback in 2+ weeks on the list.
> 
> It is simple and intended to help users more easily use Tianocore 
> containers.
> 
> Can you please review and include this in the stable tag?
> 
> Thanks,
> Michael
> 
> On 1/26/2023 9:44 AM, Michael Kubacki wrote:
>> I've seen interest on the patch but no R-b yet. I believe those in the 
>> TO line might be the best to provide that since this is a new directory.
>>
>> If anyone is interested in being a maintainer/reviewer, let me know 
>> and I'll update the file.
>>
>> Thanks,
>> Michael
>>
>> On 1/20/2023 3:51 PM, Michael Kubacki wrote:
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> Tianocore maintains container images in the tianocore/containers repo
>>> and stores container images within the GitHub container registry.
>>>
>>> https://github.com/tianocore/containers
>>>
>>> This change adds a devcontainer.json file to the edk2 repo. This
>>> file's metadata and settings to configurate a development container
>>> for a given well-defined tool and runtime stack.
>>>
>>> More information about the devcontainer.json file is available here:
>>> https://containers.dev/implementors/json_reference/
>>>
>>> This file is recognized by popular tools such as GitHub Codespaces
>>> and VS Code. In VS Code in particular, it makes it much easier for
>>> a user to be aware a dev container exists (via UI notifications)
>>> and to load the container.
>>>
>>> A minimal number of VS Code extensions are specified that are useful
>>> for edk2 development or to assist in complying with CI checks in
>>> place in edk2.
>>>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Chris Fernald <chris.fernald@outlook.com>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Oliver Steffen <osteffen@redhat.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>>>   Maintainers.txt                 |  5 +++++
>>>   2 files changed, 21 insertions(+)
>>>
>>> diff --git a/.devcontainer/devcontainer.json 
>>> b/.devcontainer/devcontainer.json
>>> new file mode 100644
>>> index 000000000000..592bb8cf6626
>>> --- /dev/null
>>> +++ b/.devcontainer/devcontainer.json
>>> @@ -0,0 +1,16 @@
>>> +{
>>> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
>>> +  "postCreateCommand": "git config --global --add safe.directory * 
>>> && pip install --upgrade -r pip-requirements.txt",
>>> +  "customizations": {
>>> +    "vscode": {
>>> +      "extensions": [
>>> +        "DavidAnson.vscode-markdownlint",
>>> +        "ms-azuretools.vscode-docker",
>>> +        "ms-vscode-remote.remote-containers",
>>> +        "ms-vscode.cpptools",
>>> +        "walonli.edk2-vscode",
>>> +        "zachflower.uncrustify"
>>> +      ]
>>> +    }
>>> +  }
>>> +}
>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>> index 68f603b48398..4aa7973d5156 100644
>>> --- a/Maintainers.txt
>>> +++ b/Maintainers.txt
>>> @@ -117,6 +117,11 @@ M: Michael Kubacki 
>>> <mikuback@linux.microsoft.com> [makubacki]
>>>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
>>>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
>>> +.devcontainer/
>>> +F: .devcontainer/
>>> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
>>> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
>>> +
>>>   .github/
>>>   F: .github/
>>>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
>>
>>
>> 
>>

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael D Kinney]

Hi Michael,

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Please update commit message from Ab to Rb and I will merge.

Thanks,

Mike

> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Tuesday, February 7, 2023 7:50 PM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Chris Fernald <chris.fernald@outlook.com>; Oliver Steffen <osteffen@redhat.com>; Sean Brogan <spbrogan@outlook.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Andrew Fish <afish@apple.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file
> 
> Hi Liming,
> 
> I put the patch with received review tags in the following PR:
> 
> https://github.com/tianocore/edk2/pull/4015
> 
> Thanks,
> Michael
> 
> On 2/5/2023 1:34 PM, Michael Kubacki wrote:
> > With the soft freeze starting soon, I wanted to bring attention to this
> > patch again. It has not received feedback in 2+ weeks on the list.
> >
> > It is simple and intended to help users more easily use Tianocore
> > containers.
> >
> > Can you please review and include this in the stable tag?
> >
> > Thanks,
> > Michael
> >
> > On 1/26/2023 9:44 AM, Michael Kubacki wrote:
> >> I've seen interest on the patch but no R-b yet. I believe those in the
> >> TO line might be the best to provide that since this is a new directory.
> >>
> >> If anyone is interested in being a maintainer/reviewer, let me know
> >> and I'll update the file.
> >>
> >> Thanks,
> >> Michael
> >>
> >> On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> >>> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>>
> >>> Tianocore maintains container images in the tianocore/containers repo
> >>> and stores container images within the GitHub container registry.
> >>>
> >>> https://github.com/tianocore/containers
> >>>
> >>> This change adds a devcontainer.json file to the edk2 repo. This
> >>> file's metadata and settings to configurate a development container
> >>> for a given well-defined tool and runtime stack.
> >>>
> >>> More information about the devcontainer.json file is available here:
> >>> https://containers.dev/implementors/json_reference/
> >>>
> >>> This file is recognized by popular tools such as GitHub Codespaces
> >>> and VS Code. In VS Code in particular, it makes it much easier for
> >>> a user to be aware a dev container exists (via UI notifications)
> >>> and to load the container.
> >>>
> >>> A minimal number of VS Code extensions are specified that are useful
> >>> for edk2 development or to assist in complying with CI checks in
> >>> place in edk2.
> >>>
> >>> Cc: Andrew Fish <afish@apple.com>
> >>> Cc: Chris Fernald <chris.fernald@outlook.com>
> >>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Cc: Oliver Steffen <osteffen@redhat.com>
> >>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >>> ---
> >>>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
> >>>   Maintainers.txt                 |  5 +++++
> >>>   2 files changed, 21 insertions(+)
> >>>
> >>> diff --git a/.devcontainer/devcontainer.json
> >>> b/.devcontainer/devcontainer.json
> >>> new file mode 100644
> >>> index 000000000000..592bb8cf6626
> >>> --- /dev/null
> >>> +++ b/.devcontainer/devcontainer.json
> >>> @@ -0,0 +1,16 @@
> >>> +{
> >>> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> >>> +  "postCreateCommand": "git config --global --add safe.directory *
> >>> && pip install --upgrade -r pip-requirements.txt",
> >>> +  "customizations": {
> >>> +    "vscode": {
> >>> +      "extensions": [
> >>> +        "DavidAnson.vscode-markdownlint",
> >>> +        "ms-azuretools.vscode-docker",
> >>> +        "ms-vscode-remote.remote-containers",
> >>> +        "ms-vscode.cpptools",
> >>> +        "walonli.edk2-vscode",
> >>> +        "zachflower.uncrustify"
> >>> +      ]
> >>> +    }
> >>> +  }
> >>> +}
> >>> diff --git a/Maintainers.txt b/Maintainers.txt
> >>> index 68f603b48398..4aa7973d5156 100644
> >>> --- a/Maintainers.txt
> >>> +++ b/Maintainers.txt
> >>> @@ -117,6 +117,11 @@ M: Michael Kubacki
> >>> <mikuback@linux.microsoft.com> [makubacki]
> >>>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> >>>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> >>> +.devcontainer/
> >>> +F: .devcontainer/
> >>> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> >>> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> >>> +
> >>>   .github/
> >>>   F: .github/
> >>>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
> >>
> >>
> >> 
> >>

回复: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[gaoliming]

Michael:
  I am OK to merge this patch into this stable tag 202302. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2023年2月10日 13:02
> 收件人: devel@edk2.groups.io; mikuback@linux.microsoft.com; Gao, Liming
> <gaoliming@byosoft.com.cn>
> 抄送: Chris Fernald <chris.fernald@outlook.com>; Oliver Steffen
> <osteffen@redhat.com>; Sean Brogan <spbrogan@outlook.com>; Leif
> Lindholm <quic_llindhol@quicinc.com>; Andrew Fish <afish@apple.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> 主题: RE: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add
> devcontainer file
> 
> Hi Michael,
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Please update commit message from Ab to Rb and I will merge.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Michael Kubacki <mikuback@linux.microsoft.com>
> > Sent: Tuesday, February 7, 2023 7:50 PM
> > To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> > Cc: Chris Fernald <chris.fernald@outlook.com>; Oliver Steffen
> <osteffen@redhat.com>; Sean Brogan <spbrogan@outlook.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Andrew Fish <afish@apple.com>
> > Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json:
> Add devcontainer file
> >
> > Hi Liming,
> >
> > I put the patch with received review tags in the following PR:
> >
> > https://github.com/tianocore/edk2/pull/4015
> >
> > Thanks,
> > Michael
> >
> > On 2/5/2023 1:34 PM, Michael Kubacki wrote:
> > > With the soft freeze starting soon, I wanted to bring attention to this
> > > patch again. It has not received feedback in 2+ weeks on the list.
> > >
> > > It is simple and intended to help users more easily use Tianocore
> > > containers.
> > >
> > > Can you please review and include this in the stable tag?
> > >
> > > Thanks,
> > > Michael
> > >
> > > On 1/26/2023 9:44 AM, Michael Kubacki wrote:
> > >> I've seen interest on the patch but no R-b yet. I believe those in the
> > >> TO line might be the best to provide that since this is a new directory.
> > >>
> > >> If anyone is interested in being a maintainer/reviewer, let me know
> > >> and I'll update the file.
> > >>
> > >> Thanks,
> > >> Michael
> > >>
> > >> On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> > >>> From: Michael Kubacki <michael.kubacki@microsoft.com>
> > >>>
> > >>> Tianocore maintains container images in the tianocore/containers repo
> > >>> and stores container images within the GitHub container registry.
> > >>>
> > >>> https://github.com/tianocore/containers
> > >>>
> > >>> This change adds a devcontainer.json file to the edk2 repo. This
> > >>> file's metadata and settings to configurate a development container
> > >>> for a given well-defined tool and runtime stack.
> > >>>
> > >>> More information about the devcontainer.json file is available here:
> > >>> https://containers.dev/implementors/json_reference/
> > >>>
> > >>> This file is recognized by popular tools such as GitHub Codespaces
> > >>> and VS Code. In VS Code in particular, it makes it much easier for
> > >>> a user to be aware a dev container exists (via UI notifications)
> > >>> and to load the container.
> > >>>
> > >>> A minimal number of VS Code extensions are specified that are useful
> > >>> for edk2 development or to assist in complying with CI checks in
> > >>> place in edk2.
> > >>>
> > >>> Cc: Andrew Fish <afish@apple.com>
> > >>> Cc: Chris Fernald <chris.fernald@outlook.com>
> > >>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >>> Cc: Oliver Steffen <osteffen@redhat.com>
> > >>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > >>> ---
> > >>>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
> > >>>   Maintainers.txt                 |  5 +++++
> > >>>   2 files changed, 21 insertions(+)
> > >>>
> > >>> diff --git a/.devcontainer/devcontainer.json
> > >>> b/.devcontainer/devcontainer.json
> > >>> new file mode 100644
> > >>> index 000000000000..592bb8cf6626
> > >>> --- /dev/null
> > >>> +++ b/.devcontainer/devcontainer.json
> > >>> @@ -0,0 +1,16 @@
> > >>> +{
> > >>> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> > >>> +  "postCreateCommand": "git config --global --add safe.directory *
> > >>> && pip install --upgrade -r pip-requirements.txt",
> > >>> +  "customizations": {
> > >>> +    "vscode": {
> > >>> +      "extensions": [
> > >>> +        "DavidAnson.vscode-markdownlint",
> > >>> +        "ms-azuretools.vscode-docker",
> > >>> +        "ms-vscode-remote.remote-containers",
> > >>> +        "ms-vscode.cpptools",
> > >>> +        "walonli.edk2-vscode",
> > >>> +        "zachflower.uncrustify"
> > >>> +      ]
> > >>> +    }
> > >>> +  }
> > >>> +}
> > >>> diff --git a/Maintainers.txt b/Maintainers.txt
> > >>> index 68f603b48398..4aa7973d5156 100644
> > >>> --- a/Maintainers.txt
> > >>> +++ b/Maintainers.txt
> > >>> @@ -117,6 +117,11 @@ M: Michael Kubacki
> > >>> <mikuback@linux.microsoft.com> [makubacki]
> > >>>   R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > >>>   R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > >>> +.devcontainer/
> > >>> +F: .devcontainer/
> > >>> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> > >>> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> > >>> +
> > >>>   .github/
> > >>>   F: .github/
> > >>>   M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
> > >>
> > >>
> > >> 
> > >>

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Hi Mike,

I rebased the PR branch and updated the Ab to Rb.

https://github.com/tianocore/edk2/pull/4015

Thanks,
Michael

[-- Attachment #2: Type: text/html, Size: 305 bytes --]

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Merged

Commit: https://github.com/tianocore/edk2/commit/540522fec06b87bf11ad5624abe23b515f282d60

Mike

From: Michael Kubacki <mikuback@linux.microsoft.com>
Sent: Monday, February 13, 2023 6:14 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

Hi Mike,

I rebased the PR branch and updated the Ab to Rb.

https://github.com/tianocore/edk2/pull/4015

Thanks,
Michael

[-- Attachment #2: Type: text/html, Size: 39472 bytes --]

[PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

Tianocore maintains container images in the tianocore/containers repo
and stores container images within the GitHub container registry.

https://github.com/tianocore/containers

This change adds a devcontainer.json file to the edk2 repo. This
file's metadata and settings to configurate a development container
for a given well-defined tool and runtime stack.

More information about the devcontainer.json file is available here:
https://containers.dev/implementors/json_reference/

This file is recognized by popular tools such as GitHub Codespaces
and VS Code. In VS Code in particular, it makes it much easier for
a user to be aware a dev container exists (via UI notifications)
and to load the container.

A minimal number of VS Code extensions are specified that are useful
for edk2 development or to assist in complying with CI checks in
place in edk2.

Cc: Andrew Fish <afish@apple.com>
Cc: Chris Fernald <chris.fernald@outlook.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 .devcontainer/devcontainer.json | 16 ++++++++++++++++
 Maintainers.txt                 |  5 +++++
 2 files changed, 21 insertions(+)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
new file mode 100644
index 000000000000..592bb8cf6626
--- /dev/null
+++ b/.devcontainer/devcontainer.json
@@ -0,0 +1,16 @@
+{
+  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
+  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
+  "customizations": {
+    "vscode": {
+      "extensions": [
+        "DavidAnson.vscode-markdownlint",
+        "ms-azuretools.vscode-docker",
+        "ms-vscode-remote.remote-containers",
+        "ms-vscode.cpptools",
+        "walonli.edk2-vscode",
+        "zachflower.uncrustify"
+      ]
+    }
+  }
+}
diff --git a/Maintainers.txt b/Maintainers.txt
index 68f603b48398..4aa7973d5156 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
 R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
 R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
 
+.devcontainer/
+F: .devcontainer/
+M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
+R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
+
 .github/
 F: .github/
 M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
-- 
2.28.0.windows.1

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Rebecca Cran]

[-- Attachment #1: Type: text/plain, Size: 2954 bytes --]

Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)?

Also perhaps a .editorconfig file?

-- 

Rebecca Cran


On 1/20/23 13:51, Michael Kubacki wrote:
> From: Michael Kubacki<michael.kubacki@microsoft.com>
>
> Tianocore maintains container images in the tianocore/containers repo
> and stores container images within the GitHub container registry.
>
> https://github.com/tianocore/containers
>
> This change adds a devcontainer.json file to the edk2 repo. This
> file's metadata and settings to configurate a development container
> for a given well-defined tool and runtime stack.
>
> More information about the devcontainer.json file is available here:
> https://containers.dev/implementors/json_reference/
>
> This file is recognized by popular tools such as GitHub Codespaces
> and VS Code. In VS Code in particular, it makes it much easier for
> a user to be aware a dev container exists (via UI notifications)
> and to load the container.
>
> A minimal number of VS Code extensions are specified that are useful
> for edk2 development or to assist in complying with CI checks in
> place in edk2.
>
> Cc: Andrew Fish<afish@apple.com>
> Cc: Chris Fernald<chris.fernald@outlook.com>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Michael D Kinney<michael.d.kinney@intel.com>
> Cc: Oliver Steffen<osteffen@redhat.com>
> Signed-off-by: Michael Kubacki<michael.kubacki@microsoft.com>
> ---
>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>   Maintainers.txt                 |  5 +++++
>   2 files changed, 21 insertions(+)
>
> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
> new file mode 100644
> index 000000000000..592bb8cf6626
> --- /dev/null
> +++ b/.devcontainer/devcontainer.json
> @@ -0,0 +1,16 @@
> +{
> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
> +  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
> +  "customizations": {
> +    "vscode": {
> +      "extensions": [
> +        "DavidAnson.vscode-markdownlint",
> +        "ms-azuretools.vscode-docker",
> +        "ms-vscode-remote.remote-containers",
> +        "ms-vscode.cpptools",
> +        "walonli.edk2-vscode",
> +        "zachflower.uncrustify"
> +      ]
> +    }
> +  }
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 68f603b48398..4aa7973d5156 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -117,6 +117,11 @@ M: Michael Kubacki<mikuback@linux.microsoft.com>  [makubacki]
>   R: Michael D Kinney<michael.d.kinney@intel.com>  [mdkinney]
>   R: Liming Gao<gaoliming@byosoft.com.cn>  [lgao4]
>   
> +.devcontainer/
> +F: .devcontainer/
> +M: Michael Kubacki<mikuback@linux.microsoft.com>  [makubacki]
> +R: Chris Fernald<chris.fernald@outlook.com>  [cfernald]
> +
>   .github/
>   F: .github/
>   M: Sean Brogan<sean.brogan@microsoft.com>  [spbrogan]

[-- Attachment #2: Type: text/html, Size: 4517 bytes --]

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Michael Kubacki]

I think that's a good idea. edk2-pytool-extensions has a 
.vscode/settings.json file that has been useful for local python linting 
and testing that helps catch issues before CI.

For example:
https://github.com/tianocore/edk2-pytool-extensions/blob/master/.vscode/settings.json

On 1/20/2023 4:22 PM, Rebecca Cran wrote:
> Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)?
> 
> Also perhaps a .editorconfig file?
> 
> -- 
> 
> Rebecca Cran
> 
> 
> On 1/20/23 13:51, Michael Kubacki wrote:
>> From: Michael Kubacki<michael.kubacki@microsoft.com>
>>
>> Tianocore maintains container images in the tianocore/containers repo
>> and stores container images within the GitHub container registry.
>>
>> https://github.com/tianocore/containers
>>
>> This change adds a devcontainer.json file to the edk2 repo. This
>> file's metadata and settings to configurate a development container
>> for a given well-defined tool and runtime stack.
>>
>> More information about the devcontainer.json file is available here:
>> https://containers.dev/implementors/json_reference/
>>
>> This file is recognized by popular tools such as GitHub Codespaces
>> and VS Code. In VS Code in particular, it makes it much easier for
>> a user to be aware a dev container exists (via UI notifications)
>> and to load the container.
>>
>> A minimal number of VS Code extensions are specified that are useful
>> for edk2 development or to assist in complying with CI checks in
>> place in edk2.
>>
>> Cc: Andrew Fish<afish@apple.com>
>> Cc: Chris Fernald<chris.fernald@outlook.com>
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Michael D Kinney<michael.d.kinney@intel.com>
>> Cc: Oliver Steffen<osteffen@redhat.com>
>> Signed-off-by: Michael Kubacki<michael.kubacki@microsoft.com>
>> ---
>>   .devcontainer/devcontainer.json | 16 ++++++++++++++++
>>   Maintainers.txt                 |  5 +++++
>>   2 files changed, 21 insertions(+)
>>
>> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
>> new file mode 100644
>> index 000000000000..592bb8cf6626
>> --- /dev/null
>> +++ b/.devcontainer/devcontainer.json
>> @@ -0,0 +1,16 @@
>> +{
>> +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
>> +  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
>> +  "customizations": {
>> +    "vscode": {
>> +      "extensions": [
>> +        "DavidAnson.vscode-markdownlint",
>> +        "ms-azuretools.vscode-docker",
>> +        "ms-vscode-remote.remote-containers",
>> +        "ms-vscode.cpptools",
>> +        "walonli.edk2-vscode",
>> +        "zachflower.uncrustify"
>> +      ]
>> +    }
>> +  }
>> +}
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 68f603b48398..4aa7973d5156 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -117,6 +117,11 @@ M: Michael Kubacki<mikuback@linux.microsoft.com>  [makubacki]
>>   R: Michael D Kinney<michael.d.kinney@intel.com>  [mdkinney]
>>   R: Liming Gao<gaoliming@byosoft.com.cn>  [lgao4]
>>   
>> +.devcontainer/
>> +F: .devcontainer/
>> +M: Michael Kubacki<mikuback@linux.microsoft.com>  [makubacki]
>> +R: Chris Fernald<chris.fernald@outlook.com>  [cfernald]
>> +
>>   .github/
>>   F: .github/
>>   M: Sean Brogan<sean.brogan@microsoft.com>  [spbrogan]
> 

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Oliver Steffen]

Quoting Rebecca Cran (2023-01-20 22:22:55)
> Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)?

As long as project settings for other IDEs (should
there be a reasonable user base) would be accepted in the future, why not?

>
> Also perhaps a .editorconfig file?
I like the idea, because it is understood by many IDEs and text editors.

>
> --
>
> Rebecca Cran
>
>
> On 1/20/23 13:51, Michael Kubacki wrote:
>
>     From: Michael Kubacki [1]<michael.kubacki@microsoft.com>
>
>     Tianocore maintains container images in the tianocore/containers repo
>     and stores container images within the GitHub container registry.
>
>     [2]https://github.com/tianocore/containers
>
>     This change adds a devcontainer.json file to the edk2 repo. This
>     file's metadata and settings to configurate a development container
>     for a given well-defined tool and runtime stack.
>
>     More information about the devcontainer.json file is available here:
>     [3]https://containers.dev/implementors/json_reference/
>
>     This file is recognized by popular tools such as GitHub Codespaces
>     and VS Code. In VS Code in particular, it makes it much easier for
>     a user to be aware a dev container exists (via UI notifications)
>     and to load the container.
>
>     A minimal number of VS Code extensions are specified that are useful
>     for edk2 development or to assist in complying with CI checks in
>     place in edk2.
>
>     Cc: Andrew Fish [4]<afish@apple.com>
>     Cc: Chris Fernald [5]<chris.fernald@outlook.com>
>     Cc: Leif Lindholm [6]<quic_llindhol@quicinc.com>
>     Cc: Michael D Kinney [7]<michael.d.kinney@intel.com>
>     Cc: Oliver Steffen [8]<osteffen@redhat.com>
>     Signed-off-by: Michael Kubacki [9]<michael.kubacki@microsoft.com>
>     ---
>      .devcontainer/devcontainer.json | 16 ++++++++++++++++
>      Maintainers.txt                 |  5 +++++
>      2 files changed, 21 insertions(+)
>
>     diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
>     new file mode 100644
>     index 000000000000..592bb8cf6626
>     --- /dev/null
>     +++ b/.devcontainer/devcontainer.json
>     @@ -0,0 +1,16 @@
>     +{
>     +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
>     +  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
>     +  "customizations": {
>     +    "vscode": {
>     +      "extensions": [
>     +        "DavidAnson.vscode-markdownlint",
>     +        "ms-azuretools.vscode-docker",
>     +        "ms-vscode-remote.remote-containers",
>     +        "ms-vscode.cpptools",
>     +        "walonli.edk2-vscode",
>     +        "zachflower.uncrustify"
>     +      ]
>     +    }
>     +  }
>     +}
>     diff --git a/Maintainers.txt b/Maintainers.txt
>     index 68f603b48398..4aa7973d5156 100644
>     --- a/Maintainers.txt
>     +++ b/Maintainers.txt
>     @@ -117,6 +117,11 @@ M: Michael Kubacki [10]<mikuback@linux.microsoft.com> [makubacki]
>      R: Michael D Kinney [11]<michael.d.kinney@intel.com> [mdkinney]
>      R: Liming Gao [12]<gaoliming@byosoft.com.cn> [lgao4]
>
>     +.devcontainer/
>     +F: .devcontainer/
>     +M: Michael Kubacki [13]<mikuback@linux.microsoft.com> [makubacki]
>     +R: Chris Fernald [14]<chris.fernald@outlook.com> [cfernald]
>     +
>      .github/
>      F: .github/
>      M: Sean Brogan [15]<sean.brogan@microsoft.com> [spbrogan]
>
>
-Oliver

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

[Ard Biesheuvel]

On Mon, 23 Jan 2023 at 10:23, Oliver Steffen <osteffen@redhat.com> wrote:
>
> Quoting Rebecca Cran (2023-01-20 22:22:55)
> > Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)?
>
> As long as project settings for other IDEs (should
> there be a reasonable user base) would be accepted in the future, why not?
>
> >
> > Also perhaps a .editorconfig file?
> I like the idea, because it is understood by many IDEs and text editors.
>

Yes, please, this would be very useful.