From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ml01.01.org (Postfix) with ESMTP id CD6BB1A1DEF for ; Fri, 29 Jul 2016 02:30:44 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 29 Jul 2016 02:30:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,438,1464678000"; d="scan'208";a="1016098033" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 29 Jul 2016 02:30:44 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 29 Jul 2016 02:30:43 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 29 Jul 2016 02:30:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Fri, 29 Jul 2016 17:30:41 +0800 From: "Lu, ShifeiX A" To: Laszlo Ersek , "Wei, David" CC: "edk2-devel@lists.01.org" , "Lu, ShifeiX A" Thread-Topic: [edk2] [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. Thread-Index: AQHR6UFUa/sRhlQGEUSP5nHx3wIoPqAug0oAgACgxGA= Date: Fri, 29 Jul 2016 09:30:41 +0000 Message-ID: <757C127295B34C4F87D5D410F9197317370FCC93@SHSMSX101.ccr.corp.intel.com> References: <89954A0B46707A448411A627AD4EEE3437D7D51C@SHSMSX101.ccr.corp.intel.com> <52c28d1b-32d1-ffcc-228d-c88b12a784f1@redhat.com> In-Reply-To: <52c28d1b-32d1-ffcc-228d-c88b12a784f1@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODk2ZDM2YzgtODdhNS00ZjRiLThlZjktYTE4NzdiMjBhMzc0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikl2SlR2enM0NXB1S3NNWE0yVlVkaXpvZVc5TWQ2NGJLYnErd0ZiSmVxdFU9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 09:30:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Laszlo! I will follow it. Shifei -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Friday, July 29, 2016 3:51 PM To: Wei, David; Lu, ShifeiX A Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. On 07/29/16 04:31, Wei, David wrote: > Reviewed-by: David Wei >=20 >=20 >=20 > Thanks, > David Wei =20 >=20 > Intel SSG BIOS Team I recommend using the new EfiEventGroupSignal() function from UefiLib inste= ad. Please refer to the following commits: ca8f50e88e03 MdePkg/UefiLib: move InternalEmptyFunction to UefiLib.c 772fb7= cb13de MdePkg/UefiLib: introduce EfiEventGroupSignal ff55dd3befb4 IntelFrameworkPkg/FrameworkUefiLib: move InternalEmptyFunction= to UefiLib.c 6212b9481d82 IntelFrameworkPkg/FrameworkUefiLib: implement EfiEventGroupSig= nal dfc9514794fc ArmVirtPkg/PlatformIntelBdsLib: rebase to EfiEventGroupSig= nal 36e8e6992d0c OvmfPkg/PlatformBdsLib: rebase to EfiEventGroupSignal Thanks Laszlo > -----Original Message----- > From: Lu, ShifeiX A > Sent: Friday, July 29, 2016 10:27 AM > To: edk2-devel@lists.01.org > Cc: Wei; Wei, David > Subject: [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. >=20 > According to PI spec,EndOfDxe Event should be signaled before=20 > DxeSmmReadyToLock protocol installation. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: lushifex > --- > .../Library/PlatformBdsLib/BdsPlatform.c | 37 ++++++++++++++++= +++++- > .../Library/PlatformBdsLib/PlatformBdsLib.inf | 3 +- > 2 files changed, 38 insertions(+), 2 deletions(-) >=20 > diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c=20 > b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c > index 195d734..5df3396 100644 > --- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c > +++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c > @@ -1,8 +1,8 @@ > /** @file > =20 > - Copyright (c) 2004 - 2015, Intel Corporation. All rights=20 > reserved.
> + Copyright (c) 2004 - 2016, Intel Corporation. All rights=20 > + reserved.
> = =20 >=20 > This program and the accompanying materials are licensed and made=20 > available under >=20 > the terms and conditions of the BSD License that accompanies this dist= ribution. =20 >=20 > The full text of the license may be found at = =20 >=20 > http://opensource.org/licenses/bsd-license.php. = =20 >=20 > @@ -203,10 +203,29 @@ ShellImageCallback ( { > BdsSetConsoleMode (TRUE); > DEBUG ((EFI_D_INFO, "BdsEntry ShellImageCallback \n")); } > =20 > +/** > + An empty function to pass error checking of CreateEventEx (). > + > + @param Event Event whose notification function is being invoked. > + @param Context Pointer to the notification function's context, > + which is implementation-dependent. > + > +**/ > +STATIC > +VOID > +EFIAPI > +EmptyCallbackFunction ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + return; > +} > + > // > // BDS Platform Functions > // > /** > Platform Bds init. Incude the platform firmware vendor, revision @@=20 > -223,12 +242,28 @@ PlatformBdsInit ( > VOID > ) > { > EFI_STATUS Status; > EFI_EVENT ShellImageEvent; > + EFI_EVENT EndOfDxeEvent; > EFI_GUID ShellEnvProtocol =3D SHELL_ENVIRONMENT_INTERFACE_PROTOCOL; > =20 > + // > + // Signal EndOfDxe PI Event > + // > + Status =3D gBS->CreateEventEx ( > + EVT_NOTIFY_SIGNAL, > + TPL_CALLBACK, > + EmptyCallbackFunction, > + NULL, > + &gEfiEndOfDxeEventGroupGuid, > + &EndOfDxeEvent > + ); > + if (!EFI_ERROR (Status)) { > + gBS->SignalEvent (EndOfDxeEvent); } > + > #ifdef __GNUC__ > SerialPortWrite((UINT8 *)">>>>BdsEntry[GCC]\r\n", 19); > #else > SerialPortWrite((UINT8 *)">>>>BdsEntry\r\n", 14); > #endif > diff --git=20 > a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf=20 > b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf > index 45578e8..c64bab9 100644 > --- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf > +++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf > @@ -1,9 +1,9 @@ > #/** @file > # Component name for module PlatformBootManagerLib # -# Copyright=20 > (c) 2008 - 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2008 - 2016, Intel Corporation. All rights=20 > +reserved.
> # = =20 >=20 > # This program and the accompanying materials are licensed and made=20 > available under >=20 > # the terms and conditions of the BSD License that accompanies this dist= ribution. =20 >=20 > # The full text of the license may be found at = =20 >=20 > # http://opensource.org/licenses/bsd-license.php. = =20 >=20 > @@ -95,10 +95,11 @@ > gEfiMemoryTypeInformationGuid > gEfiCapsuleVendorGuid > gEfiGlobalVariableGuid > gEfiNormalSetupGuid > gEfiPartTypeSystemPartGuid > + gEfiEndOfDxeEventGroupGuid > =20 > [Pcd] > gPlatformModuleTokenSpaceGuid.PcdFlashFvRecovery2Base > gPlatformModuleTokenSpaceGuid.PcdFlashFvMainBase > gPlatformModuleTokenSpaceGuid.PcdFlashFvRecoveryBase >=20 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel