From: "Lu, ShifeiX A" <shifeix.a.lu@intel.com>
To: "Wei, David" <david.wei@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Lu, ShifeiX A" <shifeix.a.lu@intel.com>
Subject: Re: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Fix some GCC build error.
Date: Fri, 12 May 2017 08:34:55 +0000 [thread overview]
Message-ID: <757C127295B34C4F87D5D410F91973176825432F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20170512054716.27924-1-david.wei@intel.com>
Reviewed-by: lushifex <shifeix.a.lu@intel.com>
Shifei
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of zwei4
Sent: Friday, May 12, 2017 1:47 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Fix some GCC build error.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: zwei4 <david.wei@intel.com>
---
Platform/BroxtonPlatformPkg/BuildBios.sh | 2 +-
.../DxeFspWrapperPlatformResetLib/DxeFspWrapperPlatformResetLib.c | 2 +-
.../Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c | 4 ++--
Platform/BroxtonPlatformPkg/PlatformPkgX64Gcc.dsc | 2 +-
.../SampleCode/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Platform/BroxtonPlatformPkg/BuildBios.sh b/Platform/BroxtonPlatformPkg/BuildBios.sh
index 8702fbeaa..3963c887a 100644
--- a/Platform/BroxtonPlatformPkg/BuildBios.sh
+++ b/Platform/BroxtonPlatformPkg/BuildBios.sh
@@ -211,7 +211,7 @@ fi
## Additional EDK Build Setup/Configuration
##**********************************************************************
echo "Ensuring correct build directory is present for GenBiosId..."
-ACTIVE_PLATFORM=$PLATFORM_PACKAGE/PlatformPkgX64.dsc
+ACTIVE_PLATFORM=$PLATFORM_PACKAGE/PlatformPkgX64Gcc.dsc
#TOOL_CHAIN_TAG=GCC47
MAX_CONCURRENT_THREAD_NUMBER=1
sed -i '/^ACTIVE_PLATFORM/d' $WORKSPACE/Conf/target.txt diff --git a/Platform/BroxtonPlatformPkg/Common/FspSupport/Library/DxeFspWrapperPlatformResetLib/DxeFspWrapperPlatformResetLib.c b/Platform/BroxtonPlatformPkg/Common/FspSupport/Library/DxeFspWrapperPlatformResetLib/DxeFspWrapperPlatformResetLib.c
index 4474eafaf..b7b57c517 100644
--- a/Platform/BroxtonPlatformPkg/Common/FspSupport/Library/DxeFspWrapperPlatformResetLib/DxeFspWrapperPlatformResetLib.c
+++ b/Platform/BroxtonPlatformPkg/Common/FspSupport/Library/DxeFspWrappe
+++ rPlatformResetLib/DxeFspWrapperPlatformResetLib.c
@@ -33,7 +33,7 @@ CallFspWrapperResetSystem (
IN UINT32 ResetType
)
{
- EFI_RESET_TYPE EfiResetType;
+ EFI_RESET_TYPE EfiResetType = EfiResetCold;
switch (ResetType) {
case FSP_STATUS_RESET_REQUIRED_COLD:
diff --git a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c
index 630c2c1d1..d7ef4970b 100644
--- a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c
+++ b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMem
+++ Pei/PlatformInitPreMem.c
@@ -893,7 +893,7 @@ PlatformInitPreMemEntryPoint (
DRAM_POLICY_PPI *DramPolicy;
EFI_PEI_PPI_DESCRIPTOR *NewPeiPpiDescriptor;
EFI_BOOT_MODE BootMode;
- CarMapStruc *CarMap;
+ CarMapStruc *CarMap = NULL;
SYSTEM_CONFIGURATION SystemConfiguration;
UINTN VariableSize;
EFI_PEI_HOB_POINTERS Hob;
@@ -938,7 +938,7 @@ PlatformInitPreMemEntryPoint (
&gBoardPreMemInitPpiGuid,
Instance,
&PeiPpiDescriptor,
- &BoardPreMemInitPpi
+ (VOID **)&BoardPreMemInitPpi
);
if (Status == EFI_NOT_FOUND) {
diff --git a/Platform/BroxtonPlatformPkg/PlatformPkgX64Gcc.dsc b/Platform/BroxtonPlatformPkg/PlatformPkgX64Gcc.dsc
index 1339b44b2..42f068a38 100644
--- a/Platform/BroxtonPlatformPkg/PlatformPkgX64Gcc.dsc
+++ b/Platform/BroxtonPlatformPkg/PlatformPkgX64Gcc.dsc
@@ -177,5 +177,5 @@
#[BuildOptions.Common]
[BuildOptions.Common.EDKII]
- !include PlatformDsc/BuildOptions.EDKII.dsc
+ !include PlatformDsc/BuildOptions.EDKII.Gcc.dsc
diff --git a/Silicon/BroxtonSoC/BroxtonSiPkg/SampleCode/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/Silicon/BroxtonSoC/BroxtonSiPkg/SampleCode/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 9fcb55197..316e5c745 100644
--- a/Silicon/BroxtonSoC/BroxtonSiPkg/SampleCode/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/Silicon/BroxtonSoC/BroxtonSiPkg/SampleCode/MdeModulePkg/Universal/
+++ Variable/RuntimeDxe/Variable.c
@@ -1122,7 +1122,7 @@ Reclaim (
VARIABLE_POINTER_TRACK VarErrFlagPtr;
Status = EFI_SUCCESS;
-
+ VariableSize = 0;
UpdatingVariable = NULL;
UpdatingInDeletedTransition = NULL;
--
2.11.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-05-12 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 5:47 [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Fix some GCC build error zwei4
2017-05-12 8:34 ` Lu, ShifeiX A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757C127295B34C4F87D5D410F91973176825432F@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox