From: "Lu, Shifei A" <shifei.a.lu@intel.com>
To: "Shi, Steven" <steven.shi@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
"Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"Lu, Shifei A" <shifei.a.lu@intel.com>
Subject: Re: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache
Date: Fri, 10 May 2019 05:12:40 +0000 [thread overview]
Message-ID: <757C127295B34C4F87D5D410F919731772E8AA93@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190509032119.2084-3-steven.shi@intel.com>
Reviewed-by: Lu, shifei <shifei.a.lu@intel.com>
> -----Original Message-----
> From: Shi, Steven
> Sent: Thursday, May 9, 2019 11:21 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Lu, Shifei A
> <shifei.a.lu@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build
> to support Binary Cache
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1785
>
> Extend the options in the Purley build batch file to support
> Binary Cache produce and consume switch.
> ---
> .../PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 18
> ++++++++++++++++--
> .../BoardMtOlympus/prebuild.bat | 4 ++--
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> index a66d19e66e..eda749af36 100644
> --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> @@ -16,6 +16,11 @@ REM Run setlocal to take a snapshot of the
> environment variables. endlocal is c
> setlocal
> set SCRIPT_ERROR=0
>
> +@if not defined BINARY_CACHE_PATH (
> + echo Info: BINARY_CACHE_PATH is empty, use BinCache as default
> + SET BINARY_CACHE_PATH=BinCache
> +)
> +
> REM ---- Do NOT use :: for comments Inside of code blocks() ----
>
> ::*********************************************************
> *************
> @@ -34,6 +39,15 @@ if /I "%1"=="clean" (
> goto :EOF
> )
>
> +if /I "%1"=="cache-produce" (
> + set BINARY_CACHE_CMD_LINE= --hash --binary-
> destination=%BINARY_CACHE_PATH%
> +)
> +
> +if /I "%1"=="cache-consume" (
> + set BINARY_CACHE_CMD_LINE= --hash --binary-
> source=%BINARY_CACHE_PATH%
> +)
> +
> +
> shift
> GOTO :parseCmdLine
>
> @@ -92,8 +106,8 @@ echo Build Start
> echo.
> echo --------------------------------------------------------------------
> echo.
> -echo build %BUILD_CMD_LINE% --
> log=%BUILD_LOG% %BUILD_REPORT_FLAGS%
> -call build %BUILD_CMD_LINE% --
> log=%BUILD_LOG% %BUILD_REPORT_FLAGS%
> +echo build %BUILD_CMD_LINE% --
> log=%BUILD_LOG% %BUILD_REPORT_FLAGS% %BINARY_CACHE_CMD_LINE%
> +call build %BUILD_CMD_LINE% --
> log=%BUILD_LOG% %BUILD_REPORT_FLAGS% %BINARY_CACHE_CMD_LINE%
> echo --------------------------------------------------------------------
> echo.
> echo Build End
> diff --git
> a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
> b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
> index 81a9634d51..880e6417ac 100644
> --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
> +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
> @@ -188,8 +188,8 @@ set PRE_BUILD_CMD_LINE=%BUILD_CMD_LINE% -D
> MAX_SOCKET=%MAX_SOCKET%
> set PRE_BUILD_LOG=%WORKSPACE%\Build\prebuild.log
> set PRE_BUILD_REPORT=%WORKSPACE%\Build\preBuildReport.txt
>
> -echo build %PRE_BUILD_CMD_LINE% -
> m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% --
> log=%PRE_BUILD_LOG%
> -call build %PRE_BUILD_CMD_LINE% -
> m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% --
> log=%PRE_BUILD_LOG%
> +echo build %PRE_BUILD_CMD_LINE% -
> m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% --
> log=%PRE_BUILD_LOG% %BINARY_CACHE_CMD_LINE%
> +call build %PRE_BUILD_CMD_LINE% -
> m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% --
> log=%PRE_BUILD_LOG% %BINARY_CACHE_CMD_LINE%
> if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
>
> @REM PSYS == FIX0
> --
> 2.17.1.windows.2
next prev parent reply other threads:[~2019-05-10 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 3:21 [PATCH 0/2] Add batch option to support build Binary Cache Steven Shi
2019-05-09 3:21 ` [PATCH 1/2] KabylakeOpenBoardPkg/KabylakeRvp3: Extend build to support " Steven Shi
2019-05-09 3:21 ` [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: " Steven Shi
2019-05-10 5:12 ` Lu, Shifei A [this message]
2019-05-10 5:43 ` Chiu, Chasel
2019-05-09 3:37 ` [PATCH 0/2] Add batch option to support build " Liming Gao
2019-05-09 4:07 ` Steven Shi
2019-05-10 17:14 ` Kubacki, Michael A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757C127295B34C4F87D5D410F919731772E8AA93@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox