From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: shifei.a.lu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 09 May 2019 22:12:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 22:12:44 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 09 May 2019 22:12:44 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 22:12:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 22:12:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0415.000; Fri, 10 May 2019 13:12:41 +0800 From: "Lu, Shifei A" To: "Shi, Steven" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Gao, Liming" , "Bi, Dandan" , "Kubacki, Michael A" , "Lu, Shifei A" Subject: Re: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache Thread-Topic: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache Thread-Index: AQHVBhZgQYQogANGykCDbAIztpJdXKZj0Evw Date: Fri, 10 May 2019 05:12:40 +0000 Message-ID: <757C127295B34C4F87D5D410F919731772E8AA93@SHSMSX101.ccr.corp.intel.com> References: <20190509032119.2084-1-steven.shi@intel.com> <20190509032119.2084-3-steven.shi@intel.com> In-Reply-To: <20190509032119.2084-3-steven.shi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shifei.a.lu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Lu, shifei > -----Original Message----- > From: Shi, Steven > Sent: Thursday, May 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Lu, Shifei A > ; Gao, Liming ; Bi, Dandan > ; Kubacki, Michael A > Subject: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build > to support Binary Cache >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1785 >=20 > Extend the options in the Purley build batch file to support > Binary Cache produce and consume switch. > --- > .../PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 18 > ++++++++++++++++-- > .../BoardMtOlympus/prebuild.bat | 4 ++-- > 2 files changed, 18 insertions(+), 4 deletions(-) >=20 > diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > index a66d19e66e..eda749af36 100644 > --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > @@ -16,6 +16,11 @@ REM Run setlocal to take a snapshot of the > environment variables. endlocal is c > setlocal > set SCRIPT_ERROR=3D0 >=20 > +@if not defined BINARY_CACHE_PATH ( > + echo Info: BINARY_CACHE_PATH is empty, use BinCache as default > + SET BINARY_CACHE_PATH=3DBinCache > +) > + > REM ---- Do NOT use :: for comments Inside of code blocks() ---- >=20 > ::********************************************************* > ************* > @@ -34,6 +39,15 @@ if /I "%1"=3D=3D"clean" ( > goto :EOF > ) >=20 > +if /I "%1"=3D=3D"cache-produce" ( > + set BINARY_CACHE_CMD_LINE=3D --hash --binary- > destination=3D%BINARY_CACHE_PATH% > +) > + > +if /I "%1"=3D=3D"cache-consume" ( > + set BINARY_CACHE_CMD_LINE=3D --hash --binary- > source=3D%BINARY_CACHE_PATH% > +) > + > + > shift > GOTO :parseCmdLine >=20 > @@ -92,8 +106,8 @@ echo Build Start > echo. > echo -------------------------------------------------------------------= - > echo. > -echo build %BUILD_CMD_LINE% -- > log=3D%BUILD_LOG% %BUILD_REPORT_FLAGS% > -call build %BUILD_CMD_LINE% -- > log=3D%BUILD_LOG% %BUILD_REPORT_FLAGS% > +echo build %BUILD_CMD_LINE% -- > log=3D%BUILD_LOG% %BUILD_REPORT_FLAGS% %BINARY_CACHE_CMD_LINE% > +call build %BUILD_CMD_LINE% -- > log=3D%BUILD_LOG% %BUILD_REPORT_FLAGS% %BINARY_CACHE_CMD_LINE% > echo -------------------------------------------------------------------= - > echo. > echo Build End > diff --git > a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > index 81a9634d51..880e6417ac 100644 > --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > @@ -188,8 +188,8 @@ set PRE_BUILD_CMD_LINE=3D%BUILD_CMD_LINE% -D > MAX_SOCKET=3D%MAX_SOCKET% > set PRE_BUILD_LOG=3D%WORKSPACE%\Build\prebuild.log > set PRE_BUILD_REPORT=3D%WORKSPACE%\Build\preBuildReport.txt >=20 > -echo build %PRE_BUILD_CMD_LINE% - > m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% -- > log=3D%PRE_BUILD_LOG% > -call build %PRE_BUILD_CMD_LINE% - > m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% -- > log=3D%PRE_BUILD_LOG% > +echo build %PRE_BUILD_CMD_LINE% - > m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% -- > log=3D%PRE_BUILD_LOG% %BINARY_CACHE_CMD_LINE% > +call build %PRE_BUILD_CMD_LINE% - > m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% -- > log=3D%PRE_BUILD_LOG% %BINARY_CACHE_CMD_LINE% > if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL% >=20 > @REM PSYS =3D=3D FIX0 > -- > 2.17.1.windows.2