Re: [PATCH v3 13/15] ArmVirtPkg: Package dependency for MC146818 RTC

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 6/24/20 3:34 PM, Sami Mujawar wrote:
> Kvmtool emulates a MC146818 RTC controller in the
> MMIO space. To support this the MC146818 RTC driver
> PcatRealTimeClockRuntimeDxe has been updated to
> support MMIO accesses. PCDs for RTC Index and
> Target register base addresses in the MMIO space
> have been introduced. The KvmtoolRtcFdtClientLib
> reads the MC146818 RTC MMIO base address region
> from the Kvmtool device tree and updates the
> Index and Target register PCDs.
> 
> As these PCDs are defined in PcAtChipsetPkg.dec,
> this patch updates the CI script to add this
> dependency.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>

Not sure what this does, but it looks ok to me

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>


> ---
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index 4553725ee5285d08a25f5e736f6b1cd25f4ba3e9..554ffb2609b25b46caa1fee8e994e2e6ea51f18f 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -5,6 +5,8 @@
>   # used for code analysis.
>   #
>   # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, ARM Limited. All rights reserved.
> +#
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   ##
>   {
> @@ -34,6 +36,7 @@
>               "OvmfPkg/OvmfPkg.dec",
>               "EmbeddedPkg/EmbeddedPkg.dec",
>               "ArmPlatformPkg/ArmPlatformPkg.dec",
> +            "PcAtChipsetPkg/PcAtChipsetPkg.dec",
>               "SecurityPkg/SecurityPkg.dec",
>               "ShellPkg/ShellPkg.dec"  #Is this ok?
>           ],
>