From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.11396.1593094143072129071 for ; Thu, 25 Jun 2020 07:09:03 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD1D4C0A; Thu, 25 Jun 2020 07:09:02 -0700 (PDT) Received: from [192.168.1.69] (unknown [10.37.8.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CC523F73C; Thu, 25 Jun 2020 07:09:01 -0700 (PDT) Subject: Re: [PATCH v3 13/15] ArmVirtPkg: Package dependency for MC146818 RTC To: Sami Mujawar , devel@edk2.groups.io Cc: leif@nuviainc.com, lersek@redhat.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com References: <20200624133458.61920-1-sami.mujawar@arm.com> <20200624133458.61920-14-sami.mujawar@arm.com> From: "Ard Biesheuvel" Message-ID: <7584aa0e-e7a9-0c63-8ccc-e69102f2655c@arm.com> Date: Thu, 25 Jun 2020 16:08:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200624133458.61920-14-sami.mujawar@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/24/20 3:34 PM, Sami Mujawar wrote: > Kvmtool emulates a MC146818 RTC controller in the > MMIO space. To support this the MC146818 RTC driver > PcatRealTimeClockRuntimeDxe has been updated to > support MMIO accesses. PCDs for RTC Index and > Target register base addresses in the MMIO space > have been introduced. The KvmtoolRtcFdtClientLib > reads the MC146818 RTC MMIO base address region > from the Kvmtool device tree and updates the > Index and Target register PCDs. > > As these PCDs are defined in PcAtChipsetPkg.dec, > this patch updates the CI script to add this > dependency. > > Signed-off-by: Sami Mujawar Not sure what this does, but it looks ok to me Acked-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtPkg.ci.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml > index 4553725ee5285d08a25f5e736f6b1cd25f4ba3e9..554ffb2609b25b46caa1fee8e994e2e6ea51f18f 100644 > --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml > +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml > @@ -5,6 +5,8 @@ > # used for code analysis. > # > # Copyright (c) Microsoft Corporation > +# Copyright (c) 2020, ARM Limited. All rights reserved. > +# > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > { > @@ -34,6 +36,7 @@ > "OvmfPkg/OvmfPkg.dec", > "EmbeddedPkg/EmbeddedPkg.dec", > "ArmPlatformPkg/ArmPlatformPkg.dec", > + "PcAtChipsetPkg/PcAtChipsetPkg.dec", > "SecurityPkg/SecurityPkg.dec", > "ShellPkg/ShellPkg.dec" #Is this ok? > ], >