From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web12.3959.1648620281934873620 for ; Tue, 29 Mar 2022 23:04:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=rS/IpfFn; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22U4qgJ4015805; Wed, 30 Mar 2022 06:04:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UlJ4aB7d0JmY3Up+1255HH8xNrXtfQzMzRy5ZKaFEmk=; b=rS/IpfFnraTJE+qGHwmAUHmr2fdJbvT57vWK2OMFEVdRMj10i/mgQb884GqMc5JWrnO/ uih7WmVdT1oiaW3ehI89iKGj1a4Uk5bbjRiUKI9CuJ9C8GPlDDyiFY6bVrDr5NIoyt+7 AbdxjvvVtgUYgscvvfQvjt6BoOwO/A3El/60ozlcoFebfMdEC8DeZdBRduTI83C4rzx7 djWLP+hFtWwMqMy997mGVHAHyw8cdmeho9hh6WwK0/qpZnuwRkyWX66K1VCFSRL5kkVS mDSIDz2gZdcv2EvWCOAYUpIVC5fQUh7SCX1yBAbfsNBAjpo3+3SMrUhuFkNw7HtT3zbI Ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3f405ax6qr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 06:04:39 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22U5KDUD030560; Wed, 30 Mar 2022 06:04:39 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0b-001b2d01.pphosted.com with ESMTP id 3f405ax6qe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 06:04:39 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22U63lfP004555; Wed, 30 Mar 2022 06:04:38 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma03wdc.us.ibm.com with ESMTP id 3f1tf9u109-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 06:04:38 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22U64bN628443054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Mar 2022 06:04:37 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 78E37112069; Wed, 30 Mar 2022 06:04:37 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4A67C112062; Wed, 30 Mar 2022 06:04:35 +0000 (GMT) Received: from [9.160.79.229] (unknown [9.160.79.229]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 30 Mar 2022 06:04:35 +0000 (GMT) Message-ID: <7585badc-63d5-4195-760c-3cc3665795e4@linux.ibm.com> Date: Wed, 30 Mar 2022 09:04:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation To: Gerd Hoffmann , Brijesh Singh Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Tobin Feldman-Fitzthum , Dov Murik References: <20220328184530.86797-1-dovmurik@linux.ibm.com> <20220328184530.86797-3-dovmurik@linux.ibm.com> <20220330052029.4fuzbca2364nm7fg@sirius.home.kraxel.org> From: "Dov Murik" In-Reply-To: <20220330052029.4fuzbca2364nm7fg@sirius.home.kraxel.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BdEN34JpWpmgg4aHvaYtXviuMpjQsVZs X-Proofpoint-ORIG-GUID: GdrqBG3C9_sYPZr9kqFdjFNW6RyeTFUd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-30_02,2022-03-29_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 mlxlogscore=999 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203300028 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/03/2022 8:20, Gerd Hoffmann wrote: > Hi, > >> Check if that page is defined; if it is, skip it in the metadata list. >> In such case, VMM should fill the page with the hashes content, or >> explicitly update it as a zero page (if kernel hashes are not used). > > Is it an option to just skip the page unconditionally? > > I think in the OvmfPkgX64 build the page is not used, so it probably > doesn't matter whenever it is included or not, and it would make things > a bit less confusing ... > Brijesh, What would happen if we change this: %define SNP_SEC_MEM_BASE_DESC_3 (CPUID_BASE + CPUID_SIZE) to: %define SNP_SEC_MEM_BASE_DESC_3 (FixedPcdGet32 (PcdOvmfSecPeiTempRamBase)) in OvmfPkg/ResetVector/ResetVector.nasmb ? It means that the page starting at MEMFD_BASE_ADDRESS+0x00F000 (that is, the page that follows the SNP CPUID page) will not be pre-validated by QEMU. I'm not sure what are the implications. -Dov