From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 25 Jul 2019 12:27:07 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F5335D5EE; Thu, 25 Jul 2019 19:27:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-178.ams2.redhat.com [10.36.116.178]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F50819C68; Thu, 25 Jul 2019 19:27:04 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] To: Leif Lindholm , "Gao, Liming" Cc: "devel@edk2.groups.io" , "Kinney, Michael D" , Ard Biesheuvel , "Wang, Jian J" , "Ye, Ting" References: <20190722103755.GA11541@bivouac.eciton.net> <591319a9-eceb-ab39-0ec0-ccd2530b0e58@redhat.com> <20190723090644.GD11541@bivouac.eciton.net> <20190723121940.GH11541@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B11C4@SHSMSX104.ccr.corp.intel.com> <20190723132543.GI11541@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B2125@SHSMSX104.ccr.corp.intel.com> <20190724170050.GU11541@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <759d628c-fc79-a50b-6127-5de3467f8fda@redhat.com> Date: Thu, 25 Jul 2019 21:27:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190724170050.GU11541@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 25 Jul 2019 19:27:07 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/24/19 19:00, Leif Lindholm wrote: > On Wed, Jul 24, 2019 at 03:17:56PM +0000, Gao, Liming wrote: >>> Would it be feasible to update the --hash functionality to make use of >>> the include dependencies extracted from the source files? (Clearly, we >>> know when the source files change, so we would also know when we would >>> need to re-run the dependency search.) >> >> The design is to save the step to extract the dependencies from the source files. >> I can further collect the build performance to be taken on the dependencies extraction >> from the source files, and decide whether take this way. Another simple way is >> to calculate all source files in module directory and make sure there is no file missing for --hash option. >> >>> >>> If not, I think we should make the explicit listing of .h files >>> in .inf mandatory, triggering a build failure when not the case. >>> >>> If it is, then I think we should make it explicitly banned to list .h >>> files in .inf. (If there is no other dependency, such as doxygen, also >>> making use of .inf listings of .h files.) >> >> I know edk2 also has PI Packaging UPT. PI packaging requires all source >> files are listed in module INF file. Otherwise, some source files will be missed >> in the packaging, and can't be rollback. > > OK, this means we should update the documentation to be crystal clear > that .h files need to be listed too. > > I am OK to keep the warning enabled for now. But I would also wish > that we start planning for making it an error at some point in the > future. Could you please file a Feature Request for that (i.e. s/warning/error/) in the Bugzilla? Thanks! Laszlo