From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in4.apple.com (mail-out4.apple.com [17.151.62.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 903D9803A8 for ; Wed, 15 Mar 2017 08:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1489593259; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hkhpPYTGFL3xSDdl1tsxZ/3wE7bcJ4s0e6gWB67ijOs=; b=ecNC6gYqHsLyLcMUMEOLFWqFX9i6V3PjXNOQBpLHkbqlhH1zjznXsNN5Dx9wBfeY qxtl7xi6qkTu3IvCdQUlvnp6urWtTm80CeVOVfBbay85AedYDwNoRLKd20StLSPP MP7ZCe+/dHNMSjuVufpb9kpzISiaatQr+5waEJxNSY9TfJfm8ekAER9NfyXIV/3W yJuUumLwREbL8EjYb1PAvMsRrhelUNfTBZ06GQzUqiR2GZWC5xALBOHW7R5IHGR7 Jjl8w60pzBK1eoOdaOiFACepilRgintZSEx8g/FzdaMgwjPjF8Q0GQYz4xKcde/O 0p6TLtLCD9Sx4HCU68QJJA==; Received: from relay5.apple.com (relay5.apple.com [17.128.113.88]) by mail-in4.apple.com (Apple Secure Mail Relay) with SMTP id FF.C2.24168.BA369C85; Wed, 15 Mar 2017 08:54:19 -0700 (PDT) X-AuditID: 11973e12-62fd39a000005e68-8b-58c963abfc80 Received: from nwk-mmpp-sz12.apple.com (nwk-mmpp-sz12.apple.com [17.128.115.204]) by relay5.apple.com (Apple SCV relay) with SMTP id F9.5A.06491.AA369C85; Wed, 15 Mar 2017 08:54:19 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.47.209] (unknown [17.153.47.209]) by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170210 64bit (built Feb 10 2017)) with ESMTPSA id <0OMV006QS5IHKP00@nwk-mmpp-sz12.apple.com>; Wed, 15 Mar 2017 08:54:18 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: <75A865F3-53E6-4C54-91A0-46A32E3CAB84@apple.com> Date: Wed, 15 Mar 2017 08:54:17 -0700 In-reply-to: <385c68bb-4a3f-e586-f62b-9dd9f9c6490b@redhat.com> Cc: Feng Tian , Michael Zimmermann , Liming Gao , "edk2-devel@lists.01.org" , Star Zeng To: Laszlo Ersek References: <426920F0-4266-4BB2-BF19-40715A0F1C01@apple.com> <385c68bb-4a3f-e586-f62b-9dd9f9c6490b@redhat.com> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsUi2FAYobs6+WSEwaPlAhbr9nxjt5i0m91i 2bEdLBYr7m1gt5g79Smrxb5eawc2j52z7rJ7LN7zkslj0oXHzB7v911lC2CJ4rJJSc3JLEst 0rdL4MpYu3USS8HXZ4wVu3c3MTYw9pxg7GLk5JAQMJHY0PKTtYuRi0NIYC+jxM1JK+ESfZeu MkMkDjFK/O28BpbgFRCU+DH5HguIzSwQJvHj1T12iKKJTBIb21+AJYQFxCXendnEDGKzCShL rJj/gR2i2UZi2rLPrBA1thLNx2awgdgsAqoSXxvvMoHYnAJ2Ele/PmMDGcoscIlR4uGOM2DN IgIqErMnPGCC2PaWUWLDlItAJ3EA3SorMfuXF0hcQuAzm8SpuTPYJzAKzUJy7Swk10LYWhLf H7UCxTmAbHmJg+dlIcKaEs/ufYIq0ZZ48u4C6wJGtlWMQrmJmTm6mXkmeokFBTmpesn5uZsY QbE03U5oB+OpVVaHGAU4GJV4eF/4n4wQYk0sK67MPcQozcGiJM7Lv/hEhJBAemJJanZqakFq UXxRaU5q8SFGJg5OqQZGsXTN434SauEm+Uf+P1muvJh9auX1mVpVple8HF6neM/1cozSXv2k 3v+1tfHJU813rfa/Ffx3d15Zy5tPlz4ppizXmnX3/jHXqmSjjgcOjhr3PQPVJeUDTBK864WP Lva7VB+z3kPZP/fCI5/0eZtZb2jbf/iyfM7FXPYMq4stbdKbkn/c1PqpxFKckWioxVxUnAgA Br1ub4YCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsUi2FB8Rnd18skIg4MvGS3W7fnGbjFpN7vF smM7WCxW3NvAbjF36lNWi3291g5sHjtn3WX3WLznJZPHpAuPmT3e77vKFsASxWWTkpqTWZZa pG+XwJWxduskloKvzxgrdu9uYmxg7DnB2MXIySEhYCLRd+kqcxcjF4eQwCFGib+d18ASvAKC Ej8m32MBsZkFwiR+vLrHDlE0kUliY/sLsISwgLjEuzObmEFsNgFliRXzP7BDNNtITFv2mRWi xlai+dgMNhCbRUBV4mvjXSYQm1PATuLq12dsIEOZBS4xSjzccQasWURARWL2hAdMENveMkps mHIR6CQOoFtlJWb/8prAyD8LyYGzkBwIYWtJfH/UChTnALLlJQ6el4UIa0o8u/cJqkRb4sm7 C6wLGNlWMQoUpeYkVprqJRYU5KTqJefnbmIEh35hxA7G/8usDjEKcDAq8fBO8D0ZIcSaWFZc mQsMJQ5mJRFejjigEG9KYmVValF+fFFpTmrxIcaJjEBfTmSWEk3OB0ZmXkm8oYmJgYmxsZmx sbmJOS2FlcR5f2kBXSSQnliSmp2aWpBaBHMUEwenVAPjGc4Pv+bfL92dsUj1/Zo/C1bmxU0U X3RA/YvpTdGbFz96b5Zo8nV+Fjbh846g2afirwkIJWWp6gvbTMi0lGM8Zxbxmt96b8bjQvH9 rlmvVrzZsrAum11TucBgjeM8v0iplEdqE+wtSvTEwzZ9aJcveh6tPy93/4Ef99KOv419OME4 1cVetLBZiaU4I9FQi7moOBEAXPdPDvACAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: how to load drivers from additional FV's? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 15:54:19 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Mar 15, 2017, at 8:38 AM, Laszlo Ersek wrote: > > On 03/15/17 16:13, Andrew Fish wrote: >> >>> On Mar 15, 2017, at 8:07 AM, Laszlo Ersek wrote: >>> >>> On 03/15/17 13:23, Michael Zimmermann wrote: >>>> I'm trying to add another FV section FVMAIN_COMPACT so I can keep >>>> Platform specific drivers in a separate, included fdf. >>>> >>>> I did this: >>>> FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { >>>> SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF >>>> PROCESSING_REQUIRED = TRUE { >>>> SECTION FV_IMAGE = FVMAIN >>>> SECTION FV_IMAGE = FVMAINPLATFORM >>>> } >>>> } >>>> >>>> The image builds file and using uefitool I can verify that the new FV >>>> is inside the compressed section. >>>> But none of the drivers gets discovered/loaded and I get 'Protocol not >>>> present!!' errors. >>> >>> The FVs need to be exposed to the DXE core via FV HOBs. See >>> - 9.8.5 "Firmware Volume HOBs" in Volume 2 of the Platform Init 1.5 >>> spec, >>> - and more importantly, 5.7 "Firmware Volume HOB" in Volume 3 of the >>> same. >>> >>> You can use the BuildFvHob() function for this. >>> >>> If the firmware volume contains PEIMs (... as well), then it has to be >>> exposed to the PEI core too, I think. I think the >>> PeiServicesInstallFvInfoPpi() function can be used for that. (See 3.3 >>> "PEI" in Volume 3 of the PI spec.) >>> >>> ... I used the PeiFvInitialization() function in >>> OvmfPkg/PlatformPei/Fv.c as a "cheat sheet" for the above. >>> >> >> Laszlo, >> >> I think this case is an FV that is compressed and nested in another FV that is discovered. I think the issues is multiple FV Sections in an FV file are not currently supported. > > In OVMF we do the same: > > FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { > SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE { > # > # These firmware volumes will have files placed in them uncompressed, > # and then both firmware volumes will be compressed in a single > # compression operation in order to achieve better overall compression. > # > SECTION FV_IMAGE = PEIFV > SECTION FV_IMAGE = DXEFV > } > } > > "OvmfPkg/Sec/SecMain.c" decompresses the compressed FFS file into memory -- which is special to OVMF, i.e. the fact that there is writeable memory in SEC --, then jumps to the PEI entry point. PlatformPei then exposes DXEFV to the PEI core (for loading the DXE core AIUI) and to the DXE core as well (for loading DXE modules). > > The multiple FV sections in the FFS file are not discovered automatically. First, the OVMF build process saves the final (= decompressed) in-memory locations of the nested FVs into PCDs. Second, in DecompressMemFvs(), the SEC module decompresses the outer, compressed, FFS file, then locates the embedded FVs manually with FindFfsSectionInstance(), then moves the decompressed FVs individually to their pre-recorded locations. > > In Michael's case, I think the same should be possible -- since FVMAIN is running for him, the outer, compressed file must already be decompressed (in full) to some temporary buffer in memory. If he can find, manually, the second section (with the embedded FVMAINPLATFORM firmware volume in it) in that area, then he can also expose it to the DXE core, I believe. > Laszlo, The DXE Core will dispatch FVs with Depex "automagically" but only one FV_IMAGE Section per FV_IMAGE file. So one workaround would be to add a 2nd FV_IMAGE file that contains the 2nd FV in the 1st FV_IMAGE Section. Also I'm not sure if the outer FV is compressed, but compressing compressed data usually does not end well as the algorithms leverage entropy. It is better to just compress the outer FV and have everything else uncompressed and let it all get compressed together. This also helps as there will be common dictionary entries so compressing as much data as possible in one shot usually works better. So for example if the outer FV is compressed it may have a dictionary entry that represents CopyMem, and it can represent that pattern with a small number of bits. Doing compression multiple times causes duplication as each compressed image has one copy of CopyMem (massive over simplification). Also if you compress a nested FV then the CopyMem pattern does not exist in the compressed data, and since the compressed data is more random it is hard to find patterns to compress, so it hurts the compression of the outer FV. Thanks, Andrew Fish > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel