From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mx.groups.io with SMTP id smtpd.web08.1232.1657845550177362545 for ; Thu, 14 Jul 2022 17:39:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SydK7hjj; spf=pass (domain: gmail.com, ip: 209.85.210.177, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f177.google.com with SMTP id y9so3287580pff.12 for ; Thu, 14 Jul 2022 17:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Row8jDzOqxx54rNFTt5nmJ/D0HY8b0nLIevBtSTjrd8=; b=SydK7hjjbnEbVHgfK35gYwi3/QZjmAP6Zup7HtKbcpvWmwrJIoZBY/k0ixqkGWLuL+ 1OlbVgm5fhpZTHOTlRmduG1+ECwa/ouFQTenPShdkyNvSf3XF9f+xDzPWKNJA0Lww3OW 9adfUYNBJCTtr/W1dJB/ZZhxKKE+6y36PwN7XI/fGlhEbfwTDcFi1/M4D2e1dErLQ1TF DD1JNvn1EyRqzWMPkHiEw+30MQQ8JIVcNw4DrZwJi4H7DC0nynAI/yBE+7QjtD0hU+5h gtucJv5LcSUa3YzIwDtTZYa2TsRdm+DZEMaVnNcS9TPDQa8sGOd6ULiDIe0/b9p8+Hf3 NXMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Row8jDzOqxx54rNFTt5nmJ/D0HY8b0nLIevBtSTjrd8=; b=Lmydb0zBUgoGvHCtTiA/EjWLmcY7qP5bKcRzoVv/MU/l6Z7esZWrHWPxk5kzlsBj0q 9QeWdfOhQKNhBjLaj7qUrvij9AymyW8ItT5GxgdpudNk5ItFNumxlM9AthGtNst2lrd+ 2bu8Hi3Uhjp5s4hAN97To/YynsPDnqBkff4q3ScQnquilAEsLfAJk9P+UVqKkmNdZC95 CjPDnZJ0xa8pV5ZDDmZAnZ3JzsZX43841LTOmoU9i0sQe/4jQZVOb3d9H1Nr4jJIMflu Ti2KKd2QQCpeZcIqo1M3BRotvvdwSsELJCIGYb6ZpOouqiFMMLw+F5iHUsuXjB6kFe9p eUfw== X-Gm-Message-State: AJIora8S/+mxEtLhgJeEI7qwDGmogvlOeex2Mu5/Gxuz9a+HOBPH6RCs 4JjQPJxUNtBBVrBlkDG+aGdhtSfWoKg= X-Google-Smtp-Source: AGRyM1vAAp1REiXWz99FlPX2KwD0GM9yXFQe1Ih3qbQcKRhL3Cu5YpFmAVm8k7plhDhU5/QhsAtlRg== X-Received: by 2002:a63:6b0a:0:b0:40d:ffa6:85c5 with SMTP id g10-20020a636b0a000000b0040dffa685c5mr9637642pgc.327.1657845549237; Thu, 14 Jul 2022 17:39:09 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:691e:d179:7615:ec6a? ([2001:4898:80e8:b:e935:d179:7615:ec6a]) by smtp.gmail.com with ESMTPSA id t186-20020a625fc3000000b00528c3ad8e09sm2342684pfb.66.2022.07.14.17.39.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 17:39:08 -0700 (PDT) Message-ID: <75c27d79-51ee-5521-6a0d-98b97ea11cfb@gmail.com> Date: Thu, 14 Jul 2022 17:39:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [edk2-staging][PATCH Kun,v1 0/7] Add TPM subclass definition To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Yao, Jiewen" , "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" , Andrew Fish , Leif Lindholm , "Gao, Liming" , "Liu, Zhiguang" References: <17018D5A99B7EABB.31468@groups.io> From: "Kun Qin" In-Reply-To: <17018D5A99B7EABB.31468@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi SecurityPkg maintainers and EDK2 stewards, The updated patch series was sent here: https://edk2.groups.io/g/devel/message/91330 Please let me know if there is any other feedback on them. Thanks, Kun On 7/13/2022 6:19 PM, Kun Qin via groups.io wrote: > Thanks, Mike. I will drop the applicable code change and send a v2 > series shortly. > > Regards, > Kun > > On 7/13/2022 5:47 PM, Michael D Kinney wrote: >> Hi Kun, >> >> I would prefer to focus on the spec issue with this patch set and only >> update DEC and .H file. >> >> The idea of removing all the status code related PCDs and updating >> all the >> source files to use the #defines is a different change.  And that >> change may >> impact many downstream modules/libs that currently use the PCDs. >> >> Mike >> >> >>> -----Original Message----- >>> From: Kun Qin >>> Sent: Wednesday, July 13, 2022 5:39 PM >>> To: devel@edk2.groups.io; Kinney, Michael D >>> >>> Cc: Yao, Jiewen ; Wang, Jian J >>> ; Zhang, Qi1 ; Kumar, >>> Rahul1 >>> ; Andrew Fish ; Leif >>> Lindholm ; Gao, Liming >>> ; Liu, Zhiguang >>> Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM >>> subclass definition >>> >>> Hi Mike, >>> >>> The intention was to encourage the usage of new definition in .H file >>> once the definition >>> is updated. The PCD is left as is only to serve as backwards >>> compatibility purpose. >>> >>> Do you think only updating the DEC and .H file is more ideal? I could >>> drop the other changes >>> if so desired. >>> >>> Thanks, >>> Kun >>> >>> On 7/13/2022 5:30 PM, Michael D Kinney wrote: >>>> Hi Kun, >>>> >>>> Why was the PCD usage not preserved and only the value updated in >>>> the DEC file and .H file? >>>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: Kun Qin >>>>> Sent: Wednesday, July 13, 2022 5:21 PM >>>>> To: devel@edk2.groups.io >>>>> Cc: Yao, Jiewen ; Wang, Jian J >>>>> ; Zhang, Qi1 ; Kumar, >>> Rahul1 >>>>> ; Andrew Fish ; Leif >>>>> Lindholm ; Kinney, Michael D >>>>> ; Gao, Liming >>>>> ; Liu, Zhiguang >>>>> Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM >>>>> subclass definition >>>>> >>>>> Hi SecurityPkg maintainers & EDK2 stewards, >>>>> >>>>> I sent out this patch series intending to update/fix the PI spec >>>>> through >>>>> code first process. >>>>> >>>>> Could you please shed some light on it and let me know if any >>>>> feedback? >>>>> >>>>> Thanks in advance! >>>>> >>>>> Regards, >>>>> Kun >>>>> >>>>> On 7/5/2022 8:38 PM, Kun Qin via groups.io wrote: >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 >>>>>> >>>>>>    From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is >>>>>> defined as >>>>>> 0xD0000 (as well as included in PiStatusCode.h). >>>>>> >>>>>> However, subclass employed as PCD for TPM peripheral in >>>>>> SecurityPkg is >>>>>> also defined as 0xD0000. The TPM subclass code was used in >>>>>> TcgPei.c when >>>>>> reporting error codes. >>>>>> >>>>>> The collision of subclass definition could cause the parsing of >>>>>> reported >>>>>> errors being ambiguous. >>>>>> >>>>>> This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and >>>>>> removed potential usages in the SecurityPkg. >>>>>> >>>>>> Patch v1 branch: >>>>>> https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass >>>>>> >>>>>> Cc: Jiewen Yao >>>>>> Cc: Jian J Wang >>>>>> Cc: Qi Zhang >>>>>> Cc: Rahul Kumar >>>>>> Cc: Andrew Fish >>>>>> Cc: Leif Lindholm >>>>>> Cc: Michael D Kinney >>>>>> Cc: Liming Gao >>>>>> Cc: Zhiguang Liu >>>>>> >>>>>> Kun Qin (7): >>>>>>      EDK2 Code First: PI Specification: New peripheral subclass >>>>>> for TPM >>>>>>      MdePkg: MmCommunication: Add TPM subclass definition to MdePkg >>>>>>      SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice >>>>>>      SecurityPkg: Tcg2Pei: Replace PcdStatusCodeSubClassTpmDevice >>>>>>      SecurityPkg: TcgDxe: Replace PcdStatusCodeSubClassTpmDevice >>>>>>      SecurityPkg: TcgPei: Replace PcdStatusCodeSubClassTpmDevice >>>>>>      SecurityPkg: SubClassTpm: Updated default value >>>>>> >>>>>>     SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c   |  4 +- >>>>>>     SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c   |  4 +- >>>>>>     SecurityPkg/Tcg/TcgDxe/TcgDxe.c     |  2 +- >>>>>>     SecurityPkg/Tcg/TcgPei/TcgPei.c     |  4 +- >>>>>>     CodeFirst/BZ3966-SpecChange.md      | 60 ++++++++++++++++++++ >>>>>>     MdePkg/Include/Pi/PiStatusCode.h    |  1 + >>>>>>     SecurityPkg/SecurityPkg.dec         |  6 +- >>>>>>     SecurityPkg/SecurityPkg.uni         |  2 +- >>>>>>     SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf |  1 - >>>>>>     SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf |  1 - >>>>>>     SecurityPkg/Tcg/TcgDxe/TcgDxe.inf   |  1 - >>>>>>     SecurityPkg/Tcg/TcgPei/TcgPei.inf   |  1 - >>>>>>     12 files changed, 72 insertions(+), 15 deletions(-) >>>>>>     create mode 100644 CodeFirst/BZ3966-SpecChange.md >>>>>> >>>> >>>> >>>> >> >> >> >> > > > > >