From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mx.groups.io with SMTP id smtpd.web09.1933.1657758075521280720 for ; Wed, 13 Jul 2022 17:21:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XMa7f8qg; spf=pass (domain: gmail.com, ip: 209.85.215.178, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f178.google.com with SMTP id 72so104822pge.0 for ; Wed, 13 Jul 2022 17:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=CtgkkmnfK0i1+gOeUZmtL9NIwoUpvFhaHJjiijVwFxE=; b=XMa7f8qgihmiIiHQQaRk5ZM61RCyu2qJ7seG7BCcEp3mz0JHSeFPO6oyYgw5XtfnV3 hp5Xy2XZ1NjilJ7SLHVVos/wzIZLMEJNV9UwBk4TdUZiZXGOwYLAoyIdI9Jr5ZZ/K2E6 z0FgrpgL5x2AsUv+dDoxDYpeIZ6E1zdP8qqMfLCM9hJL4WEdGib6E2ToR7vC0buGZZ45 Pb2A/adwmI/oev/Gy0vRQRuMm1kWG50oHK6no68ZSnjkV96+DXURQcDhCIE3n/URjkcc UhDJPeqJiJ24L14Nss9V2v5/WXAnxkL+/baipfuMADn8+65C1vZcNFInaYaSIMbtDw0p YtGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=CtgkkmnfK0i1+gOeUZmtL9NIwoUpvFhaHJjiijVwFxE=; b=L3VXLl5rBLxb1NrzNo26UbR90wLl3L1uqOtpQUNdxdcdtNMyke82RDenPy14nvI3Un KyzmfSIguG2iZGVtQtZTyV8EuzbFthnUnvlC2Kpo1CJdhyoSHipaE+cZoAQ/7Xkw7g4S AJt+mTVhKu98LfJ10hF+T53Y9ITPp46vDAGIvIi51XC4Ted8rTt8Gqrkn7ybkcC4KdtU MYLZ2CYBFIF+akWU9w7oXsQbCnoy9H5llKmE+lJ4XGn+xEmkbp9d4cb8bEW+n8HDiAO2 4Jl6HVtbUistczk24mBCjyCZA+YnG3WhbwouEp6yEak79LZs9D3kd+Q/7jYuDziUHXbi dSZQ== X-Gm-Message-State: AJIora/78vcxdg100O9yMrX/TleKttP9KdghStCO/FW1+YogrDsdyYo+ XReI3wxOUQSbnF6W4ds9eSBs/PFALq4= X-Google-Smtp-Source: AGRyM1vwwDu5xZTx0o+5Cfn5iq7eMUc0Z+qlJZMkGSeMyDDfARtOqkoD01rmJR10JNNpHWC10cQDQw== X-Received: by 2002:a65:6b8a:0:b0:3db:7dc5:fec2 with SMTP id d10-20020a656b8a000000b003db7dc5fec2mr4977980pgw.223.1657758074798; Wed, 13 Jul 2022 17:21:14 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:b964:c1e8:26aa:4c24? ([2001:4898:80e8:0:3987:c1e8:26aa:4c24]) by smtp.gmail.com with ESMTPSA id v6-20020a1709029a0600b0016be834d54asm3627plp.306.2022.07.13.17.21.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 17:21:14 -0700 (PDT) Message-ID: <75d7d4ba-e930-1f97-7dc9-a2b85d8b66ed@gmail.com> Date: Wed, 13 Jul 2022 17:21:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar , Andrew Fish , Leif Lindholm , Michael D Kinney , Liming Gao , Zhiguang Liu References: <16FF20526D0669CC.28163@groups.io> From: "Kun Qin" In-Reply-To: <16FF20526D0669CC.28163@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi SecurityPkg maintainers & EDK2 stewards, I sent out this patch series intending to update/fix the PI spec through code first process. Could you please shed some light on it and let me know if any feedback? Thanks in advance! Regards, Kun On 7/5/2022 8:38 PM, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 > > From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as > 0xD0000 (as well as included in PiStatusCode.h). > > However, subclass employed as PCD for TPM peripheral in SecurityPkg is > also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when > reporting error codes. > > The collision of subclass definition could cause the parsing of reported > errors being ambiguous. > > This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and > removed potential usages in the SecurityPkg. > > Patch v1 branch: https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > > Kun Qin (7): > EDK2 Code First: PI Specification: New peripheral subclass for TPM > MdePkg: MmCommunication: Add TPM subclass definition to MdePkg > SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice > SecurityPkg: Tcg2Pei: Replace PcdStatusCodeSubClassTpmDevice > SecurityPkg: TcgDxe: Replace PcdStatusCodeSubClassTpmDevice > SecurityPkg: TcgPei: Replace PcdStatusCodeSubClassTpmDevice > SecurityPkg: SubClassTpm: Updated default value > > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 +- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +- > SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 2 +- > SecurityPkg/Tcg/TcgPei/TcgPei.c | 4 +- > CodeFirst/BZ3966-SpecChange.md | 60 ++++++++++++++++++++ > MdePkg/Include/Pi/PiStatusCode.h | 1 + > SecurityPkg/SecurityPkg.dec | 6 +- > SecurityPkg/SecurityPkg.uni | 2 +- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 - > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - > SecurityPkg/Tcg/TcgDxe/TcgDxe.inf | 1 - > SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 - > 12 files changed, 72 insertions(+), 15 deletions(-) > create mode 100644 CodeFirst/BZ3966-SpecChange.md >