From: Laszlo Ersek <lersek@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v3 4/5] OvmfPkg: Remove EdkShellBinPkg in FDF
Date: Mon, 5 Nov 2018 22:53:28 +0100 [thread overview]
Message-ID: <75e2954c-a1f3-6f10-816b-df6dbd41ff3b@redhat.com> (raw)
In-Reply-To: <b9477966-1507-9e11-71fb-4f906a4c7327@redhat.com>
On 11/05/18 22:50, Laszlo Ersek wrote:
> On 11/05/18 04:08, Shenglei Zhang wrote:
>> From: shenglei <shenglei.zhang@intel.com>
>>
>> Remove EdkShellBinPkg in OvmfPkgIa32.fdf,
>> OvmfPkg/OvmfPkgIa32X64.fdf amd OvmfPkg/OvmfPkgX64.fdf.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1108
>>
>> v2: Remove USE_OLD_SHELL in DSC because it will be
>> unnecessary to use it.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Change-Id: I4db7068a3a1f68a1f6303079b73dc548c9feb2e3
>
> (1) Please remove the Change-Id line from the commit message.
>
> (2) In order to be consistent with the other subject lines in the patch
> set, I suggest updating "FDF" to "FDF and DSC". (See the Nt32Pkg patch
> in particular.)
(and then update the commit message body too pls; it currently only
mentions the FDF files)
next prev parent reply other threads:[~2018-11-05 21:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:08 [PATCH v3 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC Shenglei Zhang
2018-11-05 3:08 ` [PATCH v3 1/5] Nt32Pkg: " Shenglei Zhang
2018-11-05 6:27 ` Ni, Ruiyu
2018-11-05 3:08 ` [PATCH v3 2/5] Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg Shenglei Zhang
2018-11-05 3:34 ` Wei, David
2018-11-05 3:08 ` [PATCH v3 3/5] EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC Shenglei Zhang
2018-11-05 6:26 ` Ni, Ruiyu
2018-11-05 3:08 ` [PATCH v3 4/5] OvmfPkg: Remove EdkShellBinPkg in FDF Shenglei Zhang
2018-11-05 21:50 ` Laszlo Ersek
2018-11-05 21:53 ` Laszlo Ersek [this message]
2018-11-05 3:08 ` [PATCH v3 5/5] CorebootPayloadPkg: " Shenglei Zhang
2018-11-05 6:04 ` You, Benjamin
2018-11-05 16:45 ` [PATCH v3 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e2954c-a1f3-6f10-816b-df6dbd41ff3b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox