Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Hi Ard,

V2 is now on the list.

Thanks,
Michael

On 2/10/2021 2:30 PM, Ard Biesheuvel wrote:
> On Wed, 3 Feb 2021 at 04:51, <mikuback@linux.microsoft.com> wrote:
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3204
>>
>> Fixes the following compiler warning in VS2019 by changing defining
>> the MmramRangeCount variable to be UINTN and type casting prior
>> to value assignment.
>>
>> \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): error C2220:
>>    the following warning is treated as an error
>> \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): warning C4244:
>>    '=': conversion from 'UINT64' to 'UINT32', possible loss of data
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   StandaloneMmPkg/Core/StandaloneMmCore.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c b/StandaloneMmPkg/Core/StandaloneMmCore.c
>> index 8388ec289ca8..d254a68f2fb8 100644
>> --- a/StandaloneMmPkg/Core/StandaloneMmCore.c
>> +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c
>> @@ -511,7 +511,7 @@ StandaloneMmMain (
>>     EFI_HOB_GUID_TYPE               *MmramRangesHob;
>>     EFI_MMRAM_HOB_DESCRIPTOR_BLOCK  *MmramRangesHobData;
>>     EFI_MMRAM_DESCRIPTOR            *MmramRanges;
>> -  UINT32                          MmramRangeCount;
>> +  UINTN                           MmramRangeCount;
>>     EFI_HOB_FIRMWARE_VOLUME         *BfvHob;
>>
>>     ProcessLibraryConstructorList (HobStart, &gMmCoreMmst);
>> @@ -546,7 +546,7 @@ StandaloneMmMain (
>>       MmramRangesHobData = GET_GUID_HOB_DATA (MmramRangesHob);
>>       ASSERT (MmramRangesHobData != NULL);
>>       MmramRanges = MmramRangesHobData->Descriptor;
>> -    MmramRangeCount = MmramRangesHobData->NumberOfMmReservedRegions;
>> +    MmramRangeCount = (UINTN) MmramRangesHobData->NumberOfMmReservedRegions;
>>       ASSERT (MmramRanges);
>>       ASSERT (MmramRangeCount);
>>
>> @@ -554,7 +554,7 @@ StandaloneMmMain (
>>       // Copy the MMRAM ranges into MM_CORE_PRIVATE_DATA table just in case any
>>       // code relies on them being present there
>>       //
>> -    gMmCorePrivate->MmramRangeCount = MmramRangeCount;
>> +    gMmCorePrivate->MmramRangeCount = (UINT64) MmramRangeCount;
>>       gMmCorePrivate->MmramRanges =
>>         (EFI_PHYSICAL_ADDRESS)(UINTN)AllocatePool (MmramRangeCount * sizeof (EFI_MMRAM_DESCRIPTOR));
>>       ASSERT (gMmCorePrivate->MmramRanges != 0);
>> @@ -567,7 +567,7 @@ StandaloneMmMain (
>>       DataInHob       = GET_GUID_HOB_DATA (GuidHob);
>>       gMmCorePrivate = (MM_CORE_PRIVATE_DATA *)(UINTN)DataInHob->Address;
>>       MmramRanges     = (EFI_MMRAM_DESCRIPTOR *)(UINTN)gMmCorePrivate->MmramRanges;
>> -    MmramRangeCount = gMmCorePrivate->MmramRangeCount;
>> +    MmramRangeCount = (UINTN) gMmCorePrivate->MmramRangeCount;
>>     }
>>
>>     //
>> --
>> 2.28.0.windows.1
>>
>>
>>
>> ------------
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#71087): https://edk2.groups.io/g/devel/message/71087
>> Mute This Topic: https://groups.io/mt/80346365/5717338
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
>> ------------
>>
>>
> 
> This patch seems to have gotten mangled, so I can't apply it. Could
> you please resend it with git send-email after you fixed up the
> whitespace?
> 
> Thanks
> Ard.
> 
> 
> 
>