From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.18975.1592230331176636059 for ; Mon, 15 Jun 2020 07:12:11 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDB3331B; Mon, 15 Jun 2020 07:12:09 -0700 (PDT) Received: from [192.168.1.69] (unknown [10.37.8.36]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C16963F6CF; Mon, 15 Jun 2020 07:12:08 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly To: sami.mujawar@arm.com, devel@edk2.groups.io References: <20200610081740.54581-6-ard.biesheuvel@arm.com> <29709.1592229598095627048@groups.io> From: "Ard Biesheuvel" Message-ID: <75f6a173-239e-bf3f-3394-22fef4a030c1@arm.com> Date: Mon, 15 Jun 2020 16:12:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <29709.1592229598095627048@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/15/20 3:59 PM, Sami Mujawar via Groups.Io wrote: > Apologies for top replying. I am not sure if it is my setup where I see > additional characters (e.g. =0D at the end of each line) which appear to > confuse my email client. > That must be Thunderbird playing tricks. > > > UpdateMmFoundationPeCoffPermissions (=0D > > IN CONST PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext,=0D > > + IN EFI_PHYSICAL_ADDRESS ImageBase,=0D > Can the function documentation for UpdateMmFoundationPeCoffPermissions() > and GetStandaloneMmCorePeCoffSections() be updated to reflect the > additional parameter ImageBase, please? > Sure > On Wed, Jun 10, 2020 at 01:17 AM, Ard Biesheuvel wrote: > > + *ImageBase =3D ImageContext->ImageAddress;=0D > > I think the '*ImageBase = ImageContext->ImageAddress;' statement can be > moved inside the if condition. No, the TE branch of the if() does a subtraction so it needs the value to be set beforehand. > With these changes. > > Reviewed-by: Sami Mujawar > > Sami Mujawar