Re: [edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Add HobPrintLib in StandaloneMm

["PierreGondois" <pierre.gondois@arm.com>]

Hello Levi,
NIT:
I think it's commit 049e12c03d27 ("StandaloneMmPkg/Core: Dump all HOB info in entrypoint")
which breaks the build (whenever StandaloneMmPkg/Core/StandaloneMmCore.inf is used).

The following platforms should have the same modification I think:
- Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc
- Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc

Regards,
Pierre

On 8/5/24 14:30, Levi Yun wrote:
> From: "levi.yun" <yeoreum.yun@arm.com>
> 
> commit: d5b03d5fba30d ("MdeModulePkg: Add HobPrintLib instance")
> adds HobPinrtLib which causes build failure for StandaloneMm
> To fix build failure, add HobPrintLib for StandaloneMm.
> 
> Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
> ---
>   Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc b/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
> index a0a9d9a21a1b6682ff43d23ee82245219155c941..127b1e3bb729a563b8e0fe03b95b92673695a9a3 100644
> --- a/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
> +++ b/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
> @@ -55,6 +55,7 @@ [LibraryClasses]
>     ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
>     FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf
>     HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
> +  HobPrintLib|MdeModulePkg/Library/HobPrintLib/HobPrintLib.inf
>     IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>     MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
>     MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120292): https://edk2.groups.io/g/devel/message/120292
Mute This Topic: https://groups.io/mt/107730605/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-