* [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies
@ 2021-08-10 4:37 Nate DeSimone
2021-08-10 17:33 ` [edk2-devel] " Michael Kubacki
2021-08-11 1:56 ` Chiu, Chasel
0 siblings, 2 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-08-10 4:37 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Michael Kubacki, Benjamin Doron
PeiFspWrapperHobProcessLib is currently set to depens on
FspWrapperPlatformLib, but it does not use any of the
functions implemented by that LibraryClass. This change
removes that unneeded dependency.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
Cc: Benjamin Doron <benjamin.doron00@gmail.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
index 64f3302959..b846e7af1d 100644
--- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
+++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
@@ -1,7 +1,7 @@
## @file
# Provide FSP wrapper hob process related function.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -55,7 +55,6 @@
BaseMemoryLib
HobLib
DebugLib
- FspWrapperPlatformLib
PeiServicesLib
PeiServicesTablePointerLib
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies
2021-08-10 4:37 [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies Nate DeSimone
@ 2021-08-10 17:33 ` Michael Kubacki
2021-08-11 1:56 ` Chiu, Chasel
1 sibling, 0 replies; 4+ messages in thread
From: Michael Kubacki @ 2021-08-10 17:33 UTC (permalink / raw)
To: devel, nathaniel.l.desimone; +Cc: Chasel Chiu, Michael Kubacki, Benjamin Doron
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 8/10/2021 12:37 AM, Nate DeSimone wrote:
> PeiFspWrapperHobProcessLib is currently set to depens on
> FspWrapperPlatformLib, but it does not use any of the
> functions implemented by that LibraryClass. This change
> removes that unneeded dependency.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
> Cc: Benjamin Doron <benjamin.doron00@gmail.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
> index 64f3302959..b846e7af1d 100644
> --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
> @@ -1,7 +1,7 @@
> ## @file
> # Provide FSP wrapper hob process related function.
> #
> -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -55,7 +55,6 @@
> BaseMemoryLib
> HobLib
> DebugLib
> - FspWrapperPlatformLib
> PeiServicesLib
> PeiServicesTablePointerLib
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies
2021-08-10 4:37 [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies Nate DeSimone
2021-08-10 17:33 ` [edk2-devel] " Michael Kubacki
@ 2021-08-11 1:56 ` Chiu, Chasel
1 sibling, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2021-08-11 1:56 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Michael Kubacki, Benjamin Doron
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, August 10, 2021 12:37 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Michael Kubacki
> <Michael.Kubacki@microsoft.com>; Benjamin Doron
> <benjamin.doron00@gmail.com>
> Subject: [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup
> PeiFspWrapperHobProcessLib dependencies
>
> PeiFspWrapperHobProcessLib is currently set to depens on
> FspWrapperPlatformLib, but it does not use any of the functions
> implemented by that LibraryClass. This change removes that unneeded
> dependency.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
> Cc: Benjamin Doron <benjamin.doron00@gmail.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP
> rocessLib/PeiFspWrapperHobProcessLib.inf
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP
> rocessLib/PeiFspWrapperHobProcessLib.inf
> index 64f3302959..b846e7af1d 100644
> ---
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP
> rocessLib/PeiFspWrapperHobProcessLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP
> +++ rocessLib/PeiFspWrapperHobProcessLib.inf
> @@ -1,7 +1,7 @@
> ## @file
> # Provide FSP wrapper hob process related function.
> #
> -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights
> +reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -55,7 +55,6 @@
> BaseMemoryLib
> HobLib
> DebugLib
> - FspWrapperPlatformLib
> PeiServicesLib
> PeiServicesTablePointerLib
>
> --
> 2.27.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies
[not found] <1699D802D6EAAC4D.15153@groups.io>
@ 2021-08-12 0:19 ` Nate DeSimone
0 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-08-12 0:19 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Nathaniel L
Cc: Chiu, Chasel, Michael Kubacki, Benjamin Doron
Pushed: https://github.com/tianocore/edk2-platforms/commit/d67ac56
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Monday, August 9, 2021 9:37 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Michael Kubacki <Michael.Kubacki@microsoft.com>; Benjamin Doron <benjamin.doron00@gmail.com>
Subject: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies
PeiFspWrapperHobProcessLib is currently set to depens on FspWrapperPlatformLib, but it does not use any of the functions implemented by that LibraryClass. This change removes that unneeded dependency.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
Cc: Benjamin Doron <benjamin.doron00@gmail.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
index 64f3302959..b846e7af1d 100644
--- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf
+++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP
+++ rocessLib/PeiFspWrapperHobProcessLib.inf
@@ -1,7 +1,7 @@
## @file
# Provide FSP wrapper hob process related function.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights
+reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -55,7 +55,6 @@
BaseMemoryLib
HobLib
DebugLib
- FspWrapperPlatformLib
PeiServicesLib
PeiServicesTablePointerLib
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-12 0:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-10 4:37 [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies Nate DeSimone
2021-08-10 17:33 ` [edk2-devel] " Michael Kubacki
2021-08-11 1:56 ` Chiu, Chasel
[not found] <1699D802D6EAAC4D.15153@groups.io>
2021-08-12 0:19 ` [edk2-devel] " Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox