From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E15520985998 for ; Wed, 30 Jan 2019 04:59:55 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 04:59:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="142696141" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 30 Jan 2019 04:59:54 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 050ED580297; Wed, 30 Jan 2019 04:59:52 -0800 (PST) Message-ID: <75fd795279332fdece29fb6ba6911f0d8c28512d.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 13:59:50 +0100 In-Reply-To: <20181106175833.26964-11-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-11-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 12:59:55 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > The Data4 member of the GUID/EFI_GUID struct type is an array of > UINT8, so literals require two sets of { } braces. Add them where > missing. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++-- > IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > index bd7d4defc9a3..72f6a95ccb6d 100644 > --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > @@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > > #define E1000_HII_FORM_GUID \ > { \ > - 0x77f2ea2f, 0x4312, 0x4569, 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, > 0xb7, 0xe2 \ > + 0x77f2ea2f, 0x4312, 0x4569, { 0x85, 0xc4, 0x58, 0x3a, 0xcd, > 0x8d, 0xb7, 0xe2 } \ > } > > #define E1000_HII_DATA_GUID \ > { \ > - 0xa31abb16, 0xc627, 0x475b, 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, > 0x40, 0xf3 \ > + 0xa31abb16, 0xc627, 0x475b, { 0x98, 0x8e, 0x7e, 0xe0, 0x77, > 0x67, 0x40, 0xf3 } \ > } > > > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h > b/IntelUndiPkg/GigUndiDxe/StartStop.h > index 255f17aabaa4..b29a5002bb8e 100644 > --- a/IntelUndiPkg/GigUndiDxe/StartStop.h > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h > @@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #include "e1000.h" > > #define EFI_DRIVER_STOP_PROTOCOL_GUID \ > -{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ > -0xb5, 0xfd, 0x7d, 0xc1 } > +{ 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \ > +0xb5, 0xfd, 0x7d, 0xc1 } } > > typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL; >