From: Laszlo Ersek <lersek@redhat.com>
To: "Ye, Ting" <ting.ye@intel.com>, "Long, Qin" <qin.long@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate
Date: Fri, 22 Sep 2017 13:28:18 +0200 [thread overview]
Message-ID: <76085501-2727-dca0-c852-7a34289529c9@redhat.com> (raw)
In-Reply-To: <BC0C045B0E2A584CA4575E779FA2C12A1A969DB0@SHSMSX103.ccr.corp.intel.com>
On 09/21/17 05:50, Ye, Ting wrote:
> Hi Qin,
>
> I think we might add OPTIONAL attribute to CommonName, as NULL is an valid input for this API.
> In function description, I think we need update below statement to "if *** and *CommonNameSize is 0."
>
> "If CommonName is not NULL and CommonNameSize is 0."
>
> Others are good to me.
>
> Reviewed-by: Ye Ting <ting.ye@intel.com>
With those updates, the X509GetCommonName() interface looks good to me
as well.
I didn't check the implementation.
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
next prev parent reply other threads:[~2017-09-22 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 2:48 [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate Qin Long
2017-09-21 3:50 ` Ye, Ting
2017-09-22 11:28 ` Laszlo Ersek [this message]
2017-09-28 6:02 ` Zhang, Chao B
2017-09-28 6:49 ` Long, Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76085501-2727-dca0-c852-7a34289529c9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox