public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Lubo" <lubo.zhang@intel.com>
To: Santhapur Naveen <naveens@amiindia.co.in>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: 2nd HttpBoot fails even after upgrading to revision 24729
Date: Wed, 24 Aug 2016 10:52:35 +0000	[thread overview]
Message-ID: <7619447B08B8F74DA4FF2A813B79803B01A53649@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <625A2455CC232F40B0F38F05ACED6D976C541869@VENUS1.in.megatrends.com>

Hi Naveen
      I have checked the issue you mentioned. On my side, I updated the code to latest and do some test on NT32 and Denlow platform, both the first http boot and 2nd are successful. 
      Until now , we have fixed few bugs which may lead the 2nd http boot fail. As for the patch you mentioned is one case to fix the bug, So I suggest you to update the code firstly and at least make sure the HttpDxe , HttpBootDxe and DxeHttpLib are latest. 
   
     If any result, Pls let me know.

Best Regards
Lubo 
     

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo <lubo.zhang@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

	Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg pointer should point a correct location.Now after the first  successful httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after the last byte, it may be a bad buffer if we don't receive another HttpHeader, so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot fail, so we need to check this case in HttpBodyParserCallback function in the first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-----Original Message-----
From: Zhang, Lubo [mailto:lubo.zhang@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
     Could you list the patch name or Git SHA value which fixed the 2nd HttpBootfail issue. On my side, the SVN version 24729 is not exist.

Thanks 
Lubo 

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Santhapur Naveen
Sent: Wednesday, August 24, 2016 3:40 PM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hello,

          Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2016-08-24 10:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24  7:39 2nd HttpBoot fails even after upgrading to revision 24729 Santhapur Naveen
2016-08-24  8:42 ` Zhang, Lubo
2016-08-24  8:52   ` Santhapur Naveen
2016-08-24  9:09     ` Zhang, Lubo
2016-08-24 10:52     ` Zhang, Lubo [this message]
2016-08-24 11:09       ` Santhapur Naveen
2016-08-25  1:49         ` Zhang, Lubo
2016-08-25  9:09           ` Santhapur Naveen
2016-08-25  9:48             ` Zhang, Lubo
2016-08-29  6:26               ` Santhapur Naveen
2016-08-29  7:18                 ` Zhang, Lubo
2016-08-25  9:13           ` Santhapur Naveen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7619447B08B8F74DA4FF2A813B79803B01A53649@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox