From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE07B81F47 for ; Tue, 6 Dec 2016 19:45:43 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 06 Dec 2016 19:45:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="909515735" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 06 Dec 2016 19:45:43 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 6 Dec 2016 19:45:42 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 6 Dec 2016 19:45:42 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 11:45:40 +0800 From: "Zhang, Lubo" To: Gary Lin , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH] ShellPkg: Assign the correct value to ShellStatus Thread-Index: AQHSUDvPTOL1acm6REyq4ljZnQWB/6D72BHw Date: Wed, 7 Dec 2016 03:45:40 +0000 Message-ID: <7619447B08B8F74DA4FF2A813B79803B378FF8CC@shsmsx102.ccr.corp.intel.com> References: <20161207034051.12723-1-glin@suse.com> In-Reply-To: <20161207034051.12723-1-glin@suse.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 03:45:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhang Lubo -----Original Message----- From: Gary Lin [mailto:glin@suse.com]=20 Sent: Wednesday, December 07, 2016 11:41 AM To: edk2-devel@lists.01.org Cc: Zhang, Lubo ; Ye, Ting ; Fu, S= iyuan ; Wu, Jiaxin Subject: [PATCH] ShellPkg: Assign the correct value to ShellStatus Since the type of ShellStatus is SHELL_STATUS, we should use SHELL_INVALID_= PARAMETER instead of EFI_INVALID_PARAMETER. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin Cc: Zhang Lubo Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/Sh= ellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c index fb308cc3b6..d71688ed66 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo ( =20 if (StrCmp (VarArg->Arg, L"host") =3D=3D 0) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INV= ALID_IP_CONFIG), gShellNetwork2HiiHandle, Status); - ShellStatus =3D EFI_INVALID_PARAMETER; + ShellStatus =3D SHELL_INVALID_PARAMETER; goto ON_EXIT; } else if (StrCmp (VarArg->Arg, L"gw") =3D=3D 0) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INV= ALID_GW_CONFIG), gShellNetwork2HiiHandle, Status); - ShellStatus =3D EFI_INVALID_PARAMETER; + ShellStatus =3D SHELL_INVALID_PARAMETER; goto ON_EXIT; } else if (StrCmp (VarArg->Arg, L"dns") =3D=3D 0) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INV= ALID_DNS_CONFIG), gShellNetwork2HiiHandle, Status); - ShellStatus =3D EFI_INVALID_PARAMETER; + ShellStatus =3D SHELL_INVALID_PARAMETER; goto ON_EXIT; } =20 -- 2.11.0