From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0C4F48204A for ; Thu, 9 Feb 2017 19:38:25 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 09 Feb 2017 19:38:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,138,1484035200"; d="scan'208";a="1124590015" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 09 Feb 2017 19:38:24 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 9 Feb 2017 19:38:24 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 9 Feb 2017 19:38:24 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Fri, 10 Feb 2017 11:38:22 +0800 From: "Zhang, Lubo" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: Santhapur Naveen , "Ye, Ting" , "Fu, Siyuan" Thread-Topic: [patch] NetworkPkg:Generate the correct operational state of the interface. Thread-Index: AQHSg0xN6j69Orpz702OL7mHKs9E/KFhlcMwgAABQ+A= Date: Fri, 10 Feb 2017 03:38:21 +0000 Message-ID: <7619447B08B8F74DA4FF2A813B79803B39AF7AAA@shsmsx102.ccr.corp.intel.com> References: <1486696674-41256-1-git-send-email-lubo.zhang@intel.com> <895558F6EA4E3B41AC93A00D163B72741629A18B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B72741629A18B@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] NetworkPkg:Generate the correct operational state of the interface. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 03:38:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, I just find the typo error. Thanks Lubo -----Original Message----- From: Wu, Jiaxin=20 Sent: Friday, February 10, 2017 11:33 AM To: Zhang, Lubo ; edk2-devel@lists.01.org Cc: Santhapur Naveen ; Ye, Ting = ; Fu, Siyuan Subject: RE: [patch] NetworkPkg:Generate the correct operational state of t= he interface. Need change the commit log, replace the 'ifconfig -l' with 'ifconfig6 -l' s= ince it's the fix for IPv6. Others is good to me. Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -----Original Message----- > From: Zhang, Lubo > Sent: Friday, February 10, 2017 11:18 AM > To: edk2-devel@lists.01.org > Cc: Santhapur Naveen ; Ye, Ting=20 > ; Fu, Siyuan ; Wu, Jiaxin=20 > > Subject: [patch] NetworkPkg:Generate the correct operational state of=20 > the interface. >=20 > Currently, When there are more than 9 Ethernet ports available,=20 > 'ifconfig -l' is not listing all the ports, only show the ports 0 to 9. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Cc: Santhapur Naveen > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Wu Jiaxin > --- > NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) >=20 > diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > index 4e881fd..e309b69 100644 > --- a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > +++ b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > @@ -1436,15 +1436,16 @@ VOID > Ip6ConfigInitIfInfo ( > IN IP6_SERVICE *IpSb, > OUT EFI_IP6_CONFIG_INTERFACE_INFO *IfInfo > ) > { > - IfInfo->Name[0] =3D L'e'; > - IfInfo->Name[1] =3D L't'; > - IfInfo->Name[2] =3D L'h'; > - IfInfo->Name[3] =3D (CHAR16) (L'0' +=20 > IpSb->Ip6ConfigInstance.IfIndex); > - IfInfo->Name[4] =3D 0; > + UnicodeSPrint ( > + IfInfo->Name, > + sizeof (IfInfo->Name), > + L"eth%x", > + IpSb->Ip6ConfigInstance.IfIndex > + ); >=20 > IfInfo->IfType =3D IpSb->SnpMode.IfType; > IfInfo->HwAddressSize =3D IpSb->SnpMode.HwAddressSize; > CopyMem (&IfInfo->HwAddress, &IpSb->SnpMode.CurrentAddress, > IfInfo->HwAddressSize); > } > -- > 1.9.5.msysgit.1