From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B5D8F82220 for ; Wed, 22 Feb 2017 00:39:21 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 22 Feb 2017 00:39:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,193,1484035200"; d="scan'208";a="51174595" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 22 Feb 2017 00:39:21 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 22 Feb 2017 00:39:21 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 22 Feb 2017 00:39:20 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Wed, 22 Feb 2017 16:39:18 +0800 From: "Zhang, Lubo" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Long, Qin" Thread-Topic: [edk2] [patch] SecurityPkg: Fix potential bug in Security Boot dxe. Thread-Index: AQHSi+231Myf9hBwTECo4fLqEGyyHaF0s6cAgAAByqA= Date: Wed, 22 Feb 2017 08:39:18 +0000 Message-ID: <7619447B08B8F74DA4FF2A813B79803B39AFA319@shsmsx102.ccr.corp.intel.com> References: <1487645605-11008-1-git-send-email-lubo.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] SecurityPkg: Fix potential bug in Security Boot dxe. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 08:39:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Thanks , I will update the HASH value definition in VFR to keep them cons= istent with macro definition . > -----Original Message----- > From: Zhang, Chao B > Sent: Wednesday, February 22, 2017 4:31 PM > To: Zhang, Lubo ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Long, Qin > Subject: RE: [edk2] [patch] SecurityPkg: Fix potential bug in Security Bo= ot dxe. >=20 > Lubo=1B$B!'=1B(B > If you change HASH algo definition, please also update SecureBootConf= ig.vfr > accordingly. > Or you may keep SHA1 algo definition & keep RAW & MAX unchanged >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zh= ang > Lubo > Sent: Tuesday, February 21, 2017 10:53 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > ; Long, Qin > Subject: [edk2] [patch] SecurityPkg: Fix potential bug in Security Boot d= xe. >=20 > since we removed the sha-1 definition in Hash table and related macro, bu= t the > macro definition HashAlg index may be value 4 which is exceed the range o= f the > Hash table array. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Cc: Chao Zhang > Cc: Long Qin > Cc: Yao Jiewen > --- > .../SecureBootConfigDxe/SecureBootConfigImpl.h | 12 ++++++= ------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.h > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.h > index bea9470..58030c4 100644 > --- > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI > mpl.h > +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootCo > +++ nfigImpl.h > @@ -89,16 +89,16 @@ extern EFI_IFR_GUID_LABEL *mEndLabel; > #define WIN_CERT_UEFI_RSA2048_SIZE 256 >=20 > // > // Support hash types > // > -#define HASHALG_SHA224 0x00000001 > -#define HASHALG_SHA256 0x00000002 > -#define HASHALG_SHA384 0x00000003 > -#define HASHALG_SHA512 0x00000004 > -#define HASHALG_RAW 0x00000005 > -#define HASHALG_MAX 0x00000005 > +#define HASHALG_SHA224 0x00000000 > +#define HASHALG_SHA256 0x00000001 > +#define HASHALG_SHA384 0x00000002 > +#define HASHALG_SHA512 0x00000003 > +#define HASHALG_RAW 0x00000004 > +#define HASHALG_MAX 0x00000004 >=20 >=20 > typedef struct { > UINTN Signature; > LIST_ENTRY Head; > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel