From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 366DE21A18AAA for ; Sun, 16 Apr 2017 20:46:31 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 16 Apr 2017 20:46:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,213,1488873600"; d="scan'208";a="249942557" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 16 Apr 2017 20:46:28 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 16 Apr 2017 20:46:27 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Mon, 17 Apr 2017 11:46:24 +0800 From: "Zhang, Lubo" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: Subramanian Sriram , "Ye, Ting" , "Fu, Siyuan" Thread-Topic: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList Thread-Index: AQHStyt1mxy+hTMuBk6GEAu8wOttHqHI6+YQ Date: Mon, 17 Apr 2017 03:46:23 +0000 Message-ID: <7619447B08B8F74DA4FF2A813B79803B39B22C5A@shsmsx102.ccr.corp.intel.com> References: <1492400035-6092-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1492400035-6092-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2017 03:46:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhang Lubo -----Original Message----- From: Wu, Jiaxin=20 Sent: Monday, April 17, 2017 11:34 AM To: edk2-devel@lists.01.org Cc: Subramanian Sriram ; Ye, Ting ; Fu= , Siyuan ; Zhang, Lubo ; Wu, Jia= xin Subject: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList Cc: Subramanian Sriram Cc: Ye Ting Cc: Fu Siyuan Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c b/MdeModulePkg/U= niversal/Network/Ip4Dxe/Ip4If.c index 7512a00..d29d873 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c @@ -853,11 +853,11 @@ Ip4OnArpResolvedDpc ( // InsertTailList (&Interface->SentFrames, &Token->Link); =20 Status =3D Interface->Mnp->Transmit (Interface->Mnp, &Token->MnpToken)= ; if (EFI_ERROR (Status)) { - RemoveEntryList (Entry); + RemoveEntryList (&Token->Link); Token->CallBack (Token->IpInstance, Token->Packet, Status, 0, Token-= >Context); =20 Ip4FreeLinkTxToken (Token); continue; } @@ -1079,11 +1079,11 @@ SEND_NOW: // Remove it if the returned status is not EFI_SUCCESS. // InsertTailList (&Interface->SentFrames, &Token->Link); Status =3D Interface->Mnp->Transmit (Interface->Mnp, &Token->MnpToken); if (EFI_ERROR (Status)) { - RemoveEntryList (&Interface->SentFrames); + RemoveEntryList (&Token->Link); goto ON_ERROR; } =20 return EFI_SUCCESS; =20 --=20 1.9.5.msysgit.1